chef-server-webui incompatible with merb 1.1.0

jtimberman added a comment - 29/Mar/10 6:47 AM Fixed in http://github.com/jtimberman/chef/tree/CHEF-1072 by specifying version 1.0.15, but long term should fix webui to work with 1.1.0.

Ian Meyer added a comment - 29/Mar/10 4:51 PM I think I've found the source of the problem to be how scope.resources :controllername is used. scope.resources :clients breaks but: scope.match('/users').to(:controller => 'users', :action => 'index').name(:users) scope.match('/users/create').to(:controller => 'users', :action => 'create').name(:users_create) scope.match('/users/start').to(:controller => 'users', :action => 'start').name(:users_start) works as expected I'm going to take a stab at fixing this, and also making sure it doesn't break with merb < 1.1.0

James Sulinski added a comment - 01/Apr/10 8:45 PM Has anyone made progress on this issue? I spent a while diffing the merb 1.0.15 to 1.1.0 changes and didn't hone in on what has changed, but I have no previous experience with the merb source. The issue definitely relates to links in navigation.html.haml and other places related to: new_role, new_node, new_databag, new_client. Routes which do work are: search, status, cookbooks and users; none of which use the new_ syntax. However, it isn't just the new_ links which are breaking, but others with similar syntax as well, all of which should theoretically be covered by the scope.resources declaration. Here's the backtrace: merb : worker (port 4040) ~ Params: {"format"=>nil, "action"=>"index", "controller"=>"chef_server_webui/clients"} merb : worker (port 4040) ~ Named route not found: new_client - (Merb::Router::GenerationError) /usr/lib/ruby/gems/1.8/gems/merb-slices-1.1.0/lib/merb-slices/controller_mixin.rb:153:in `slice_url' /usr/lib/ruby/gems/1.8/gems/chef-server-webui-0.8.8/app/views/clients/_navigation.html.haml:3:in `__usr__lib__ruby__gems__1_8__gems__chef__server__webui__0_8_8__app__views__clients____navigation_html_haml' /usr/lib/ruby/gems/1.8/gems/merb-core-1.1.0/lib/merb-core/controller/mixins/render.rb:326:in `send' /usr/lib/ruby/gems/1.8/gems/merb-core-1.1.0/lib/merb-core/controller/mixins/render.rb:326:in `partial' /usr/lib/ruby/gems/1.8/gems/merb-core-1.1.0/lib/merb-core/controller/mixins/render.rb:321:in `map' /usr/lib/ruby/gems/1.8/gems/merb-core-1.1.0/lib/merb-core/controller/mixins/render.rb:321:in `partial' /usr/lib/ruby/gems/1.8/gems/chef-server-webui-0.8.8/app/views/clients/index.html.haml:4:in `__usr__lib__ruby__gems__1_8__gems__chef__server__webui__0_8_8__app__views__clients__index_html_haml' Here is the working users navigation: app/views/users/_navigation.html.haml .secondary-navigation %ul %li{ :class => "first #{active == 'index' ? "active" : ''}"}= link_to('List', slice_url(:users)) %li{ :class => (active == 'create' ? "active" : '')}= link_to('Create', slice_url(:users_new)) - if active != 'create' && active != 'index' %li{ :class => (active == 'show' ? "active" : '')}= link_to('Show', slice_url(:users_show)) %li{ :class => (active == 'edit' ? "active" : '')}= link_to('Edit', slice_url(:users_edit, :user_id => params[:user_id])) %li= link_to('Delete', slice_url(:users_delete, :user_id => params[:user_id]), :method => "delete", :confirm => "Really delete user #{params[:user_id]}? There is no undo.") .clear And the non-working clients navigation: app/views/clients/_navigation.html.haml .secondary-navigation %ul %li{ :class => "first #{active == 'index' ? "active" : ''}"}= link_to('List', slice_url(:clients)) %li{ :class => (active == 'create' ? "active" : '')}= link_to('Create', slice_url(:new_client)) - if active != 'create' && active != 'index' %li{ :class => (active == 'show' ? "active" : '')}= link_to('Show', slice_url(:client, @client.name)) %li{ :class => (active == 'edit' ? "active" : '')}= link_to('Edit', slice_url(:edit_client, @client.name)) %li= link_to('Delete', slice_url(:client, @client.name), :method => "delete", :confirm => "Really delete Role #{@client.name}? There is no undo.") .clear

Guy Bolton King added a comment - 02/Apr/10 9:05 AM See also CHEF-1064 for the fix to the version constraints: this appears to have made it into 0.8.10 (sorry Josh, I didn't see your fix when I made mine six hours later...).

jtimberman added a comment - 02/Apr/10 4:03 PM No worries, Guy. Hopefully we'll have an actual fix in the code rather than play versioning dances.

Daniel DeLeo added a comment - 26/Apr/10 7:59 AM Ohai everyone, I've got pretty much everything working here: http://github.com/danielsdeleo/chef/tree/CHEF-1072 All of the cucumber tests for the API server pass, but unfortunately we don't have any tests for the webui. I've tested by logging in and creating a few types of objects, but I'd love it if you guys could give this a spin and report any issues you find. Please report bugs by commenting on this ticket, and feel free to discuss them with me on IRC. Thanks in advance, Dan DeLeo

Daniel DeLeo added a comment - 26/Apr/10 10:38 PM Found one bug in the webui: http://gist.github.com/380017

Daniel DeLeo added a comment - 27/Apr/10 3:37 AM ok, I believe this issue should be fixed.

Daniel DeLeo added a comment - 01/May/10 8:53 PM I believe this patch is reviewed enough to merge, however, the chef-server section of the tree has been purged, which means that OS packages will need to be updated. For this reason, we can't apply the patch before 0.9.0.

Daniel DeLeo added a comment - 10/May/10 7:07 PM This is fixed in the 0.9-alpha branch. Feel free to report any issues as new tickets, thanks.