/etc/init.d/chef-solr on centos doesn't set pidfile correctly

Details

  • Type: Bug Bug
  • Status: Closed Closed
  • Priority: Major Major
  • Resolution: Fixed
  • Affects Version/s: 0.9.16, 0.10.0
  • Fix Version/s: 0.10.0
  • Component/s: Chef Server
  • Labels:
    None
  • Environment:

    centos 5.3, run_style=init, all redhat

Description

When using run_style=init, the init script for chef-solr (and I think the other daemons) does not use the -P option to start chef-solr. As a result, chef-solr defaults to using /tmp/chef-solr.pid instead of the pidfile specified in /etc/sysconfig/chef-solr or the default in /etc/init.d/chef-solr. Because of this service chef-solr stop/restart fails.

The fix is to add -P "$pidfile" in /etc/init.d/chef-solr in the start() function right before the "$options":

daemon $prog -d -c "$config" -u "$user" -g "$group" -L "$logfile" -P "$pidfile" "&>/dev/null"

Note too that you'll have to chown /var/run/chef to be owned by chef:chef.

Issue Links

is duplicated by

Bug - A problem which impairs or prevents the functions of the product. CHEF-1837 chef-solr init scripts

  • Minor - Minor loss of function, or other problem where easy workaround is present.
  • Closed - The issue is considered finished, the resolution is correct. Issues which are closed can be reopened.

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Chris Chalfant added a comment - - edited

Also need to add -p "$pidfile" to call to killproc in stop() function:

killproc -p "$pidfile" $prog

Show
Chris Chalfant added a comment - - edited Also need to add -p "$pidfile" to call to killproc in stop() function: killproc -p "$pidfile" $prog
Hide
Permalink
Matthew Kent added a comment -

I'm nearly done 0.8.10 packages and part of those are new init scripts. I'll be submitting them for inclusion in Chef as well.

Show
Matthew Kent added a comment - I'm nearly done 0.8.10 packages and part of those are new init scripts. I'll be submitting them for inclusion in Chef as well.
Hide
Permalink
Matthew Kent added a comment -

Fixed in CHEF-1130

Show
Matthew Kent added a comment - Fixed in CHEF-1130
Hide
Permalink
KC Braunschweig added a comment -

This seems to have been dropped back out of chef-solr several versions back and also wasn't setup properly when the chef-expander init script was written. The stop() function is correct, but start() doesn't specify the pidfile like it should.

Show
KC Braunschweig added a comment - This seems to have been dropped back out of chef-solr several versions back and also wasn't setup properly when the chef-expander init script was written. The stop() function is correct, but start() doesn't specify the pidfile like it should.
Hide
Permalink
KC Braunschweig added a comment -

Re-opening this as it was marked a duplicate of CHEF-1130 but that bug fixed several different issues. This is a regression of this specific issue only.

Show
KC Braunschweig added a comment - Re-opening this as it was marked a duplicate of CHEF-1130 but that bug fixed several different issues. This is a regression of this specific issue only.
Hide
Permalink
Matthew Kent added a comment -

Apologies for not actually fixing this the first time.

Fixed in both 0.9.16 and master if you could pull from:

https://github.com/mdkent/chef/tree/CHEF-1074
https://github.com/mdkent/chef/tree/CHEF-1074-master

Show
Matthew Kent added a comment - Apologies for not actually fixing this the first time. Fixed in both 0.9.16 and master if you could pull from: https://github.com/mdkent/chef/tree/CHEF-1074 https://github.com/mdkent/chef/tree/CHEF-1074-master
Hide
Permalink
Daniel DeLeo added a comment -

Fix merged for 0.10. Leaving it open so we'll get to it for 0.9.18

Show
Daniel DeLeo added a comment - Fix merged for 0.10. Leaving it open so we'll get to it for 0.9.18
Hide
Permalink
Bryan McLellan [Opscode] added a comment -

Wrong ticket, re-resolving.

Show
Bryan McLellan [Opscode] added a comment - Wrong ticket, re-resolving.
Hide
Permalink
Bryan McLellan [Opscode] added a comment -

This patch has been merged to opscode/0.9-stable and will be included in the next release. Thank you for contributing to Chef!

Show
Bryan McLellan [Opscode] added a comment - This patch has been merged to opscode/0.9-stable and will be included in the next release. Thank you for contributing to Chef!
Hide
Permalink
Bryan McLellan [Opscode] added a comment -

Fixing FixVersion

Show
Bryan McLellan [Opscode] added a comment - Fixing FixVersion

People

  • Assignee:
    Daniel DeLeo
    Reporter:
    Chris Chalfant
Vote (2)
Watch (4)

Dates

  • Created:
    Updated:
    Resolved: