/etc/init.d/chef-solr on centos doesn't set pidfile correctly

Details

  • Type: Bug Bug
  • Status: Closed Closed
  • Priority: Major Major
  • Resolution: Fixed
  • Affects Version/s: 0.9.16, 0.10.0
  • Fix Version/s: 0.10.0
  • Component/s: Chef Server
  • Labels:
    None
  • Environment:

    centos 5.3, run_style=init, all redhat

Description

When using run_style=init, the init script for chef-solr (and I think the other daemons) does not use the -P option to start chef-solr. As a result, chef-solr defaults to using /tmp/chef-solr.pid instead of the pidfile specified in /etc/sysconfig/chef-solr or the default in /etc/init.d/chef-solr. Because of this service chef-solr stop/restart fails.

The fix is to add -P "$pidfile" in /etc/init.d/chef-solr in the start() function right before the "$options":

daemon $prog -d -c "$config" -u "$user" -g "$group" -L "$logfile" -P "$pidfile" "&>/dev/null"

Note too that you'll have to chown /var/run/chef to be owned by chef:chef.

Issue Links

is duplicated by

Bug - A problem which impairs or prevents the functions of the product. CHEF-1837 chef-solr init scripts

  • Minor - Minor loss of function, or other problem where easy workaround is present.
  • Closed - The issue is considered finished, the resolution is correct. Issues which are closed can be reopened.

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Chris Chalfant added a comment - - edited

Also need to add -p "$pidfile" to call to killproc in stop() function:

killproc -p "$pidfile" $prog

Show
Chris Chalfant added a comment - - edited Also need to add -p "$pidfile" to call to killproc in stop() function: killproc -p "$pidfile" $prog
Matthew Kent made changes -
Field Original Value New Value
Assignee Matthew Kent [ mkent ]
Hide
Permalink
Matthew Kent added a comment -

I'm nearly done 0.8.10 packages and part of those are new init scripts. I'll be submitting them for inclusion in Chef as well.

Show
Matthew Kent added a comment - I'm nearly done 0.8.10 packages and part of those are new init scripts. I'll be submitting them for inclusion in Chef as well.
Hide
Permalink
Matthew Kent added a comment -

Fixed in CHEF-1130

Show
Matthew Kent added a comment - Fixed in CHEF-1130
Matthew Kent made changes -
Status Open [ 1 ] Closed [ 6 ]
Resolution Duplicate [ 3 ]
Hide
Permalink
KC Braunschweig added a comment -

This seems to have been dropped back out of chef-solr several versions back and also wasn't setup properly when the chef-expander init script was written. The stop() function is correct, but start() doesn't specify the pidfile like it should.

Show
KC Braunschweig added a comment - This seems to have been dropped back out of chef-solr several versions back and also wasn't setup properly when the chef-expander init script was written. The stop() function is correct, but start() doesn't specify the pidfile like it should.
Hide
Permalink
KC Braunschweig added a comment -

Re-opening this as it was marked a duplicate of CHEF-1130 but that bug fixed several different issues. This is a regression of this specific issue only.

Show
KC Braunschweig added a comment - Re-opening this as it was marked a duplicate of CHEF-1130 but that bug fixed several different issues. This is a regression of this specific issue only.
KC Braunschweig made changes -
Resolution Duplicate [ 3 ]
Status Closed [ 6 ] Reopened [ 4 ]
KC Braunschweig made changes -
Affects Version/s 0.10.0 [ 10081 ]
Environment centos 5.3, run_style=init centos 5.3, run_style=init, all redhat
Matthew Kent made changes -
Affects Version/s 0.9.16 [ 10090 ]
Affects Version/s 0.8.8 [ 10054 ]
Hide
Permalink
Matthew Kent added a comment -

Apologies for not actually fixing this the first time.

Fixed in both 0.9.16 and master if you could pull from:

https://github.com/mdkent/chef/tree/CHEF-1074
https://github.com/mdkent/chef/tree/CHEF-1074-master

Show
Matthew Kent added a comment - Apologies for not actually fixing this the first time. Fixed in both 0.9.16 and master if you could pull from: https://github.com/mdkent/chef/tree/CHEF-1074 https://github.com/mdkent/chef/tree/CHEF-1074-master
Matthew Kent made changes -
Status Reopened [ 4 ] Resolved [ 5 ]
Assignee Matthew Kent [ mkent ] Daniel DeLeo [ dan@kallistec.com ]
Fix Version/s 0.9.18 [ 10201 ]
Fix Version/s 0.10.0 [ 10081 ]
Resolution Fixed [ 1 ]
Hide
Permalink
Daniel DeLeo added a comment -

Fix merged for 0.10. Leaving it open so we'll get to it for 0.9.18

Show
Daniel DeLeo added a comment - Fix merged for 0.10. Leaving it open so we'll get to it for 0.9.18
Bryan McLellan [Opscode] made changes -
Triage Status [Triaged]
Bryan McLellan [Opscode] made changes -
Resolution Fixed [ 1 ]
Status Resolved [ 5 ] Reopened [ 4 ]
Bryan McLellan [Opscode] made changes -
Comment [ We should have chef-solr-installer modify these settings so we're not maintaining local changes to upstream solr that we drop (which wouldn't work on Debian anyway). ]
Hide
Permalink
Bryan McLellan [Opscode] added a comment -

Wrong ticket, re-resolving.

Show
Bryan McLellan [Opscode] added a comment - Wrong ticket, re-resolving.
Bryan McLellan [Opscode] made changes -
Status Reopened [ 4 ] Resolved [ 5 ]
Resolution Fixed [ 1 ]
Hide
Permalink
Bryan McLellan [Opscode] added a comment -

This patch has been merged to opscode/0.9-stable and will be included in the next release. Thank you for contributing to Chef!

Show
Bryan McLellan [Opscode] added a comment - This patch has been merged to opscode/0.9-stable and will be included in the next release. Thank you for contributing to Chef!
Bryan McLellan [Opscode] made changes -
Status Resolved [ 5 ] Closed [ 6 ]
Hide
Permalink
Bryan McLellan [Opscode] added a comment -

Fixing FixVersion

Show
Bryan McLellan [Opscode] added a comment - Fixing FixVersion
Bryan McLellan [Opscode] made changes -
Resolution Fixed [ 1 ]
Status Closed [ 6 ] Reopened [ 4 ]
Fix Version/s 0.9.20 [ 10401 ]
Fix Version/s 0.9.18 [ 10201 ]
Bryan McLellan [Opscode] made changes -
Status Reopened [ 4 ] Closed [ 6 ]
Resolution Fixed [ 1 ]
Bryan McLellan [Opscode] made changes -
Link This issue is duplicated by CHEF-1837 [ CHEF-1837 ]
Daniel DeLeo made changes -
Fix Version/s 0.9.20 [ 10401 ]
Bryan McLellan [Opscode] made changes -
Workflow jira [ 11577 ] New OSS [ 19165 ]
Bryan McLellan [Opscode] made changes -
Workflow New OSS [ 19165 ] OSS: Product Management [ 27074 ]
Transition Time In Source Status Execution Times Last Executer Last Execution Date
Open Open Closed Closed
20d 14h 4m 1 Matthew Kent 19/Apr/10 4:03 AM
Resolved Resolved Reopened Reopened
11d 22h 41m 1 Bryan McLellan [Opscode] 03/May/11 5:20 PM
Reopened Reopened Resolved Resolved
1d 20h 41m 2 Bryan McLellan [Opscode] 03/May/11 5:20 PM
Resolved Resolved Closed Closed
148d 19h 17m 1 Bryan McLellan [Opscode] 29/Sep/11 12:38 PM
Closed Closed Reopened Reopened
365d 18h 28m 2 Bryan McLellan [Opscode] 29/Sep/11 1:12 PM
Reopened Reopened Closed Closed
5s 1 Bryan McLellan [Opscode] 29/Sep/11 1:12 PM

People

  • Assignee:
    Daniel DeLeo
    Reporter:
    Chris Chalfant
Vote (2)
Watch (4)

Dates

  • Created:
    Updated:
    Resolved: