Role error messages are non-helpful to track down which role caused the problem (when loading roles from filesystem)

Details

  • Type: Bug Bug
  • Status: Closed Closed
  • Priority: Major Major
  • Resolution: Fixed
  • Affects Version/s: 0.8.8
  • Fix Version/s: 0.8.10
  • Component/s: Chef Solo
  • Labels:
    None

Description

Rather than raising the exception, it was returning the exception. This caused a "no method error" exception to occur later on, which is very unhelpful.

The patch will describe it best:

http://github.com/timcharper/chef/commit/a726d87726b651f9a67940513232dffdbe94ed12

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Tim Harper added a comment -

Fixed with this patch:

http://github.com/timcharper/chef/commit/a726d87726b651f9a67940513232dffdbe94ed12

Merge pending

Show
Tim Harper added a comment - Fixed with this patch: http://github.com/timcharper/chef/commit/a726d87726b651f9a67940513232dffdbe94ed12 Merge pending
Hide
Permalink
Tim Harper added a comment -

Please merge

Show
Tim Harper added a comment - Please merge
Hide
Permalink
Tim Harper added a comment -

I just noticed that I had a stupid typo.

I have amended the commit and re-pushed. Please merge this patch instead:

http://github.com/timcharper/chef/commit/48af8ce5ffaa2bf35053a8a6657cb18c1ba2f1e0

Show
Tim Harper added a comment - I just noticed that I had a stupid typo. I have amended the commit and re-pushed. Please merge this patch instead: http://github.com/timcharper/chef/commit/48af8ce5ffaa2bf35053a8a6657cb18c1ba2f1e0
Hide
Permalink
Adam Jacob added a comment -

Thanks for the fix, Tim!

In the future, please create a branch named for the ticket you fixed, and push your changes there - for example, CHEF-1076. That things much easier during the merge pass (not that a git fetch; git cherry-pick is all that hard, but still.)

This is merged and pushed to opscode/master.

Show
Adam Jacob added a comment - Thanks for the fix, Tim! In the future, please create a branch named for the ticket you fixed, and push your changes there - for example, CHEF-1076 . That things much easier during the merge pass (not that a git fetch; git cherry-pick is all that hard, but still.) This is merged and pushed to opscode/master.

People

  • Assignee:
    Adam Jacob
    Reporter:
    Tim Harper
Vote (0)
Watch (1)

Dates

  • Created:
    Updated:
    Resolved: