Chef

backups of config files gets included in various programs

Details

  • Type: Bug Bug
  • Status: Closed Closed
  • Priority: Minor Minor
  • Resolution: Fixed
  • Affects Version/s: 0.8.6
  • Fix Version/s: 0.9.0
  • Component/s: Chef Client
  • Labels:
    None
  • Triage Status:
    Triaged

Description

backups of config file are named config.chef-201004011022 but programs using wildcard include dirs (E.G. apache /etc/apache2/conf.d) will load them.
backups files should probably start with dot (.) to avoid inclusion.

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Avishai Ish-Shalom added a comment - 04/Apr/10 2:57 AM

pull from git://github.com/avishai-ish-shalom/chef.git branch master

Show
Avishai Ish-Shalom added a comment - 04/Apr/10 2:57 AM pull from git://github.com/avishai-ish-shalom/chef.git branch master
Hide
Permalink
Daniel DeLeo added a comment - 30/Apr/10 9:58 PM

Hi Avishai, this is definitely a useful patch, but unfortunately it breaks our rspec test suite. Can you fix the test failures and resolve the ticket again? Feel free to stop by #chef-hacking on irc.freenode.net and ask if you need any help.

Thanks,

  • Dan DeLeo
Show
Daniel DeLeo added a comment - 30/Apr/10 9:58 PM Hi Avishai, this is definitely a useful patch, but unfortunately it breaks our rspec test suite. Can you fix the test failures and resolve the ticket again? Feel free to stop by #chef-hacking on irc.freenode.net and ask if you need any help. Thanks,
  • Dan DeLeo
Hide
Permalink
Daniel DeLeo added a comment - 01/May/10 12:01 AM

Actually, we already have a solution for this issue, just set file_backup_path in your chef config, and backups will go in the directory you specify.

That said, we are willing to change the default to something like /var/chef/backup in the 0.9 release of chef, if you would like to contribute a patch.

Show
Daniel DeLeo added a comment - 01/May/10 12:01 AM Actually, we already have a solution for this issue, just set file_backup_path in your chef config, and backups will go in the directory you specify. That said, we are willing to change the default to something like /var/chef/backup in the 0.9 release of chef, if you would like to contribute a patch.
Hide
Permalink
Avishai Ish-Shalom added a comment - 12/May/10 8:28 AM

http://github.com/avishai-ish-shalom/chef/commit/bb8effe36f9a100684c40a339ee869d1f27b6e9e

Chef::Config[:file_backup_path] now defaults to /var/chef/backup as suggested by Dan DeLeo

Show
Avishai Ish-Shalom added a comment - 12/May/10 8:28 AM http://github.com/avishai-ish-shalom/chef/commit/bb8effe36f9a100684c40a339ee869d1f27b6e9e Chef::Config[:file_backup_path] now defaults to /var/chef/backup as suggested by Dan DeLeo
Hide
Permalink
Daniel DeLeo added a comment - 02/Jun/10 12:20 AM

Thanks for the patch Avishai! I added the ability to get the old behavior back by setting :file_backup_path to nil.

  • Dan DeLeo
Show
Daniel DeLeo added a comment - 02/Jun/10 12:20 AM Thanks for the patch Avishai! I added the ability to get the old behavior back by setting :file_backup_path to nil.
  • Dan DeLeo

People

Vote (0)
Watch (0)

Dates

  • Created:
    03/Apr/10 11:46 AM
    Updated:
    02/Jun/10 12:20 AM
    Resolved:
    12/May/10 8:28 AM
Atlassian JIRA (v4.3#614-r144677) | Report a problem
Powered by a free Atlassian JIRA open source license for Chef and Ohai. Try JIRA - bug tracking software for your team.