Issue Details (XML | Word | Printable)

Key: CHEF-1293
Type: Bug Bug
Status: Closed Closed
Resolution: Fixed
Priority: Critical Critical
Assignee: Daniel DeLeo
Reporter: Adam Jacob
Votes: 0
Watchers: 0
Operations

If you were logged in you would be able to see more operations.
Chef

Knife cookbook delete should default to latest if a version is not specified

Created: 07/Jun/10 09:39 PM   Updated: 13/Jun/10 12:51 AM   Resolved: 13/Jun/10 12:51 AM
Component/s: None
Affects Version/s: None
Fix Version/s: 0.9.0

Triage Status: Triaged


 Description  « Hide

Currently, you fail:

[adam@latte](127)(master*)% knife cookbook delete opsmaster ~/src/sandbox/opscode/opsmaster
zsh: correct 'cookbook' to 'cookbooks' [nyae]? n
Do you really want to delete opsmaster ? (Y/N) y
WARN: HTTP Request Returned 404 Not Found: No routes match the request: /organizations/opsmaster/cookbooks/opsmaster/
/System/Library/Frameworks/Ruby.framework/Versions/1.8/usr/lib/ruby/1.8/net/http.rb:2097:in `error!': 404 "Not Found" (Net::HTTPServerException)
from /Library/Ruby/Gems/1.8/gems/chef-0.9.0.a8/lib/chef/rest.rb:216:in `api_request'
from /Library/Ruby/Gems/1.8/gems/chef-0.9.0.a8/lib/chef/rest.rb:267:in `retriable_rest_request'
from /Library/Ruby/Gems/1.8/gems/chef-0.9.0.a8/lib/chef/rest.rb:197:in `api_request'
from /Library/Ruby/Gems/1.8/gems/chef-0.9.0.a8/lib/chef/rest.rb:106:in `delete_rest'
from /Library/Ruby/Gems/1.8/gems/chef-0.9.0.a8/lib/chef/knife/cookbook_delete.rb:29:in `run'
from /Library/Ruby/Gems/1.8/gems/chef-0.9.0.a8/lib/chef/knife.rb:309:in `call'
from /Library/Ruby/Gems/1.8/gems/chef-0.9.0.a8/lib/chef/knife.rb:309:in `delete_object'
from /Library/Ruby/Gems/1.8/gems/chef-0.9.0.a8/lib/chef/knife/cookbook_delete.rb:28:in `run'
from /Library/Ruby/Gems/1.8/gems/chef-0.9.0.a8/lib/chef/application/knife.rb:115:in `run'
from /Library/Ruby/Gems/1.8/gems/chef-0.9.0.a8/bin/knife:25
from /usr/local/bin/knife:19:in `load'
from /usr/local/bin/knife:19

Would be better to pick a version and delete that.



Sort Order: Ascending order - Click to sort in descending order
Daniel DeLeo added a comment - 13/Jun/10 12:51 AM

Done. Now the behavior is like this:

  • behavior when a version is specified is unchanged
    when a version is not specified:
  1. if there is only one version, delete that. It shows you the version in the confirmation prompt.
  2. if -a is given on the command line, delete all versions
  3. if there are multiple versions, it pops up a selection, you can pick one or more or all versions to delete.

I added knife recipe list as a bonus


Daniel DeLeo added a comment - 13/Jun/10 12:51 AM

pushed.