knife cookbook site vendor fails to extract due to incorrect cwd

Details

  • Type: Bug Bug
  • Status: Closed Closed
  • Priority: Major Major
  • Resolution: Fixed
  • Affects Version/s: 0.8.16
  • Fix Version/s: 0.9.0
  • Component/s: Knife
  • Labels:
    None

Description

$ knife cookbook site vendor zsh
INFO: Downloading zsh from the cookbooks site at version 0.7.0
INFO: Cookbook saved: ./cookbooks/zsh.tar.gz
INFO: Checking out the master branch.
INFO: Checking the status of the vendor branch.
INFO: Creating vendor branch.
INFO: Removing pre-existing version.
INFO: Uncompressing zsh version 0.7.0.
/usr/lib/ruby/gems/1.8/gems/chef-0.8.16/lib/chef/mixin/command.rb:181:in `handle_command_failures': tar zxvf ./cookbooks/zsh.tar.gz returned 2, expected 0 (Chef::Exceptions::Exec)
	from /usr/lib/ruby/gems/1.8/gems/chef-0.8.16/lib/chef/mixin/command.rb:124:in `run_command'
	from /usr/lib/ruby/gems/1.8/gems/chef-0.8.16/lib/chef/knife/cookbook_site_vendor.rb:59:in `run'
	from /usr/lib/ruby/gems/1.8/gems/chef-0.8.16/lib/chef/application/knife.rb:116:in `run'
	from /usr/lib/ruby/gems/1.8/gems/chef-0.8.16/bin/knife:25
	from /usr/bin/knife:19:in `load'
	from /usr/bin/knife:19

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
jtimberman added a comment -

Fixed in jtimberman/CHEF-1306:

$ knife cookbook site vendor zsh
INFO: Downloading zsh from the cookbooks site at version 0.7.0
INFO: Cookbook saved: zsh.tar.gz
INFO: Checking out the master branch.
INFO: Checking the status of the vendor branch.
INFO: Vendor branch found.
INFO: Removing pre-existing version.
INFO: Uncompressing zsh version 0.7.0.
INFO: Adding changes.
INFO: Committing changes.
INFO: Creating tag chef-vendor-zsh-0.7.0.
INFO: Checking out the master branch.
INFO: Merging changes from zsh version 0.7.0.
Updating d07aee0..d0c0553
Fast-forward
 cookbooks/zsh/metadata.json      |   43 ++++++++++++++++++++++++++++++++++++++
 cookbooks/zsh/metadata.rb        |    9 ++++++++
 cookbooks/zsh/recipes/default.rb |   29 +++++++++++++++++++++++++
 3 files changed, 81 insertions(+), 0 deletions(-)
 create mode 100644 cookbooks/zsh/metadata.json
 create mode 100644 cookbooks/zsh/metadata.rb
 create mode 100644 cookbooks/zsh/recipes/default.rb
INFO: Cookbook zsh version 0.7.0 successfully vendored!
Show
jtimberman added a comment - Fixed in jtimberman/ CHEF-1306 : $ knife cookbook site vendor zsh INFO: Downloading zsh from the cookbooks site at version 0.7.0 INFO: Cookbook saved: zsh.tar.gz INFO: Checking out the master branch. INFO: Checking the status of the vendor branch. INFO: Vendor branch found. INFO: Removing pre-existing version. INFO: Uncompressing zsh version 0.7.0. INFO: Adding changes. INFO: Committing changes. INFO: Creating tag chef-vendor-zsh-0.7.0. INFO: Checking out the master branch. INFO: Merging changes from zsh version 0.7.0. Updating d07aee0..d0c0553 Fast-forward cookbooks/zsh/metadata.json | 43 ++++++++++++++++++++++++++++++++++++++ cookbooks/zsh/metadata.rb | 9 ++++++++ cookbooks/zsh/recipes/ default .rb | 29 +++++++++++++++++++++++++ 3 files changed, 81 insertions(+), 0 deletions(-) create mode 100644 cookbooks/zsh/metadata.json create mode 100644 cookbooks/zsh/metadata.rb create mode 100644 cookbooks/zsh/recipes/ default .rb INFO: Cookbook zsh version 0.7.0 successfully vendored!
Hide
Permalink
jtimberman added a comment -

http://github.com/jtimberman/chef/tree/CHEF-1306

Show
jtimberman added a comment - http://github.com/jtimberman/chef/tree/CHEF-1306
Hide
Permalink
Daniel DeLeo added a comment -

After talking to Adam, we agreed that warning and falling back to using the current working dir would be good behavior when cookbook_path isn't configured in knife.rb, so I added that to this patch.

Joshua, your contribution to Chef is greatly appreciated, your patch is merged. May the Chef be with you.

Show
Daniel DeLeo added a comment - After talking to Adam, we agreed that warning and falling back to using the current working dir would be good behavior when cookbook_path isn't configured in knife.rb, so I added that to this patch. Joshua, your contribution to Chef is greatly appreciated, your patch is merged. May the Chef be with you.

People

  • Assignee:
    Daniel DeLeo
    Reporter:
    jtimberman
Vote (0)
Watch (0)

Dates

  • Created:
    Updated:
    Resolved: