
| Key: |
CHEF-1341
|
| Type: |
Bug
|
| Status: |
Closed
|
| Resolution: |
Fixed
|
| Priority: |
Blocker
|
| Assignee: |
Unassigned
|
| Reporter: |
Daniel DeLeo
|
| Votes: |
0
|
| Watchers: |
0
|
|
If you were logged in you would be able to see more operations.
|
|
|
The handler API requires users to implement a method with six arguments to receive run status data. This is bad because it is inflexible, we could never add new data to the handler without forcing everyone to rewrite all of their existing ones (otherwise they'd get errors like, "wrong number of arguments 7 for 6"). This also forces complexity on the user, when it can be elegantly dealt with internally in chef instead. Also, the JSON File handler uses methods that don't exist, so it doesn't work, and some implementation that is specific to the JSON file handler is in the base handler class.
If we fix all of these right now, we can have an extensible API that will be more amenable to adding features at a later time without causing the trauma of forcing people to rewrite a bunch of code.
|
|
Description
|
The handler API requires users to implement a method with six arguments to receive run status data. This is bad because it is inflexible, we could never add new data to the handler without forcing everyone to rewrite all of their existing ones (otherwise they'd get errors like, "wrong number of arguments 7 for 6"). This also forces complexity on the user, when it can be elegantly dealt with internally in chef instead. Also, the JSON File handler uses methods that don't exist, so it doesn't work, and some implementation that is specific to the JSON file handler is in the base handler class.
If we fix all of these right now, we can have an extensible API that will be more amenable to adding features at a later time without causing the trauma of forcing people to rewrite a bunch of code. |
Show » |
Sort Order:
|
fixed, merged.
http://github.com/opscode/chef/commit/502711544eaf0a1924d5f6cdb3c89826875e766f