[#CHEF-1363] ChefServerApi::SandboxFile assumes input is a StringIO - Opscode Open Source Ticket Tracking

Chef

ChefServerApi::SandboxFile assumes input is a StringIO

Created: 21/Jun/10 05:04 PM Updated: 21/Jun/10 09:42 PM Resolved: 21/Jun/10 09:41 PM

Component/s:

Chef Server

Affects Version/s:

0.9.0

Fix Version/s:

0.9.2

Triage Status:

Triaged

Description

« Hide

but we can't rely on rack.input to support the #string method b/c the rack spec doesn't require it. use #read instead.

Sort Order:

[ Permalink | « Hide ]

Daniel DeLeo added a comment - 21/Jun/10 05:21 PM

fixed as described

[ Permalink | « Hide ]

Daniel DeLeo added a comment - 21/Jun/10 05:24 PM

merged/pushed. http://github.com/opscode/chef/commit/2faca4c148f3745feecd8b57b63ad4b91dd05b13

[ Permalink | « Hide ]

Daniel DeLeo added a comment - 21/Jun/10 08:04 PM

need to rewind the input, jerkface

[ Permalink | « Hide ]

Daniel DeLeo added a comment - 21/Jun/10 09:41 PM

Updated the patch to rewind the input before writing the file, and to read in 8k chunks. this is required because unicorn extra-wraps the input so we can't easily detect if it's a stringio or temporary file, therefore an input that doesn't look like a tempfile might actually be one (and contain an arbitrarily large amount of data). Confirmed with corp on IRC that this updated patch solves the problem.

[ Permalink | « Hide ]

Daniel DeLeo added a comment - 21/Jun/10 09:42 PM

updated fix is merged.