extlib gem dependancy provides bugs in rails application

Details

  • Type: Bug Bug
  • Status: Closed Closed
  • Priority: Major Major
  • Resolution: Fixed
  • Affects Version/s: None
  • Fix Version/s: 0.10.0
  • Component/s: None
  • Labels:
    None

Description

One of chef dependency - extlib gem provides lot of bugs in rails.
We're using chef in runtime rails application - extlib is hacking a lot of code that is defined in activesupport.
So maybe extlib gem could be replaced by activesupport which should support all needed extensions or any other solution can be found?

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Daniel DeLeo added a comment -

I don't think using activesupport is an option, it monkey patches too many core classes and causes a lot of problems, and doesn't provide the functionality we actually use from extlib. I do think it should be possible to extract the bit of functionality we do need from extlib, namely the Mash class, without using the rest of it.

Show
Daniel DeLeo added a comment - I don't think using activesupport is an option, it monkey patches too many core classes and causes a lot of problems, and doesn't provide the functionality we actually use from extlib. I do think it should be possible to extract the bit of functionality we do need from extlib, namely the Mash class, without using the rest of it.
Hide
Permalink
Wojciech Wnętrzak added a comment -

That would be great. There is for example http://github.com/intridea/hashie
I didn't found solution for this problem (there is to many require 'extlib' in chef code) to simply load only those features that I need (without doing require 'chef').

Show
Wojciech Wnętrzak added a comment - That would be great. There is for example http://github.com/intridea/hashie I didn't found solution for this problem (there is to many require 'extlib' in chef code) to simply load only those features that I need (without doing require 'chef').
Hide
Permalink
Chris Williams added a comment -

Ran into the same problem myself. Causes lots of weird issues in Rails. Would love to be able to use the Chef API in our rails app.

Show
Chris Williams added a comment - Ran into the same problem myself. Causes lots of weird issues in Rails. Would love to be able to use the Chef API in our rails app.
Hide
Permalink
Chris Williams added a comment -

I was able to get rid of extlib by following the advice above. I copied the mash.rb source from extlib into the chef source. I also had to add the to_mash method from extlib's hash.rb as well. Then everywhere in the code there was require 'extlib', I replaced it with requiring the new mash code and that seems to work well. It's possible I missed some more extlib references but I haven't run into any issues and now I can make Chef queries from my rails app without weird bugs.

Show
Chris Williams added a comment - I was able to get rid of extlib by following the advice above. I copied the mash.rb source from extlib into the chef source. I also had to add the to_mash method from extlib's hash.rb as well. Then everywhere in the code there was require 'extlib', I replaced it with requiring the new mash code and that seems to work well. It's possible I missed some more extlib references but I haven't run into any issues and now I can make Chef queries from my rails app without weird bugs.
Hide
Permalink
Wojciech Wnętrzak added a comment -

That's cool. It would be very nice, to throw away extlib gem.
Did you try hashie gem?
I'm not sure, but it should have mash properties.

Show
Wojciech Wnętrzak added a comment - That's cool. It would be very nice, to throw away extlib gem. Did you try hashie gem? I'm not sure, but it should have mash properties.
Hide
Permalink
Aaron Suggs added a comment - - edited

+1 for removing the extlib dependency. This bug bit me as I'm trying to include the chef/rest_client in a Rails 3 app.

I followed Chris Williams' advice and published the results:

https://github.com/ktheory/chef/tree/no_extlib
https://github.com/ktheory/ohai/tree/no_extlib

The "no_extlib" branch is based on Chef 0.9.12

You can use the version of chef & ohai without extlib by including the following in your Gemfile:

gem 'ohai', :git => 'git://github.com/ktheory/ohai.git', :branch => 'no_extlib'
gem 'chef', :git => 'git://github.com/ktheory/chef.git', :branch => 'no_extlib'

It works for me.

Show
Aaron Suggs added a comment - - edited +1 for removing the extlib dependency. This bug bit me as I'm trying to include the chef/rest_client in a Rails 3 app. I followed Chris Williams' advice and published the results: https://github.com/ktheory/chef/tree/no_extlib https://github.com/ktheory/ohai/tree/no_extlib The "no_extlib" branch is based on Chef 0.9.12 You can use the version of chef & ohai without extlib by including the following in your Gemfile: gem 'ohai', :git => 'git://github.com/ktheory/ohai.git', :branch => 'no_extlib' gem 'chef', :git => 'git://github.com/ktheory/chef.git', :branch => 'no_extlib' It works for me.
Hide
Permalink
Wojciech Wnętrzak added a comment - - edited

If all tests are passing, that should be definitely merged into chef and ohai master.
Extlib gem is hacking too much.

If this is not possible somehow, consider this option:
If extlib is used only for mash, do not require entire extlib gem library, do it only with extlib/mash - this can avoid problems.

Show
Wojciech Wnętrzak added a comment - - edited If all tests are passing, that should be definitely merged into chef and ohai master. Extlib gem is hacking too much. If this is not possible somehow, consider this option: If extlib is used only for mash, do not require entire extlib gem library, do it only with extlib/mash - this can avoid problems.
Hide
Permalink
Seth Falcon added a comment -

Merged to master in 7b24a6428f3a0439d4aa1eb426e5b8a8913bf95e and pushed. Scheduled for 0.10.0

Show
Seth Falcon added a comment - Merged to master in 7b24a6428f3a0439d4aa1eb426e5b8a8913bf95e and pushed. Scheduled for 0.10.0
Hide
Permalink
Bryan McLellan [Chef] added a comment -

the next version of ohai also drops extlib in commit c7881cf40278caa1e5a20c9215e540cacc5414e1

Show
Bryan McLellan [Chef] added a comment - the next version of ohai also drops extlib in commit c7881cf40278caa1e5a20c9215e540cacc5414e1

People

  • Assignee:
    Unassigned
    Reporter:
    Wojciech Wnętrzak
Vote (1)
Watch (0)

Dates

  • Created:
    Updated:
    Resolved: