should be able to force include_recipe - workaround available

Details

  • Type: Improvement Improvement
  • Status: Open Open
  • Priority: Minor Minor
  • Resolution: Unresolved
  • Affects Version/s: 0.9.4
  • Fix Version/s: None
  • Component/s: Chef Client
  • Labels:
    None

Description

Recipes are only loaded once even when they depend (and will be different) based on data bag items. Loading them again (e.g. in a loop over data bag items) will produce debug messages like "I am not loading #{recipe_name}, because I have already seen it."

The cookbooks/application/recipes/default.rb code only works for one app in the apps databag:

search(:apps) do |app|
(app["server_roles"] & node.run_list.roles).each do |app_role|
app["type"][app_role].each do |thing|
node.run_state[:current_app] = app
include_recipe "application::#{thing}"
end
end
end

node.run_state.delete(:current_app
—

The 'application::#{thing}' recipes are included only once even though they will be different based on different values in the 'app' data bag item. To force including the recipe you need to do something like this:

node.run_state[:seen_recipes].delete("application::#{thing}")
include_recipe "application::#{thing}"

I consider this a workaround. It would be nicer to specify force loading recipes, e.g. like this:

include_recipe "application::#{thing}", :force => true

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Philippe Creux added a comment -

+1

Thanks for the workaround!

Show
Philippe Creux added a comment - +1 Thanks for the workaround!
Hide
Permalink
Tyler Rick added a comment - - edited

+1. Would be nice to get this fixed

Sometimes you really do want to include a recipe even if it has been "seen" already.

Here's a little helper method I made to make this easier:

def force_include_recipe(recipe_name)
node.run_state[:seen_recipes].delete(recipe_name)
include_recipe recipe_name
end

Show
Tyler Rick added a comment - - edited +1. Would be nice to get this fixed Sometimes you really do want to include a recipe even if it has been "seen" already. Here's a little helper method I made to make this easier: def force_include_recipe(recipe_name) node.run_state [:seen_recipes] .delete(recipe_name) include_recipe recipe_name end
Hide
Permalink
Bryan McLellan [Opscode] added a comment -

Additional use cases would be helpful.

Show
Bryan McLellan [Opscode] added a comment - Additional use cases would be helpful.
Hide
Permalink
Chris Burroughs added a comment -

I'm having trouble applying this work around with the changes in Chef 11: http://docs.opscode.com/breaking_changes_chef_11.html#node-run-state-replaced

Current use case:

  • cookbook that 'sets a bunch of defaults and keys for each user'
  • base role: creates some user and then includes the that cookbook
  • role for some app: creates another user and includes that cookbook, adds some more attributes (ie for the user just created)
  • Result: "another user" does not have the changes from the cookbook, because the cookbook was already in the run list before the user was created. Need to run chef-client twice.
Show
Chris Burroughs added a comment - I'm having trouble applying this work around with the changes in Chef 11: http://docs.opscode.com/breaking_changes_chef_11.html#node-run-state-replaced Current use case: cookbook that 'sets a bunch of defaults and keys for each user' base role: creates some user and then includes the that cookbook role for some app: creates another user and includes that cookbook, adds some more attributes (ie for the user just created) Result: "another user" does not have the changes from the cookbook, because the cookbook was already in the run list before the user was created. Need to run chef-client twice.
Hide
Permalink
Chris Burroughs added a comment -

For anyone else trying the same thing, neither run_context.loaded_recipes.delete('foo::default') nor run_context.instance_variable_get(:@loaded_recipes).delete('foo:default') appears to work with chef11

Show
Chris Burroughs added a comment - For anyone else trying the same thing, neither run_context.loaded_recipes.delete('foo::default') nor run_context.instance_variable_get(:@loaded_recipes).delete('foo:default') appears to work with chef11

People

  • Assignee:
    Unassigned
    Reporter:
    Klaas Jan Wierenga
Vote (4)
Watch (4)

Dates

  • Created:
    Updated: