FreeBSD "Unexpected form for PKGNAME variable in ..."

Details

  • Type: Bug Bug
  • Status: Closed Closed
  • Priority: Major Major
  • Resolution: Fixed
  • Affects Version/s: 0.9.4
  • Fix Version/s: 0.10.4
  • Component/s: Chef Client
  • Labels:
    None
  • Environment:

    FreeBSD 8.0-RELEASE-p3

Description

When I perform the cookbook which contains 'package' resource, I get exception "Unexpected form for PKGNAME variable in ..."

FreeBSD make needs '-f /path/to/Makefile' argument and not needs 'cwd => port_path' in chef-0.9.4/lib/chef/provider/package/freebsd.rb
because 'cwd' isn't performed correctly
def ports_makefile_variable_value(variable)

  • make_v = shell_out!("make -V #{variable}", :cwd => port_path, :env => nil, :returns => [0,1])
    + make_v = shell_out!("make -V #{variable} -f #{port_path}/Makefile", :env => nil, :returns => [0,1])
    make_v.stdout.strip.split($).first # $\ is the line separator, i.e., newline
    end

I think that to make better use PACKAGEROOT instead of PACKEAGESITE

  • shell_out!("pkg_add -r #{package_name}", :env => { "PACKAGESITE" => @new_resource.source, 'LC_ALL' => nil }).status
    + shell_out!("pkg_add -r #{package_name}", :env => { "PACKAGEROOT" => @new_resource.source, 'LC_ALL' => nil }).status

Issue Links

duplicates

Bug - A problem which impairs or prevents the functions of the product. CHEF-2634 FreeBSD packages: fail to build when using ports - incorrect use of port Makefile and working dir?

  • Critical - Crashes, loss of data, severe memory leak.
  • Closed - The issue is considered finished, the resolution is correct. Issues which are closed can be reopened.

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Greg Albrecht added a comment -

Also happening in:
Chef: 0.9.8
FreeBSD sfeserv34.splunk.com 6.3-RELEASE FreeBSD 6.3-RELEASE #0: Wed Jan 16 04:45:45 UTC 2008 root@dessler.cse.buffalo.edu:/usr/obj/usr/src/sys/SMP i386

[Wed, 15 Sep 2010 14:31:00 -0700] INFO: Starting Chef Run (Version 0.9.8)
[Wed, 15 Sep 2010 14:31:02 -0700] ERROR: package[sudo] (/var/chef/cache/cookbooks/sudo/recipes/default.rb:20:in `from_file') had an error:
Unexpected form for PKGNAME variable in /usr/ports/security/sudo/Makefile
/usr/local/lib/ruby/gems/1.8/gems/chef-0.9.8/bin/../lib/chef/provider/package/freebsd.rb:89:in `package_name'
/usr/local/lib/ruby/gems/1.8/gems/chef-0.9.8/bin/../lib/chef/provider/package/freebsd.rb:36:in `current_installed_version'
/usr/local/lib/ruby/gems/1.8/gems/chef-0.9.8/bin/../lib/chef/provider/package/freebsd.rb:71:in `load_current_resource'
/usr/local/lib/ruby/gems/1.8/gems/chef-0.9.8/bin/../lib/chef/runner.rb:43:in `build_provider'
/usr/local/lib/ruby/gems/1.8/gems/chef-0.9.8/bin/../lib/chef/runner.rb:50:in `run_action'
/usr/local/lib/ruby/gems/1.8/gems/chef-0.9.8/bin/../lib/chef/runner.rb:109:in `converge'
/usr/local/lib/ruby/gems/1.8/gems/chef-0.9.8/bin/../lib/chef/runner.rb:108:in `each'
/usr/local/lib/ruby/gems/1.8/gems/chef-0.9.8/bin/../lib/chef/runner.rb:108:in `converge'
/usr/local/lib/ruby/gems/1.8/gems/chef-0.9.8/bin/../lib/chef/resource_collection.rb:94:in `execute_each_resource'
/usr/local/lib/ruby/gems/1.8/gems/chef-0.9.8/bin/../lib/chef/resource_collection/stepable_iterator.rb:116:in `call'
/usr/local/lib/ruby/gems/1.8/gems/chef-0.9.8/bin/../lib/chef/resource_collection/stepable_iterator.rb:116:in `call_iterator_block'
/usr/local/lib/ruby/gems/1.8/gems/chef-0.9.8/bin/../lib/chef/resource_collection/stepable_iterator.rb:85:in `step'
/usr/local/lib/ruby/gems/1.8/gems/chef-0.9.8/bin/../lib/chef/resource_collection/stepable_iterator.rb:104:in `iterate'
/usr/local/lib/ruby/gems/1.8/gems/chef-0.9.8/bin/../lib/chef/resource_collection/stepable_iterator.rb:55:in `each_with_index'
/usr/local/lib/ruby/gems/1.8/gems/chef-0.9.8/bin/../lib/chef/resource_collection.rb:92:in `execute_each_resource'
/usr/local/lib/ruby/gems/1.8/gems/chef-0.9.8/bin/../lib/chef/runner.rb:82:in `converge'
/usr/local/lib/ruby/gems/1.8/gems/chef-0.9.8/bin/../lib/chef/client.rb:304:in `converge'
/usr/local/lib/ruby/gems/1.8/gems/chef-0.9.8/bin/../lib/chef/client.rb:106:in `run'
/usr/local/lib/ruby/gems/1.8/gems/chef-0.9.8/bin/../lib/chef/application/client.rb:212:in `run_application'
/usr/local/lib/ruby/gems/1.8/gems/chef-0.9.8/bin/../lib/chef/application/client.rb:202:in `loop'
/usr/local/lib/ruby/gems/1.8/gems/chef-0.9.8/bin/../lib/chef/application/client.rb:202:in `run_application'
/usr/local/lib/ruby/gems/1.8/gems/chef-0.9.8/bin/../lib/chef/application.rb:62:in `run'
/usr/local/lib/ruby/gems/1.8/gems/chef-0.9.8/bin/chef-client:26
/usr/local/bin/chef-client:19:in `load'
/usr/local/bin/chef-client:19
[Wed, 15 Sep 2010 14:31:02 -0700] ERROR: Running exception handlers
[Wed, 15 Sep 2010 14:31:02 -0700] ERROR: Exception handlers complete
[Wed, 15 Sep 2010 14:31:02 -0700] ERROR: Re-raising exception: Chef::Exceptions::Package - Unexpected form for PKGNAME variable in /usr/ports/security/sudo/Makefile
/usr/local/lib/ruby/gems/1.8/gems/chef-0.9.8/bin/../lib/chef/provider/package/freebsd.rb:89:in `package_name'
/usr/local/lib/ruby/gems/1.8/gems/chef-0.9.8/bin/../lib/chef/provider/package/freebsd.rb:36:in `current_installed_version'
/usr/local/lib/ruby/gems/1.8/gems/chef-0.9.8/bin/../lib/chef/provider/package/freebsd.rb:71:in `load_current_resource'
/usr/local/lib/ruby/gems/1.8/gems/chef-0.9.8/bin/../lib/chef/runner.rb:43:in `build_provider'
/usr/local/lib/ruby/gems/1.8/gems/chef-0.9.8/bin/../lib/chef/runner.rb:50:in `run_action'
/usr/local/lib/ruby/gems/1.8/gems/chef-0.9.8/bin/../lib/chef/runner.rb:109:in `converge'
/usr/local/lib/ruby/gems/1.8/gems/chef-0.9.8/bin/../lib/chef/runner.rb:108:in `each'
/usr/local/lib/ruby/gems/1.8/gems/chef-0.9.8/bin/../lib/chef/runner.rb:108:in `converge'
/usr/local/lib/ruby/gems/1.8/gems/chef-0.9.8/bin/../lib/chef/resource_collection.rb:94:in `execute_each_resource'
/usr/local/lib/ruby/gems/1.8/gems/chef-0.9.8/bin/../lib/chef/resource_collection/stepable_iterator.rb:116:in `call'
/usr/local/lib/ruby/gems/1.8/gems/chef-0.9.8/bin/../lib/chef/resource_collection/stepable_iterator.rb:/usr/local/lib/ruby/gems/1.8/gems/chef-0.9.8/bin/../lib/chef/provider/package/freebsd.rb:89:in `package_name': Unexpected form for PKGNAME variable in /usr/ports/security/sudo/Makefile (Chef::Exceptions::Package)
from /usr/local/lib/ruby/gems/1.8/gems/chef-0.9.8/bin/../lib/chef/provider/package/freebsd.rb:36:in `current_installed_version'
from /usr/local/lib/ruby/gems/1.8/gems/chef-0.9.8/bin/../lib/chef/provider/package/freebsd.rb:71:in `load_current_resource'
from /usr/local/lib/ruby/gems/1.8/gems/chef-0.9.8/bin/../lib/chef/runner.rb:43:in `build_provider'
from /usr/local/lib/ruby/gems/1.8/gems/chef-0.9.8/bin/../lib/chef/runner.rb:50:in `run_action'
from /usr/local/lib/ruby/gems/1.8/gems/chef-0.9.8/bin/../lib/chef/runner.rb:109:in `converge'
from /usr/local/lib/ruby/gems/1.8/gems/chef-0.9.8/bin/../lib/chef/runner.rb:108:in `each'
from /usr/local/lib/ruby/gems/1.8/gems/chef-0.9.8/bin/../lib/chef/runner.rb:108:in `converge'
from /usr/local/lib/ruby/gems/1.8/gems/chef-0.9.8/bin/../lib/chef/resource_collection.rb:94:in `execute_each_resource'
... 12 levels...
from /usr/local/lib/ruby/gems/1.8/gems/chef-0.9.8/bin/../lib/chef/application.rb:62:in `run'
from /usr/local/lib/ruby/gems/1.8/gems/chef-0.9.8/bin/chef-client:26
from /usr/local/bin/chef-client:19:in `load'
from /usr/local/bin/chef-client:19
116:in `call_iterator_block'
/usr/local/lib/ruby/gems/1.8/gems/chef-0.9.8/bin/../lib/chef/resource_collection/stepable_iterator.rb:85:in `step'
/usr/local/lib/ruby/gems/1.8/gems/chef-0.9.8/bin/../lib/chef/resource_collection/stepable_iterator.rb:104:in `iterate'
/usr/local/lib/ruby/gems/1.8/gems/chef-0.9.8/bin/../lib/chef/resource_collection/stepable_iterator.rb:55:in `each_with_index'
/usr/local/lib/ruby/gems/1.8/gems/chef-0.9.8/bin/../lib/chef/resource_collection.rb:92:in `execute_each_resource'
/usr/local/lib/ruby/gems/1.8/gems/chef-0.9.8/bin/../lib/chef/runner.rb:82:in `converge'
/usr/local/lib/ruby/gems/1.8/gems/chef-0.9.8/bin/../lib/chef/client.rb:304:in `converge'
/usr/local/lib/ruby/gems/1.8/gems/chef-0.9.8/bin/../lib/chef/client.rb:106:in `run'
/usr/local/lib/ruby/gems/1.8/gems/chef-0.9.8/bin/../lib/chef/application/client.rb:212:in `run_application'
/usr/local/lib/ruby/gems/1.8/gems/chef-0.9.8/bin/../lib/chef/application/client.rb:202:in `loop'
/usr/local/lib/ruby/gems/1.8/gems/chef-0.9.8/bin/../lib/chef/application/client.rb:202:in `run_application'
/usr/local/lib/ruby/gems/1.8/gems/chef-0.9.8/bin/../lib/chef/application.rb:62:in `run'
/usr/local/lib/ruby/gems/1.8/gems/chef-0.9.8/bin/chef-client:26
/usr/local/bin/chef-client:19:in `load'
/usr/local/bin/chef-client:19

Show
Greg Albrecht added a comment - Also happening in: Chef: 0.9.8 FreeBSD sfeserv34.splunk.com 6.3-RELEASE FreeBSD 6.3-RELEASE #0: Wed Jan 16 04:45:45 UTC 2008 root@dessler.cse.buffalo.edu:/usr/obj/usr/src/sys/SMP i386 [Wed, 15 Sep 2010 14:31:00 -0700] INFO: Starting Chef Run (Version 0.9.8) [Wed, 15 Sep 2010 14:31:02 -0700] ERROR: package [sudo] (/var/chef/cache/cookbooks/sudo/recipes/default.rb:20:in `from_file') had an error: Unexpected form for PKGNAME variable in /usr/ports/security/sudo/Makefile /usr/local/lib/ruby/gems/1.8/gems/chef-0.9.8/bin/../lib/chef/provider/package/freebsd.rb:89:in `package_name' /usr/local/lib/ruby/gems/1.8/gems/chef-0.9.8/bin/../lib/chef/provider/package/freebsd.rb:36:in `current_installed_version' /usr/local/lib/ruby/gems/1.8/gems/chef-0.9.8/bin/../lib/chef/provider/package/freebsd.rb:71:in `load_current_resource' /usr/local/lib/ruby/gems/1.8/gems/chef-0.9.8/bin/../lib/chef/runner.rb:43:in `build_provider' /usr/local/lib/ruby/gems/1.8/gems/chef-0.9.8/bin/../lib/chef/runner.rb:50:in `run_action' /usr/local/lib/ruby/gems/1.8/gems/chef-0.9.8/bin/../lib/chef/runner.rb:109:in `converge' /usr/local/lib/ruby/gems/1.8/gems/chef-0.9.8/bin/../lib/chef/runner.rb:108:in `each' /usr/local/lib/ruby/gems/1.8/gems/chef-0.9.8/bin/../lib/chef/runner.rb:108:in `converge' /usr/local/lib/ruby/gems/1.8/gems/chef-0.9.8/bin/../lib/chef/resource_collection.rb:94:in `execute_each_resource' /usr/local/lib/ruby/gems/1.8/gems/chef-0.9.8/bin/../lib/chef/resource_collection/stepable_iterator.rb:116:in `call' /usr/local/lib/ruby/gems/1.8/gems/chef-0.9.8/bin/../lib/chef/resource_collection/stepable_iterator.rb:116:in `call_iterator_block' /usr/local/lib/ruby/gems/1.8/gems/chef-0.9.8/bin/../lib/chef/resource_collection/stepable_iterator.rb:85:in `step' /usr/local/lib/ruby/gems/1.8/gems/chef-0.9.8/bin/../lib/chef/resource_collection/stepable_iterator.rb:104:in `iterate' /usr/local/lib/ruby/gems/1.8/gems/chef-0.9.8/bin/../lib/chef/resource_collection/stepable_iterator.rb:55:in `each_with_index' /usr/local/lib/ruby/gems/1.8/gems/chef-0.9.8/bin/../lib/chef/resource_collection.rb:92:in `execute_each_resource' /usr/local/lib/ruby/gems/1.8/gems/chef-0.9.8/bin/../lib/chef/runner.rb:82:in `converge' /usr/local/lib/ruby/gems/1.8/gems/chef-0.9.8/bin/../lib/chef/client.rb:304:in `converge' /usr/local/lib/ruby/gems/1.8/gems/chef-0.9.8/bin/../lib/chef/client.rb:106:in `run' /usr/local/lib/ruby/gems/1.8/gems/chef-0.9.8/bin/../lib/chef/application/client.rb:212:in `run_application' /usr/local/lib/ruby/gems/1.8/gems/chef-0.9.8/bin/../lib/chef/application/client.rb:202:in `loop' /usr/local/lib/ruby/gems/1.8/gems/chef-0.9.8/bin/../lib/chef/application/client.rb:202:in `run_application' /usr/local/lib/ruby/gems/1.8/gems/chef-0.9.8/bin/../lib/chef/application.rb:62:in `run' /usr/local/lib/ruby/gems/1.8/gems/chef-0.9.8/bin/chef-client:26 /usr/local/bin/chef-client:19:in `load' /usr/local/bin/chef-client:19 [Wed, 15 Sep 2010 14:31:02 -0700] ERROR: Running exception handlers [Wed, 15 Sep 2010 14:31:02 -0700] ERROR: Exception handlers complete [Wed, 15 Sep 2010 14:31:02 -0700] ERROR: Re-raising exception: Chef::Exceptions::Package - Unexpected form for PKGNAME variable in /usr/ports/security/sudo/Makefile /usr/local/lib/ruby/gems/1.8/gems/chef-0.9.8/bin/../lib/chef/provider/package/freebsd.rb:89:in `package_name' /usr/local/lib/ruby/gems/1.8/gems/chef-0.9.8/bin/../lib/chef/provider/package/freebsd.rb:36:in `current_installed_version' /usr/local/lib/ruby/gems/1.8/gems/chef-0.9.8/bin/../lib/chef/provider/package/freebsd.rb:71:in `load_current_resource' /usr/local/lib/ruby/gems/1.8/gems/chef-0.9.8/bin/../lib/chef/runner.rb:43:in `build_provider' /usr/local/lib/ruby/gems/1.8/gems/chef-0.9.8/bin/../lib/chef/runner.rb:50:in `run_action' /usr/local/lib/ruby/gems/1.8/gems/chef-0.9.8/bin/../lib/chef/runner.rb:109:in `converge' /usr/local/lib/ruby/gems/1.8/gems/chef-0.9.8/bin/../lib/chef/runner.rb:108:in `each' /usr/local/lib/ruby/gems/1.8/gems/chef-0.9.8/bin/../lib/chef/runner.rb:108:in `converge' /usr/local/lib/ruby/gems/1.8/gems/chef-0.9.8/bin/../lib/chef/resource_collection.rb:94:in `execute_each_resource' /usr/local/lib/ruby/gems/1.8/gems/chef-0.9.8/bin/../lib/chef/resource_collection/stepable_iterator.rb:116:in `call' /usr/local/lib/ruby/gems/1.8/gems/chef-0.9.8/bin/../lib/chef/resource_collection/stepable_iterator.rb:/usr/local/lib/ruby/gems/1.8/gems/chef-0.9.8/bin/../lib/chef/provider/package/freebsd.rb:89:in `package_name': Unexpected form for PKGNAME variable in /usr/ports/security/sudo/Makefile (Chef::Exceptions::Package) from /usr/local/lib/ruby/gems/1.8/gems/chef-0.9.8/bin/../lib/chef/provider/package/freebsd.rb:36:in `current_installed_version' from /usr/local/lib/ruby/gems/1.8/gems/chef-0.9.8/bin/../lib/chef/provider/package/freebsd.rb:71:in `load_current_resource' from /usr/local/lib/ruby/gems/1.8/gems/chef-0.9.8/bin/../lib/chef/runner.rb:43:in `build_provider' from /usr/local/lib/ruby/gems/1.8/gems/chef-0.9.8/bin/../lib/chef/runner.rb:50:in `run_action' from /usr/local/lib/ruby/gems/1.8/gems/chef-0.9.8/bin/../lib/chef/runner.rb:109:in `converge' from /usr/local/lib/ruby/gems/1.8/gems/chef-0.9.8/bin/../lib/chef/runner.rb:108:in `each' from /usr/local/lib/ruby/gems/1.8/gems/chef-0.9.8/bin/../lib/chef/runner.rb:108:in `converge' from /usr/local/lib/ruby/gems/1.8/gems/chef-0.9.8/bin/../lib/chef/resource_collection.rb:94:in `execute_each_resource' ... 12 levels... from /usr/local/lib/ruby/gems/1.8/gems/chef-0.9.8/bin/../lib/chef/application.rb:62:in `run' from /usr/local/lib/ruby/gems/1.8/gems/chef-0.9.8/bin/chef-client:26 from /usr/local/bin/chef-client:19:in `load' from /usr/local/bin/chef-client:19 116:in `call_iterator_block' /usr/local/lib/ruby/gems/1.8/gems/chef-0.9.8/bin/../lib/chef/resource_collection/stepable_iterator.rb:85:in `step' /usr/local/lib/ruby/gems/1.8/gems/chef-0.9.8/bin/../lib/chef/resource_collection/stepable_iterator.rb:104:in `iterate' /usr/local/lib/ruby/gems/1.8/gems/chef-0.9.8/bin/../lib/chef/resource_collection/stepable_iterator.rb:55:in `each_with_index' /usr/local/lib/ruby/gems/1.8/gems/chef-0.9.8/bin/../lib/chef/resource_collection.rb:92:in `execute_each_resource' /usr/local/lib/ruby/gems/1.8/gems/chef-0.9.8/bin/../lib/chef/runner.rb:82:in `converge' /usr/local/lib/ruby/gems/1.8/gems/chef-0.9.8/bin/../lib/chef/client.rb:304:in `converge' /usr/local/lib/ruby/gems/1.8/gems/chef-0.9.8/bin/../lib/chef/client.rb:106:in `run' /usr/local/lib/ruby/gems/1.8/gems/chef-0.9.8/bin/../lib/chef/application/client.rb:212:in `run_application' /usr/local/lib/ruby/gems/1.8/gems/chef-0.9.8/bin/../lib/chef/application/client.rb:202:in `loop' /usr/local/lib/ruby/gems/1.8/gems/chef-0.9.8/bin/../lib/chef/application/client.rb:202:in `run_application' /usr/local/lib/ruby/gems/1.8/gems/chef-0.9.8/bin/../lib/chef/application.rb:62:in `run' /usr/local/lib/ruby/gems/1.8/gems/chef-0.9.8/bin/chef-client:26 /usr/local/bin/chef-client:19:in `load' /usr/local/bin/chef-client:19
Hide
Permalink
Renaud Chaput added a comment -

I fixed the first issue in CHEF-1984 by fixing :cwd, but i prefer your use of -f. I will submit a pull request for this.

I dont see a strong argument to use PKGSITE in place of PKGROOT. Both can be useful, and i dont see a way to be able to specify both. Do you have an idea ?

Show
Renaud Chaput added a comment - I fixed the first issue in CHEF-1984 by fixing :cwd, but i prefer your use of -f. I will submit a pull request for this. I dont see a strong argument to use PKGSITE in place of PKGROOT. Both can be useful, and i dont see a way to be able to specify both. Do you have an idea ?
Hide
Permalink
Renaud Chaput added a comment -

https://github.com/renchap/chef/commits/CHEF-1413

In my branch, the package provider uses -f /path/to/Makefile

Show
Renaud Chaput added a comment - https://github.com/renchap/chef/commits/CHEF-1413 In my branch, the package provider uses -f /path/to/Makefile
Hide
Permalink
Bryan McLellan [Opscode] added a comment -

From what I've reviewed, PACKAGEROOT is used for specifying the URL to the server and the path is automatically generated, whereas PACKAGESITE allows you to specify both.

It seems to me that we would want the one that allows you to change both portions, if you don't want to change the path you can provide the default.

If we wanted to make the source attribute simpler, we would parse it for a URL and determine if it contains a path or not, and then provide pkg_add with the correct environment variable.

However, I'm not convinced that this is incredibly simpler and worth the effort. If someone disagrees, I encourage them to open this as a separate ticket and provide a patch.

The patch provided by Renaud has been merged and will be in the next release of 0.10.

Show
Bryan McLellan [Opscode] added a comment - From what I've reviewed, PACKAGEROOT is used for specifying the URL to the server and the path is automatically generated, whereas PACKAGESITE allows you to specify both. It seems to me that we would want the one that allows you to change both portions, if you don't want to change the path you can provide the default. If we wanted to make the source attribute simpler, we would parse it for a URL and determine if it contains a path or not, and then provide pkg_add with the correct environment variable. However, I'm not convinced that this is incredibly simpler and worth the effort. If someone disagrees, I encourage them to open this as a separate ticket and provide a patch. The patch provided by Renaud has been merged and will be in the next release of 0.10.
Hide
Permalink
Bryan McLellan [Opscode] added a comment -

Reopening for fix version change.

Show
Bryan McLellan [Opscode] added a comment - Reopening for fix version change.
Hide
Permalink
Bryan McLellan [Opscode] added a comment -

0.10.2 was a security release, 0.10.4 is the next maintenance release.

Show
Bryan McLellan [Opscode] added a comment - 0.10.2 was a security release, 0.10.4 is the next maintenance release.
Hide
Permalink
Bryan McLellan [Opscode] added a comment -

Bulk edit: this ticket should have been previously merged for 0.10.2, but will be released in 0.10.4

Show
Bryan McLellan [Opscode] added a comment - Bulk edit: this ticket should have been previously merged for 0.10.2, but will be released in 0.10.4
Hide
Permalink
Andrea Campi added a comment -

Unfortunately this breaks ports that depend on .CURDIR, e.g. sysutils/munin-node.

Show
Andrea Campi added a comment - Unfortunately this breaks ports that depend on .CURDIR, e.g. sysutils/munin-node.
Hide
Permalink
Andrea Campi added a comment -

Changing the line again to:

make_v = shell_out!("make -V #{variable} -f #{port_path}/Makefile", :cwd => port_path, :env => nil, :returns => [0,1])

fixes the issue.

Show
Andrea Campi added a comment - Changing the line again to: make_v = shell_out!( "make -V #{variable} -f #{port_path}/Makefile" , :cwd => port_path, :env => nil, :returns => [0,1]) fixes the issue.
Hide
Permalink
Bryan McLellan [Opscode] added a comment -

See CHEF-2634 for the bug Andrea Campi discusses.

Show
Bryan McLellan [Opscode] added a comment - See CHEF-2634 for the bug Andrea Campi discusses.
Hide
Permalink
Andrea Campi added a comment -

This is still an issue on 0.10.6.rc2

Show
Andrea Campi added a comment - This is still an issue on 0.10.6.rc2
Hide
Permalink
Renaud Chaput added a comment -

Please discuss it on CHEF-2634. I added a comment, there is one line still using -f which need to be changed.

Show
Renaud Chaput added a comment - Please discuss it on CHEF-2634 . I added a comment, there is one line still using -f which need to be changed.
Hide
Permalink
Andrea Campi added a comment -

Uhm, right, it looked like that issue is related indeed, but I thought it was mostly about something else.

If this issue is considered superseded by CHEF-2634 it should be closed then.

Show
Andrea Campi added a comment - Uhm, right, it looked like that issue is related indeed, but I thought it was mostly about something else. If this issue is considered superseded by CHEF-2634 it should be closed then.
Hide
Permalink
Andrea Campi added a comment -

The original issue has now been fixed, and regressions are tracked in CHEF-2634.

Show
Andrea Campi added a comment - The original issue has now been fixed, and regressions are tracked in CHEF-2634 .
Hide
Permalink
Bryan McLellan [Opscode] added a comment -

Closing this ticket. Regression conversation is on CHEF-2634, which I just pushed a patch for to the 0.10.6-rc branch.

Show
Bryan McLellan [Opscode] added a comment - Closing this ticket. Regression conversation is on CHEF-2634 , which I just pushed a patch for to the 0.10.6-rc branch.

People

  • Assignee:
    Bryan McLellan [Opscode]
    Reporter:
    Andrew Sokoloff
Vote (1)
Watch (2)

Dates

  • Created:
    Updated:
    Resolved: