link resource is broken when using shef in client mode

Details

  • Type: Bug Bug
  • Status: Closed Closed
  • Priority: Critical Critical
  • Resolution: Fixed
  • Affects Version/s: 0.9.0, 0.9.2, 0.9.4
  • Fix Version/s: 0.9.8
  • Component/s: Chef Client
  • Labels:
    None

Description

shef includes fileutils, which defines "link". This conflicts with the 'link' resource because of the way method_missing is used to create resources. When running shef in client mode where it is loading cookbooks that have the link resource defined:

ubuntu@ip-10-251-203-65:~$ sudo shef -z -c /etc/chef/client.rb
loading configuration: /etc/chef/client.rb
Loading...........epic fail!

/var/chef/cache/cookbooks/runit/definitions/runit_service.rb:90:in `link': wrong number of arguments (1 for 2) (ArgumentError)
        from /var/chef/cache/cookbooks/runit/definitions/runit_service.rb:90:in `from_file'
        from /usr/lib/ruby/gems/1.8/gems/chef-0.9.4/lib/chef/mixin/recipe_definition_dsl_core.rb:49:in `instance_eval'
        from /usr/lib/ruby/gems/1.8/gems/chef-0.9.4/lib/chef/mixin/recipe_definition_dsl_core.rb:49:in `method_missing'
        from /var/chef/cache/cookbooks/nginx/recipes/source.rb:93:in `from_file'
        from /usr/lib/ruby/gems/1.8/gems/chef-0.9.4/lib/chef/cookbook_version.rb:316:in `load_recipe'
        from /usr/lib/ruby/gems/1.8/gems/chef-0.9.4/lib/chef/mixin/language_include_recipe.rb:40:in `include_recipe'
        from /usr/lib/ruby/gems/1.8/gems/chef-0.9.4/lib/chef/mixin/language_include_recipe.rb:27:in `each'
        from /usr/lib/ruby/gems/1.8/gems/chef-0.9.4/lib/chef/mixin/language_include_recipe.rb:27:in `include_recipe'
        from /usr/lib/ruby/gems/1.8/gems/chef-0.9.4/lib/chef/run_context.rb:93:in `load'
        from /usr/lib/ruby/gems/1.8/gems/chef-0.9.4/lib/chef/run_context.rb:90:in `each'
        from /usr/lib/ruby/gems/1.8/gems/chef-0.9.4/lib/chef/run_context.rb:90:in `load'
        from /usr/lib/ruby/gems/1.8/gems/chef-0.9.4/lib/chef/run_context.rb:54:in `initialize'
        from /usr/lib/ruby/gems/1.8/gems/chef-0.9.4/lib/chef/shef/shef_session.rb:142:in `new'
        from /usr/lib/ruby/gems/1.8/gems/chef-0.9.4/lib/chef/shef/shef_session.rb:142:in `rebuild_context'
        from /usr/lib/ruby/gems/1.8/gems/chef-0.9.4/lib/chef/shef/shef_session.rb:36:in `reset!'
        from /usr/lib/ruby/gems/1.8/gems/chef-0.9.4/lib/chef/shef/shef_session.rb:78:in `loading'
        from /usr/lib/ruby/gems/1.8/gems/chef-0.9.4/lib/chef/shef/shef_session.rb:33:in `reset!'
        from /usr/lib/ruby/gems/1.8/gems/chef-0.9.4/lib/chef/shef.rb:75:in `session'
        from /usr/lib/ruby/gems/1.8/gems/chef-0.9.4/lib/chef/shef.rb:83:in `init'
        from /usr/lib/ruby/gems/1.8/gems/chef-0.9.4/bin/shef:41:in `run_config'
        from /usr/lib/ruby/1.8/irb/init.rb:20:in `setup'
        from /usr/lib/ruby/1.8/irb.rb:54:in `start'
        from /usr/lib/ruby/gems/1.8/gems/chef-0.9.4/bin/shef:47
        from /usr/bin/shef:19:in `load'
        from /usr/bin/shef:19

Everything works fine when chef-client is run.

Or, when run in standalone mode w/o a node:

ubuntu@ip-10-251-203-65:~$ sudo shef -s
loading configuration: none (standalone shef session)
Loading........done.

This is shef, the Chef shell.
 Chef Version: 0.9.4
 http://www.opscode.com/chef
 http://wiki.opscode.com/display/chef/Home

run `help' for help, `exit' or ^D to quit.

Ohai2u ubuntu@ip-10-251-203-65.ec2.internal!
chef > recipe
chef:recipe > link "/tmp/foo" do
chef:recipe >   to "/etc/hosts"
chef:recipe ?> end
ArgumentError: wrong number of arguments (1 for 2)
        from (irb#1):2:in `link'
        from (irb#1):2

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Daniel DeLeo added a comment -

I believe this is fixed with CHEF-1497

Show
Daniel DeLeo added a comment - I believe this is fixed with CHEF-1497
Hide
Permalink
jtimberman added a comment -

Still happening with 0.9.8.beta.1

chef > recipe
chef:recipe > link "/tmp/hosts1" do
chef:recipe >   to "/etc/hosts"
chef:recipe ?> end
ArgumentError: wrong number of arguments (1 for 2)
        from (irb#1):1:in `link'
        from (irb#1):1
chef:recipe > version
This is shef, the Chef shell.
 Chef Version: 0.9.8.beta.1
 http://www.opscode.com/chef
 http://wiki.opscode.com/display/chef/Home
 => :ucanhaz_automation
Show
jtimberman added a comment - Still happening with 0.9.8.beta.1 chef > recipe chef:recipe > link "/tmp/hosts1" do chef:recipe > to "/etc/hosts" chef:recipe ?> end ArgumentError: wrong number of arguments (1 for 2) from (irb#1):1:in `link' from (irb#1):1 chef:recipe > version This is shef, the Chef shell. Chef Version: 0.9.8.beta.1 http: //www.opscode.com/chef http: //wiki.opscode.com/display/chef/Home => :ucanhaz_automation
Hide
Permalink
Daniel DeLeo added a comment -

yep, fixed in master though:

chef:recipe > link("/tmp/foo") { to "/tmp/bar" }
 => #<Chef::Resource::Link:0x1018c3410 @node=<Chef::Node:0x80cb6bac @name="fermi.local">, @ignore_failure=false, @only_if=nil, @name="/tmp/foo", @supports={}, @params={}, @enclosing_provider=nil, @source_line="(irb#1):1:in `irb_binding'", @notifies_delayed=[], @provider=nil, @not_if_args={}, @source_file="/tmp/bar", @target_file="/tmp/foo", @updated=false, @cookbook_name=nil, @resource_name=:link, @notifies_immediate=[], @before=nil, @run_context=#<Chef::RunContext:0x101967da8 @node=<Chef::Node:0x80cb6bac @name="fermi.local">, @resource_collection=#<Chef::ResourceCollection:0x101967d30 @insert_after_idx=nil, @resources_by_name={"link[/tmp/foo]"=>0}, @resources=[#<Chef::Resource::Link:0x1018c3410 ...>]>, @definitions={}, @cookbook_collection={}>, @not_if=nil, @link_type=:symbolic, @action=:create, @to=nil, @only_if_args={}, @allowed_actions=[:nothing, :create, :delete], @noop=nil> 
chef:recipe >
Show
Daniel DeLeo added a comment - yep, fixed in master though: chef:recipe > link( "/tmp/foo" ) { to "/tmp/bar" } => #<Chef::Resource::Link:0x1018c3410 @node=<Chef::Node:0x80cb6bac @name= "fermi.local" >, @ignore_failure= false , @only_if=nil, @name= "/tmp/foo" , @supports={}, @params={}, @enclosing_provider=nil, @source_line= "(irb#1):1:in `irb_binding'" , @notifies_delayed=[], @provider=nil, @not_if_args={}, @source_file= "/tmp/bar" , @target_file= "/tmp/foo" , @updated= false , @cookbook_name=nil, @resource_name=:link, @notifies_immediate=[], @before=nil, @run_context=#<Chef::RunContext:0x101967da8 @node=<Chef::Node:0x80cb6bac @name= "fermi.local" >, @resource_collection=#<Chef::ResourceCollection:0x101967d30 @insert_after_idx=nil, @resources_by_name={ "link[/tmp/foo]" =>0}, @resources=[#<Chef::Resource::Link:0x1018c3410 ...>]>, @definitions={}, @cookbook_collection={}>, @not_if=nil, @link_type=:symbolic, @action=:create, @to=nil, @only_if_args={}, @allowed_actions=[:nothing, :create, :delete], @noop=nil> chef:recipe >

People

  • Assignee:
    Unassigned
    Reporter:
    jtimberman
Vote (0)
Watch (0)

Dates

  • Created:
    Updated:
    Resolved: