Upstart provider fails restart action if service is not started yet

In fact, I think the "restart: command should never be used. It is NOT the same as stop/start because Upstart doesn't re-read the config file on restart. So if your "/etc/init/cmd.conf" does a :notifies :restart => "service[:xxx]", it won't use your changes.

I've been doing this for safety:

service "xxx" do
    provider Chef::Provider::Service::Upstart
    action :start
    # Always best to do a clean restart:
    # the normal 'restart foo' command will NOT re-read /etc/init/cmd.conf
    # Also, restart won't start.
    restart_command "stop #{xxx} && start #{xxx}"
  end

In that case, :restart should be implemented as stop + start internally. this would also solve the bug.

Restart is implemented as stop+start internally when supports :restart => false, lolz

Given this bug, stop + start should be the default behavior because obviously Upstart doesn't supports :retart => true. The fact that I can write a Chef code in way that is fundamentally wrong and not raise an error is, in my opinion, a bug.

Upstart simply is not idempotent, anywhere.

$ sudo start mysql
mysql start/running, process 1030
$ sudo start mysql ; echo $?
start: Job is already running: mysql
1

$ sudo status mysql
mysql stop/waiting
$ sudo stop mysql ; echo $?
stop: Unknown instance: 
1

We need to do is check the status of the service and then act accordingly. We do this for some actions, but not for restart.

Upstart provider doesn't use stop & start even if support :restart => false

https://github.com/avishai-ish-shalom/chef/tree/CHEF-1424
The first commit solves this bug, the second implements support :restart => false correctly but also changes the default behavior of the provider, see commit notes.

We should review the changes to default behavior before merging.

P.S. http://blog.loftninjas.org/2011/02/10/init-replacements-change-fundamental-assumptions/

It looks like the upstart team came around and fixed itself upstream.

https://bugs.launchpad.net/ubuntu/+source/upstart/+bug/430883

The lack of a restart option that did a 'stop/start' in the upstart provider was by design. All upstart jobs support restart because it is a feature of upstart, not of the individual scripts.

This patch has been merged to opscode/master and will be included in the next release. Thank you for contributing to Chef!

Reopening for fix version change.

0.10.2 was a security release, 0.10.4 is the next maintenance release.

Bulk edit: this ticket should have been previously merged for 0.10.2, but will be released in 0.10.4