The script provider does not account for possible spaces in the interpreter or script path on Windows

Details

  • Type: Improvement Improvement
  • Status: Closed Closed
  • Priority: Major Major
  • Resolution: Fixed
  • Affects Version/s: 0.9.6
  • Fix Version/s: 0.9.8
  • Component/s: Chef Client
  • Labels:
    None

Description

It is possible for the path to the interpreter or the generated script to have spaces. This causes the script execution to fail when it should succeed. While not too common on non-Windows machines this is more common on Windows as the temp path is likely to have spaces in it.

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Jon Seaberg added a comment -

http://github.com/jonseaberg/chef/tree/CHEF-1447

Show
Jon Seaberg added a comment - http://github.com/jonseaberg/chef/tree/CHEF-1447
Hide
Permalink
Raphael Simon added a comment -

Fixed in the script provider, pull fix from http://github.com/jonseaberg/chef/tree/CHEF-1447

Show
Raphael Simon added a comment - Fixed in the script provider, pull fix from http://github.com/jonseaberg/chef/tree/CHEF-1447
Hide
Permalink
Daniel DeLeo added a comment -

Hey guys, Jon is not listed in the CCLA yet, can you email legal@opscode and have him added to the CCLA? Then re-resolve the ticket once you're sorted and I'll merge it. Sorry, but we have to be sticklers about this.

Show
Daniel DeLeo added a comment - Hey guys, Jon is not listed in the CCLA yet, can you email legal@opscode and have him added to the CCLA? Then re-resolve the ticket once you're sorted and I'll merge it. Sorry, but we have to be sticklers about this.
Hide
Permalink
Jon Seaberg added a comment -

Fixed in the script provider, pull fix from http://github.com/jonseaberg/chef/tree/CHEF-1447

Show
Jon Seaberg added a comment - Fixed in the script provider, pull fix from http://github.com/jonseaberg/chef/tree/CHEF-1447
Hide
Permalink
Daniel DeLeo added a comment -

This is merged to master. Thanks for the patch and getting all the legal stuff taken care of with haste. May the Chef be with you

Show
Daniel DeLeo added a comment - This is merged to master. Thanks for the patch and getting all the legal stuff taken care of with haste. May the Chef be with you

People

  • Assignee:
    Adam Jacob
    Reporter:
    Jon Seaberg
Vote (0)
Watch (0)

Dates

  • Created:
    Updated:
    Resolved: