Negative UID heuristic fails for UIDs between 2**30 and 2**31

Details

  • Type: Bug Bug
  • Status: Closed Closed
  • Priority: Critical Critical
  • Resolution: Fixed
  • Affects Version/s: 0.9.6
  • Fix Version/s: 0.9.8
  • Component/s: Chef Client
  • Labels:
    None

Description

Chef::FileAccessControl considers all UIDs greater than 2**30 to actually be negative UIDs that were wrapped to their radix complements, but this is incorrect, only values greater than 2**31 could possibly be wrapped negative values. This causes failures with strange error messages when a UID between 2**30 and 2**31 is encountered. Luckily, the fix is simple, just set the maximum uid constant in file access control to 1 << 31.

Activity

Ascending order - Click to sort in descending order
Daniel DeLeo made changes -
Field Original Value New Value
Description Chef::FileAccessControl considers all UIDs greater than 2**30 to actually be negative UIDs that were wrapped to their radix complements, but this is incorrect, only values greater than 2**31 could possibly be wrapped negative values. This causes failures with strange error messages when a UID between 2**30 and 2**31 is encountered. Luckily, the fix is simple, just set the maximum uid constant in file access control to 1 << 31. Chef::FileAccessControl considers all UIDs greater than 2\*\*30 to actually be negative UIDs that were wrapped to their radix complements, but this is incorrect, only values greater than 2\*\*31 could possibly be wrapped negative values. This causes failures with strange error messages when a UID between 2\*\*30 and 2\*\*31 is encountered. Luckily, the fix is simple, just set the maximum uid constant in file access control to 1 << 31.
Tollef Fog Heen made changes -
Status Open [ 1 ] Resolved [ 5 ]
Assignee Adam Jacob [ adam ]
Resolution Fixed [ 1 ]
Daniel DeLeo made changes -
Status Resolved [ 5 ] Closed [ 6 ]
Assignee Adam Jacob [ adam ] Daniel DeLeo [ dan@kallistec.com ]
Bryan McLellan [Opscode] made changes -
Workflow jira [ 12048 ] New OSS [ 19470 ]
Bryan McLellan [Opscode] made changes -
Workflow New OSS [ 19470 ] OSS: Product Management [ 27379 ]

People

  • Assignee:
    Daniel DeLeo
    Reporter:
    Daniel DeLeo
Vote (0)
Watch (0)

Dates

  • Created:
    Updated:
    Resolved: