file provider backup fails on Windows platforms

Details

  • Type: Bug Bug
  • Status: Closed Closed
  • Priority: Major Major
  • Resolution: Fixed
  • Affects Version/s: None
  • Fix Version/s: 0.9.8
  • Component/s: None
  • Labels:
    None
  • Environment:

    Windows

Description

FileUtils.mkdir_p fails in Chef::Provider::File when the backup path contains a drive letter.

Experienced using the template provider, where:

template "C:/hudson/hudson-slave.xml" do
  source "hudson-slave.xml"
  ...
end

log:

INFO: Writing updated content for template[C:/hudson/hudson-slave.xml] to C:/hudson/hudson-slave.xml
ERROR: template[C:/hudson/hudson-slave.xml] (.../recipes/default.rb:4:in `from_file') had an error:
Invalid argument - C:/chef/backup/C:
...

Problem is in Chef::Provider::File.backup, where backup_filename contains the drive letter: 'C:/hudson/hudson-slave.xml.chef-timestamp', boils down to:

ruby -e 'FileUtils.mkdir_p(File.dirname(File.join(ARGV[0], ARGV[1])))' c:/chef/backup C:/hudson/hudson-slave.xml.chef-timestamp
C:/Ruby/lib/ruby/1.8/fileutils.rb:243:in `mkdir': Invalid argument - c:/chef/backup/C: (Errno::EINVAL)
        from C:/Ruby/lib/ruby/1.8/fileutils.rb:243:in `fu_mkdir'
        from C:/Ruby/lib/ruby/1.8/fileutils.rb:217:in `mkdir_p'
        from C:/Ruby/lib/ruby/1.8/fileutils.rb:215:in `reverse_each'
        from C:/Ruby/lib/ruby/1.8/fileutils.rb:215:in `mkdir_p'
        from C:/Ruby/lib/ruby/1.8/fileutils.rb:201:in `each'
        from C:/Ruby/lib/ruby/1.8/fileutils.rb:201:in `mkdir_p'
        from -e:1

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Doug MacEachern added a comment -

Fix + unit test at: http://github.com/dougm/chef/tree/CHEF-1509

Show
Doug MacEachern added a comment - Fix + unit test at: http://github.com/dougm/chef/tree/CHEF-1509
Hide
Permalink
Daniel DeLeo added a comment -

Thanks for the quick turnaround. Awesome. This will be in 0.9.8 when it ships.

Dan DeLeo

Show
Daniel DeLeo added a comment - Thanks for the quick turnaround. Awesome. This will be in 0.9.8 when it ships. Dan DeLeo

People

  • Assignee:
    Daniel DeLeo
    Reporter:
    Doug MacEachern
Vote (0)
Watch (0)

Dates

  • Created:
    Updated:
    Resolved: