cron provider on ubuntu won't renable a commented out cron job

Details

  • Type: Bug Bug
  • Status: Closed Closed
  • Priority: Trivial Trivial
  • Resolution: Fixed
  • Affects Version/s: 0.9.8, 0.10.8
  • Fix Version/s: 0.10.10
  • Component/s: None
  • Labels:
    None

Description

  1. Chef Name: test
    #*/1 * * * * /bin/true

running chef-client does not cause chef to renable this manually disabled cron job.

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Alex Tomlins added a comment -

Pull request here: https://github.com/opscode/chef/pull/251

I've fixed the issue with commented out cron lines not being re-enabled. In the process, I've covered the general case of handling crontabs with the chef comment, but no corresponding crontab line.

I've also taken the opportunity to refactor the Solaris cron provider to inherit most of its functionality from the standard provider.

Show
Alex Tomlins added a comment - Pull request here: https://github.com/opscode/chef/pull/251 I've fixed the issue with commented out cron lines not being re-enabled. In the process, I've covered the general case of handling crontabs with the chef comment, but no corresponding crontab line. I've also taken the opportunity to refactor the Solaris cron provider to inherit most of its functionality from the standard provider.
Hide
Permalink
Bryan McLellan [Opscode] added a comment -

Marked to be merged.

Show
Bryan McLellan [Opscode] added a comment - Marked to be merged.
Hide
Permalink
Bryan McLellan [Opscode] added a comment -

Alex, I could not rebase this against master. Could you please make an attempt at it? I'm afraid I would lose something functionality that I didn't understand along the way.

Show
Bryan McLellan [Opscode] added a comment - Alex, I could not rebase this against master. Could you please make an attempt at it? I'm afraid I would lose something functionality that I didn't understand along the way.
Hide
Permalink
Alex Tomlins added a comment -

Ah, that looks like a conflict with CHEF-2745. I'll try to have a dig over the weekend.

Show
Alex Tomlins added a comment - Ah, that looks like a conflict with CHEF-2745 . I'll try to have a dig over the weekend.
Hide
Permalink
Alex Tomlins added a comment -

I've rebased this against current master, and updated the pull request.

In mergin the changes, I've also fixed a small issue with CHEF-2745

Show
Alex Tomlins added a comment - I've rebased this against current master, and updated the pull request. In mergin the changes, I've also fixed a small issue with CHEF-2745
Hide
Permalink
Bryan McLellan [Opscode] added a comment -

Got the branch merged into master. Hat trick there with the fix, rebase, and CHEF-2745. Thanks.

Show
Bryan McLellan [Opscode] added a comment - Got the branch merged into master. Hat trick there with the fix, rebase, and CHEF-2745 . Thanks.

People

  • Assignee:
    Alex Tomlins
    Reporter:
    Bryan McLellan [Opscode]
Vote (0)
Watch (0)

Dates

  • Created:
    Updated:
    Resolved: