IOError - closed stream in erl_call provider

Details

  • Type: Bug Bug
  • Status: Closed Closed
  • Priority: Major Major
  • Resolution: Fixed
  • Affects Version/s: 0.9.8
  • Fix Version/s: 0.9.14, 0.10.0
  • Component/s: Chef Client
  • Labels:
    None

Description

I'm not yet sure if this is something that the provider or erl_call is doing, either way it should be fixed or worked around.

[Thu, 14 Oct 2010 14:57:19 +0000] ERROR: Exception handlers complete
[Thu, 14 Oct 2010 14:57:19 +0000] ERROR: Re-raising exception: IOError - closed stream
/usr/lib/ruby/gems/1.8/gems/chef-0.9.8/bin/../lib/chef/mixin/command/unix.rb:137:in `close_write'
/usr/lib/ruby/gems/1.8/gems/chef-0.9.8/bin/../lib/chef/mixin/command/unix.rb:137:in `popen4'

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Joe Williams added a comment -

Looks like this was more weirdness with popen4, similar to the issues I found with using block syntax in the easy_install provider (CHEF-1524).

It's fixed in http://github.com/joewilliams/chef/tree/CHEF-1781

Show
Joe Williams added a comment - Looks like this was more weirdness with popen4, similar to the issues I found with using block syntax in the easy_install provider ( CHEF-1524 ). It's fixed in http://github.com/joewilliams/chef/tree/CHEF-1781
Hide
Permalink
Daniel DeLeo added a comment -

bulk updating fix versions to next release

Show
Daniel DeLeo added a comment - bulk updating fix versions to next release
Hide
Permalink
Joe Williams added a comment -

Added an ensure block to wait for the erl_call process to exit before moving on.

http://github.com/joewilliams/chef/commit/9b86531a558166e1d561ad9c4741f70e6ded50a2

Show
Joe Williams added a comment - Added an ensure block to wait for the erl_call process to exit before moving on. http://github.com/joewilliams/chef/commit/9b86531a558166e1d561ad9c4741f70e6ded50a2
Hide
Permalink
Daniel DeLeo added a comment -

Thanks, Joe, your patch is merged here: https://github.com/opscode/chef/commit/e8bb4d13b2bcdd24f7e8e6d74fc6edca73c77bb5

I also caught a bug where the code was not getting written to the stdin of the erl_call process: when you call String#chomp!, it will return nil if the string was not modified. So you usually want to use the non-bang version.

I've also made a note to have this patch looked at for inclusion in 0.9.14.

Show
Daniel DeLeo added a comment - Thanks, Joe, your patch is merged here: https://github.com/opscode/chef/commit/e8bb4d13b2bcdd24f7e8e6d74fc6edca73c77bb5 I also caught a bug where the code was not getting written to the stdin of the erl_call process: when you call String#chomp!, it will return nil if the string was not modified. So you usually want to use the non-bang version. I've also made a note to have this patch looked at for inclusion in 0.9.14.
Hide
Permalink
Daniel DeLeo added a comment -

correcting the fix versions to 0.9.14 and 0.10.0

Show
Daniel DeLeo added a comment - correcting the fix versions to 0.9.14 and 0.10.0

People

  • Assignee:
    Daniel DeLeo
    Reporter:
    Joe Williams
Vote (0)
Watch (0)

Dates

  • Created:
    Updated:
    Resolved: