LWRP resource should be able to specify the default action for a resource

Details

  • Type: New Feature New Feature
  • Status: Closed Closed
  • Priority: Minor Minor
  • Resolution: Fixed
  • Affects Version/s: 0.9.14
  • Fix Version/s: 0.10.10
  • Component/s: Chef Client
  • Labels:
    None

Description

It would be nice to specify a default action in a cookbook LWRP.

In 'regular' chef resources in the library, the @action value can do this. Something like:

actions :build, :install => :default, :remove

Activity

Ascending order - Click to sort in descending order
Daniel DeLeo made changes -
Field Original Value New Value
Fix Version/s 0.9.14 [ 10083 ]
Fix Version/s 0.9.12 [ 10082 ]
Hide
Permalink
Avishai Ish-Shalom added a comment -

https://github.com/avishai-ish-shalom/chef/tree/CHEF-1789

actions :create, :delete, :default => :create

:default => :action options Hash must be the last argument.

Show
Avishai Ish-Shalom added a comment - https://github.com/avishai-ish-shalom/chef/tree/CHEF-1789 actions :create, :delete, : default => :create :default => :action options Hash must be the last argument.
Avishai Ish-Shalom made changes -
Status Open [ 1 ] Resolved [ 5 ]
Assignee Adam Jacob [ adam ]
Resolution Fixed [ 1 ]
Hide
Permalink
Alexey Melezhik added a comment - - edited

i have installed chef-0.9.14 but I don't default action support, I also have checked source code and noticed that announced changes are not here:

wget https://github.com/avishai-ish-shalom/chef/raw/8c7d11bd3be81c6fc8e1e15137ac7957092cbeab/chef/lib/chef/resource.rb > /tmp/foo.rb

diff -u /usr/local/lib64/ruby/gems/1.8/gems/chef-0.9.14/lib/chef/resource.rb /tmp/foo.rb

— /usr/local/lib64/ruby/gems/1.8/gems/chef-0.9.14/lib/chef/resource.rb 2011-03-28 13:58:16.000000000 +0400
+++ /tmp/foo.rb 2011-03-28 14:09:11.000000000 +0400

@@ -459,11 +459,17 @@
class << cls
include Chef::Mixin::FromFile

+ attr_reader :default_action
+
def actions_to_create
@actions_to_create
end

define_method(:actions) do |*action_names|
+ if action_names.last.is_a? Hash
+ action_options = action_names.pop
+ @default_action = action_options[:default] if action_options.has_key? :default
+ end
actions_to_create.push(*action_names)
end
end
@@ -479,6 +485,7 @@
args_run_context = optional_args.shift
@resource_name = rname.to_sym
old_init.bind(self).call(name, args_run_context)
+ @action = self.class.default_action
allowed_actions.push(self.class.actions_to_create).flatten!
end
end

Show
Alexey Melezhik added a comment - - edited i have installed chef-0.9.14 but I don't default action support, I also have checked source code and noticed that announced changes are not here: wget https://github.com/avishai-ish-shalom/chef/raw/8c7d11bd3be81c6fc8e1e15137ac7957092cbeab/chef/lib/chef/resource.rb > /tmp/foo.rb diff -u /usr/local/lib64/ruby/gems/1.8/gems/chef-0.9.14/lib/chef/resource.rb /tmp/foo.rb — /usr/local/lib64/ruby/gems/1.8/gems/chef-0.9.14/lib/chef/resource.rb 2011-03-28 13:58:16.000000000 +0400 +++ /tmp/foo.rb 2011-03-28 14:09:11.000000000 +0400 @@ -459,11 +459,17 @@ class << cls include Chef::Mixin::FromFile + attr_reader :default_action + def actions_to_create @actions_to_create end define_method(:actions) do |*action_names| + if action_names.last.is_a? Hash + action_options = action_names.pop + @default_action = action_options [:default] if action_options.has_key? :default + end actions_to_create.push(*action_names) end end @@ -479,6 +485,7 @@ args_run_context = optional_args.shift @resource_name = rname.to_sym old_init.bind(self).call(name, args_run_context) + @action = self.class.default_action allowed_actions.push(self.class.actions_to_create).flatten! end end
Hide
Permalink
Daniel DeLeo added a comment -

Before we merge this, we want to make sure this is the DSL we want to commit to for this feature. I've started a discussion on the mailing list here: http://lists.opscode.com/sympa/arc/chef-dev/2011-05/msg00029.html

Show
Daniel DeLeo added a comment - Before we merge this, we want to make sure this is the DSL we want to commit to for this feature. I've started a discussion on the mailing list here: http://lists.opscode.com/sympa/arc/chef-dev/2011-05/msg00029.html
Seth Chisamore made changes -
Assignee Adam Jacob [ adam ] Daniel DeLeo [ dan@kallistec.com ]
Fix Version/s 0.9.14 [ 10083 ]
Affects Version/s 0.9.14 [ 10083 ]
Triage Status [Triaged]
Hide
Permalink
Seth Chisamore added a comment -

Consensus on the mailing list is default_action should be an attribute, but you shouldn't have to also include the default action in list passed to the action attribute. For example:

actions :prepare_thumbs, :twiddle_thumbs
default_action :pass_buck
Show
Seth Chisamore added a comment - Consensus on the mailing list is default_action should be an attribute, but you shouldn't have to also include the default action in list passed to the action attribute. For example: actions :prepare_thumbs, :twiddle_thumbs default_action :pass_buck
Hide
Permalink
Bryan McLellan [Opscode] added a comment -

The attached branch will need to be updated to support the 'default_action' attribute semantics decided upon by the community.

Show
Bryan McLellan [Opscode] added a comment - The attached branch will need to be updated to support the 'default_action' attribute semantics decided upon by the community.
Bryan McLellan [Opscode] made changes -
Resolution Fixed [ 1 ]
Status Resolved [ 5 ] Reopened [ 4 ]
Assignee Daniel DeLeo [ dan@kallistec.com ]
Hide
Permalink
Michael Leinartas added a comment -

Modify'd Avishai's patch to comply with the list's decision to add a new DSL method for default_action:

https://github.com/mleinart/chef/tree/CHEF-1789

Show
Michael Leinartas added a comment - Modify'd Avishai's patch to comply with the list's decision to add a new DSL method for default_action: https://github.com/mleinart/chef/tree/CHEF-1789
Michael Leinartas made changes -
Status Reopened [ 4 ] Resolved [ 5 ]
Assignee Bryan McLellan [ btm ]
Resolution Fixed [ 1 ]
Hide
Permalink
Bryan McLellan [Opscode] added a comment -

Merged to master. Thanks everyone, great community effort here.

Show
Bryan McLellan [Opscode] added a comment - Merged to master. Thanks everyone, great community effort here.
Bryan McLellan [Opscode] made changes -
Status Resolved [ 5 ] Closed [ 6 ]
Fix Version/s 0.10.10 [ 10702 ]
Bryan McLellan [Opscode] made changes -
Component/s Chef Client [ 10000 ]
Component/s Resources [ 10004 ]
Bryan McLellan [Opscode] made changes -
Workflow jira [ 12454 ] New OSS [ 19724 ]
Bryan McLellan [Opscode] made changes -
Workflow New OSS [ 19724 ] OSS: Product Management [ 27635 ]
Transition Time In Source Status Execution Times Last Executer Last Execution Date
Open Open Resolved Resolved
111d 19h 53m 1 Avishai Ish-Shalom 09/Feb/11 4:06 PM
Resolved Resolved Reopened Reopened
159d 22h 58m 1 Bryan McLellan [Opscode] 19/Jul/11 3:04 PM
Reopened Reopened Resolved Resolved
136d 16h 17m 1 Michael Leinartas 03/Dec/11 7:21 AM
Resolved Resolved Closed Closed
104d 14h 14m 1 Bryan McLellan [Opscode] 16/Mar/12 9:35 PM

People

  • Assignee:
    Bryan McLellan [Opscode]
    Reporter:
    Joshua Timberman [Opscode]
Vote (2)
Watch (2)

Dates

  • Created:
    Updated:
    Resolved: