When running chef-client and using "knife node edit" operations at the same time, node data (at least run_list) gets overwritten

Details

  • Type: Bug Bug
  • Status: Open Open
  • Priority: Major Major
  • Resolution: Unresolved
  • Affects Version/s: 0.9.12
  • Fix Version/s: None
  • Component/s: None
  • Labels:
    None

Description

Start chef-run, currently run_list has A in it.
Use knife to edit the node (run_list, etc), make it has A, and B in it, save,
chef-run finishes, save the node. Now run_list becomes A again.

When chef-client saves the node, it should retrieve the current state first.

Issue Links

is duplicated by

Bug - A problem which impairs or prevents the functions of the product. CHEF-2710 Chef-client doesn't save changes made by knife while it was running

  • Unknown - Issue untriaged, priority unassigned or questioned
  • Closed - The issue is considered finished, the resolution is correct. Issues which are closed can be reopened.

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Paul Paradise added a comment -

I'm confused how simply retrieving the current state can help here.

Recipes can modify any of the node's attributes (not just the run_list), and if chef-client just retrieves the current state without doing either a lock or a very complex merge process it will a) overwrites any intentional changes that cookbooks attempted to make, and b) only reduce the likelihood of a race condition, rather than eliminate it.

Show
Paul Paradise added a comment - I'm confused how simply retrieving the current state can help here. Recipes can modify any of the node's attributes (not just the run_list), and if chef-client just retrieves the current state without doing either a lock or a very complex merge process it will a) overwrites any intentional changes that cookbooks attempted to make, and b) only reduce the likelihood of a race condition, rather than eliminate it.
Hide
Permalink
Nuo Yan added a comment -

You are right. I wasn't trying to suggest a solution (I should probably remove that last line), just wanted to create this ticket to track the problem so we can remember it and we will do more research on it when we work on it.

Show
Nuo Yan added a comment - You are right. I wasn't trying to suggest a solution (I should probably remove that last line), just wanted to create this ticket to track the problem so we can remember it and we will do more research on it when we work on it.
Nuo Yan made changes -
Field Original Value New Value
Description Start chef-run, currently run_list has A in it.
Use knife to edit the node (run_list, etc), make it has A, and B in it, save,
chef-run finishes, save the node. Now run_list becomes A again.

When chef-client saves the node, it should retrieve the current state first. 		Start chef-run, currently run_list has A in it.
Use knife to edit the node (run_list, etc), make it has A, and B in it, save,
chef-run finishes, save the node. Now run_list becomes A again.

-When chef-client saves the node, it should retrieve the current state first.-
Nuo Yan made changes -
Comment [ Not suggesting solution. Wrote what on the top of my head when I created the ticket but probably wrong. ]
Hide
Permalink
Mike Williams added a comment -

This is a pretty big issue for us, because it makes run-list changes unreliable.

I can confirm that the issue exists in 0.9.8, as well.

Show
Mike Williams added a comment - This is a pretty big issue for us, because it makes run-list changes unreliable. I can confirm that the issue exists in 0.9.8, as well.
Hide
Permalink
Tom Thomas (Inactive) added a comment -

http://mikerowecode.com/2010/11/chef-node-update-locking.html for discussion on this bug ticket - "Chef doesn't lock node data when updating"

above references this chef mailing list discussion - http://lists.opscode.com/sympa/arc/chef/2010-11/msg00019.html

Show
Tom Thomas (Inactive) added a comment - http://mikerowecode.com/2010/11/chef-node-update-locking.html for discussion on this bug ticket - "Chef doesn't lock node data when updating" above references this chef mailing list discussion - http://lists.opscode.com/sympa/arc/chef/2010-11/msg00019.html
Bryan McLellan [Opscode] made changes -
Link This issue is duplicated by CHEF-2710 [ CHEF-2710 ]
Bryan McLellan [Opscode] made changes -
Workflow jira [ 12496 ] New OSS [ 17346 ]
Bryan McLellan [Opscode] made changes -
Workflow New OSS [ 17346 ] OSS: Product Management [ 25977 ]
Status In Progress [ 3 ] Open [ 1 ]
Transition Time In Source Status Execution Times Last Executer Last Execution Date
Open Open Confirmed Confirmed
785d 16h 35m 1 ${tran.lastUpdater} 20/Dec/12 3:13 PM
Confirmed Confirmed In Progress In Progress
16s 1 ${tran.lastUpdater} 20/Dec/12 3:13 PM
In Progress In Progress Open Open
81d 7h 27m 1 Bryan McLellan [Opscode] 11/Mar/13 10:41 PM

People

  • Assignee:
    Unassigned
    Reporter:
    Nuo Yan
Vote (4)
Watch (2)

Dates

  • Created:
    Updated: