knife status should handle a null ohai_time instead of failing noisily

Details

  • Type: Bug Bug
  • Status: Closed Closed
  • Priority: Major Major
  • Resolution: Fixed
  • Affects Version/s: 0.9.12
  • Fix Version/s: 0.9.14, 0.10.0
  • Component/s: Knife
  • Labels:
    None

Description

% knife status
/Users/jtimberman/Development/chef/chef/lib/chef/knife/status.rb:45:in `sort': comparison of Chef::Node with Chef::Node failed (ArgumentError)
        from /Users/jtimberman/Development/chef/chef/lib/chef/knife/status.rb:45:in `run'
        from /Users/jtimberman/Development/chef/chef/lib/chef/knife.rb:127:in `run'
        from /Users/jtimberman/Development/chef/chef/lib/chef/application/knife.rb:121:in `run'
        from bin/knife:25:in `<main>'

One of the nodes in the search results had an ohai_time of null, which caused the comparison operator in knife status to fail.

Work around is to specify the search (works in 0.9.10+) of ohai_time:

% knife status "ohai_time:*"

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Tollef Fog Heen added a comment -

This is fixed in https://github.com/tfheen/chef/tree/CHEF-1832

Show
Tollef Fog Heen added a comment - This is fixed in https://github.com/tfheen/chef/tree/CHEF-1832
Hide
Permalink
Daniel DeLeo added a comment -

Thanks Tollef! This is merged to master and the 0.9-stable branch so it will be released with 0.9.14 and 0.10.

Show
Daniel DeLeo added a comment - Thanks Tollef! This is merged to master and the 0.9-stable branch so it will be released with 0.9.14 and 0.10.

People

  • Assignee:
    Adam Jacob
    Reporter:
    Joshua Timberman [Opscode]
Vote (0)
Watch (0)

Dates

  • Created:
    Updated:
    Resolved: