Check for first-boot.json when registering a node for the first time

Details

  • Type: Improvement Improvement
  • Status: Confirmed Confirmed
  • Priority: Critical Critical
  • Resolution: Unresolved
  • Affects Version/s: 0.9.12
  • Fix Version/s: None
  • Component/s: Chef Client
  • Labels:
    None

Description

Often when we create a node initially, we pass '-j' to chef-client specifying a first-boot.json. However, chef-client already knows when it is being run for the first time, because it gets a 404 and then registers itself using the validation client. If Chef 404s finding its node object on the server, it should check to see if there is a /etc/chef/first_boot.json and use it. This should also be a configuration value; first_boot_json would probably make historical sense.

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Ash Berlin added a comment -

(I asked for this in IRC.)

I notice that all the knife bootstrap scripts have to manually add -j on the first call; I would also like this ability for my automated preseeded installed without having to deal with a first-boot script to call chef-client with -j option.

With some pointers I'd be willing to try a patch for this.

My thoughts on how this would work:

1) client.rb config value of "first_boot_json" being path to a json file.
2) if -j is on the command line this takes priority.
3) Anything else I'm missing

Show
Ash Berlin added a comment - (I asked for this in IRC.) I notice that all the knife bootstrap scripts have to manually add -j on the first call; I would also like this ability for my automated preseeded installed without having to deal with a first-boot script to call chef-client with -j option. With some pointers I'd be willing to try a patch for this. My thoughts on how this would work: 1) client.rb config value of "first_boot_json" being path to a json file. 2) if -j is on the command line this takes priority. 3) Anything else I'm missing
Hide
Permalink
Bryan McLellan [Opscode] added a comment -

From CHEF-2359:

Chef no longer saves node data at the beginning of a chef run. This behavior shouldn't change, because it keeps half-built nodes from appearing in search results (and getting added to load balancers, monitoring systems, etc.). However, when bootstrapping a node fails, users find it confusing that they need to run chef with the -j /etc/chef/first-boot.json flag.

To resolve the problem, first-boot.json should be special in the following ways:

  • It will be used automatically if it exists
  • It will be moved out of the way (e.g., to first-boot.json.bak after a successful node save

It may also be desirable to have a default JSON attribs file for chef-solo, but that's a different matter.

Show
Bryan McLellan [Opscode] added a comment - From CHEF-2359 : Chef no longer saves node data at the beginning of a chef run. This behavior shouldn't change, because it keeps half-built nodes from appearing in search results (and getting added to load balancers, monitoring systems, etc.). However, when bootstrapping a node fails, users find it confusing that they need to run chef with the -j /etc/chef/first-boot.json flag. To resolve the problem, first-boot.json should be special in the following ways: It will be used automatically if it exists It will be moved out of the way (e.g., to first-boot.json.bak after a successful node save It may also be desirable to have a default JSON attribs file for chef-solo, but that's a different matter.
Bryan McLellan [Opscode] made changes -
Field Original Value New Value
Fix Version/s 0.10.2 [ 10203 ]
Priority Trivial [ 5 ] Critical [ 2 ]
Bryan McLellan [Opscode] made changes -
Fix Version/s 0.10.4 [ 10400 ]
Fix Version/s 0.10.2 [ 10203 ]
Bryan McLellan [Opscode] made changes -
Fix Version/s 0.10.4 [ 10400 ]
Hide
Permalink
Bryan McLellan [Opscode] added a comment -

CHEF-3025 added a '-j' option to knife bootstrap for providing JSON on the command line to be merged into the first-boot.json that we put the run list in and specify in the core bootstrap templates. This may help as a workaround, but a nice solution is still probably due.

Show
Bryan McLellan [Opscode] added a comment - CHEF-3025 added a '-j' option to knife bootstrap for providing JSON on the command line to be merged into the first-boot.json that we put the run list in and specify in the core bootstrap templates. This may help as a workaround, but a nice solution is still probably due.
Bryan McLellan [Opscode] made changes -
Workflow jira [ 12704 ] New OSS [ 17390 ]
Bryan McLellan [Opscode] made changes -
Workflow New OSS [ 17390 ] OSS: Product Management [ 25868 ]
Transition Time In Source Status Execution Times Last Executer Last Execution Date
Open Open Confirmed Confirmed
684d 17h 25m 1 ${tran.lastUpdater} 14/Nov/12 1:13 PM

People

  • Assignee:
    Unassigned
    Reporter:
    Bryan McLellan [Opscode]
Vote (1)
Watch (2)

Dates

  • Created:
    Updated: