Mount provider should be able to allow "none" as a valid mountpoint

Details

  • Type: Bug Bug
  • Status: Fix Committed Fix Committed
  • Priority: Major Major
  • Resolution: Fixed
  • Affects Version/s: 0.5.1, 0.5.2, 0.5.4, 0.5.6, 0.6.0, 0.6.2, 0.7.0, 0.7.2, 0.7.4, 0.7.6, 0.7.8, 0.7.10, 0.7.12, 0.7.14, 0.7.16, 0.8.2, 0.8.4, 0.8.6, 0.8.8, 0.8.10, 0.8.12, 0.8.14, 0.8.16, 0.9.0, 0.9.2, 0.9.4, 0.9.6, 0.9.8, 0.9.10, 0.9.12
  • Fix Version/s: 11.6.0-client
  • Component/s: Chef Server
  • Labels:
    None
  • Environment:

    ubuntu-10.04

Description

I am trying to mount a swap file which requires "none" in the device section, here is the related recipe:

https://gist.github.com/c7c3c7238fb97ccca065

Then chef crashes with:

[Fri, 07 Jan 2011 19:46:45 +0000] ERROR: mount[none] (/srv/chef/cache/cookbooks/swap/recipes/default.rb:33:in `from_file') had an error:
Mount point none does not exist

This is the relevant log part:

https://gist.github.com/19d14c5f41afbc0958a2

Chef should allow "none" as a valid mountpoint.

Issue Links

relates to

Bug - A problem which impairs or prevents the functions of the product. CHEF-3372 improve handling other kinds of device types for mount provider

  • Minor - Minor loss of function, or other problem where easy workaround is present.
  • Open - The issue is open and ready for the assignee to start work on it.

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Robert J. Berger added a comment -

I second the motion. I want to be able to do the exact same thing. Its really important for t1.micro instances and other cases where you would rather swap than OOM.

Its doable without the mount resource, but the mount resource with a "none" mount point and "swap" fstype would make it easy...

Show
Robert J. Berger added a comment - I second the motion. I want to be able to do the exact same thing. Its really important for t1.micro instances and other cases where you would rather swap than OOM. Its doable without the mount resource, but the mount resource with a "none" mount point and "swap" fstype would make it easy...
Hide
Permalink
Jo Liss added a comment - - edited

As a workaround, /dev/null seems to work fine as the mount point for swap files (and, presumably, partitions). It's still not mountable, though – you have to use swapon. I have blogged about this here.

Show
Jo Liss added a comment - - edited As a workaround, /dev/null seems to work fine as the mount point for swap files (and, presumably, partitions). It's still not mountable, though – you have to use swapon. I have blogged about this here .
Hide
Permalink
Thom May added a comment -

Fixed in my pull request: https://github.com/opscode/chef/pull/745

Show
Thom May added a comment - Fixed in my pull request: https://github.com/opscode/chef/pull/745
Hide
Permalink
Bryan McLellan [Opscode] added a comment -

Merged to master, thanks Thom!

Show
Bryan McLellan [Opscode] added a comment - Merged to master, thanks Thom!

People

  • Assignee:
    Unassigned
    Reporter:
    Jacobo García López de Araujo
Vote (2)
Watch (3)

Dates

  • Created:
    Updated:
    Resolved: