The notifies syntax introduced in 0.9.10 is not implemented for subscribes

Details

  • Type: Bug Bug
  • Status: Closed Closed
  • Priority: Major Major
  • Resolution: Fixed
  • Affects Version/s: 0.9.12
  • Fix Version/s: 10.14.0
  • Component/s: Chef Client, Documentation
  • Labels:
    None

Description

remote_file keyfile do
	source "http://hudson-ci.org/debian/hudson-ci.org.key"
end

execute "apt-key add #{keyfile}" do
	action :nothing
	subscribes :run, "remote_file[#{keyfile}]", :immediately
end

results in

NoMethodError - undefined method `notifies' for "remote_file[/var/lib/hudson/hudson-ci.org.key]":String

Issue Links

is duplicated by

Improvement - An improvement or enhancement to an existing feature or task. CHEF-2806 Update "#subscribes" to support late resource binding

  • Unknown - Issue untriaged, priority unassigned or questioned
  • Closed - The issue is considered finished, the resolution is correct. Issues which are closed can be reopened.
relates to

Bug - A problem which impairs or prevents the functions of the product. CHEF-899 Service can't depend on config file that restarts service

  • Major - Major loss of function.
  • Closed - The issue is considered finished, the resolution is correct. Issues which are closed can be reopened.

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Avishai Ish-Shalom added a comment - - edited

https://github.com/avishai-ish-shalom/chef/tree/CHEF-1994

Seems silly to have two mechanisms for dispatching notifications, but I didn't want too make to many changes without a proper discussion.

Show
Avishai Ish-Shalom added a comment - - edited https://github.com/avishai-ish-shalom/chef/tree/CHEF-1994 Seems silly to have two mechanisms for dispatching notifications, but I didn't want too make to many changes without a proper discussion.
Hide
Permalink
Bryan McLellan [Opscode] added a comment -

Also of concern is that LWRPs can't be notified: CHEF-2404

Show
Bryan McLellan [Opscode] added a comment - Also of concern is that LWRPs can't be notified: CHEF-2404
Hide
Permalink
Bryan McLellan [Opscode] added a comment -

Right. We may want to upfactor the functionality of notifies. I'll try to get this some attention in Opscode, but I encourage you to start discussion on the chef-dev list about where to take this. Dan has some ideas and would surely chime in.

Show
Bryan McLellan [Opscode] added a comment - Right. We may want to upfactor the functionality of notifies. I'll try to get this some attention in Opscode, but I encourage you to start discussion on the chef-dev list about where to take this. Dan has some ideas and would surely chime in.
Hide
Permalink
Bryan McLellan [Opscode] added a comment -

IIRC, we need a patch that upfactors the notifies code so subscribes can use it as well.

Show
Bryan McLellan [Opscode] added a comment - IIRC, we need a patch that upfactors the notifies code so subscribes can use it as well.
Hide
Permalink
Daniel DeLeo added a comment -

https://github.com/opscode/chef/commit/92a9fa4443e4118579365f59358c1de2a3061d7d

Show
Daniel DeLeo added a comment - https://github.com/opscode/chef/commit/92a9fa4443e4118579365f59358c1de2a3061d7d
Hide
Permalink
Bryan McLellan [Opscode] added a comment -

The newer notification syntax that started with notifies came from CHEF-899.

Show
Bryan McLellan [Opscode] added a comment - The newer notification syntax that started with notifies came from CHEF-899 .

People

  • Assignee:
    Daniel DeLeo
    Reporter:
    John
Vote (3)
Watch (2)

Dates

  • Created:
    Updated:
    Resolved: