remote_file fails on a HTTP response "303 See Other"

Details

  • Type: Bug Bug
  • Status: Closed Closed
  • Priority: Major Major
  • Resolution: Fixed
  • Affects Version/s: 0.9.10
  • Fix Version/s: 0.10.10
  • Component/s: Chef Client
  • Labels:
    None

Description

A remote_file resource downloading a URI responding with a "303 See Other" fails.

Example: http://launchpad.net/graphite/trunk/0.9.7/+download/whisper-0.9.7.tar.gz

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Daniel DeLeo added a comment -

patch submitted: https://github.com/opscode/chef/pull/206

Show
Daniel DeLeo added a comment - patch submitted: https://github.com/opscode/chef/pull/206
Hide
Permalink
Akzhan Abdulin added a comment -

More correct way is in my fork.

https://github.com/akzhan/chef/tree/CHEF-2068

Show
Akzhan Abdulin added a comment - More correct way is in my fork. https://github.com/akzhan/chef/tree/CHEF-2068
Hide
Permalink
Bryan McLellan [Opscode] added a comment -

Marked to be merged, thanks.

Show
Bryan McLellan [Opscode] added a comment - Marked to be merged, thanks.
Hide
Permalink
Bryan McLellan [Opscode] added a comment - - edited

Also, the rest spec tests for redirection. Akzhan, could you add a 303 test and make sure the 304 exception does at is should?

Show
Bryan McLellan [Opscode] added a comment - - edited Also, the rest spec tests for redirection. Akzhan, could you add a 303 test and make sure the 304 exception does at is should?
Hide
Permalink
Bryan McLellan [Opscode] added a comment -

I cargoculted the 301 test for a 303 test and it fails. We need a passing 303 test and should have a passing 304 test for this.

Show
Bryan McLellan [Opscode] added a comment - I cargoculted the 301 test for a 303 test and it fails. We need a passing 303 test and should have a passing 304 test for this.
Hide
Permalink
Akzhan Abdulin added a comment - - edited

Brian, thanks for your feedback.

Previously my patch fixes only #api_request method.

Now I have added support of generic redirections to #run_request method.

All required specifications has been added too.

Show
Akzhan Abdulin added a comment - - edited Brian, thanks for your feedback. Previously my patch fixes only #api_request method. Now I have added support of generic redirections to #run_request method. All required specifications has been added too.
Hide
Permalink
Akzhan Abdulin added a comment -

As usually, commits placed into https://github.com/akzhan/chef/tree/CHEF-2068 branch.

Show
Akzhan Abdulin added a comment - As usually, commits placed into https://github.com/akzhan/chef/tree/CHEF-2068 branch.
Hide
Permalink
Bryan McLellan [Opscode] added a comment -

Merged to master, thanks guys.

Show
Bryan McLellan [Opscode] added a comment - Merged to master, thanks guys.

People

  • Assignee:
    Bryan McLellan [Opscode]
    Reporter:
    Darrin Eden
Vote (0)
Watch (0)

Dates

  • Created:
    Updated:
    Resolved: