knife bootstrap - search for bootstrap templates in external knife plugins

Details

Description

This will allow knife plugin authors to include custom bootstrap templates when they ship the plugins as Ruby gems.

Issue Links

is duplicated by

Bug - A problem which impairs or prevents the functions of the product. CHEF-2597 Bootstrap Template Lookup

  • Major - Major loss of function.
  • Closed - The issue is considered finished, the resolution is correct. Issues which are closed can be reopened.

Bug - A problem which impairs or prevents the functions of the product. CHEF-2808 "can't convert Array into String" in dirname

  • Major - Major loss of function.
  • Closed - The issue is considered finished, the resolution is correct. Issues which are closed can be reopened.

Bug - A problem which impairs or prevents the functions of the product. CHEF-2736 knife bootstrap should check for a bootstrap template before trying to use it.

  • Unknown - Issue untriaged, priority unassigned or questioned
  • Closed - The issue is considered finished, the resolution is correct. Issues which are closed can be reopened.

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Seth Chisamore added a comment -

Fix can be pulled from here:
https://github.com/schisamo/chef/tree/CHEF-2193

Show
Seth Chisamore added a comment - Fix can be pulled from here: https://github.com/schisamo/chef/tree/CHEF-2193
Hide
Permalink
Bryan McLellan [Opscode] added a comment -

This patch has been merged to opscode/master and will be included in the next release. Thank you for contributing to Chef!

Show
Bryan McLellan [Opscode] added a comment - This patch has been merged to opscode/master and will be included in the next release. Thank you for contributing to Chef!
Hide
Permalink
Bryan McLellan [Opscode] added a comment -

Reopening for fix version change.

Show
Bryan McLellan [Opscode] added a comment - Reopening for fix version change.
Hide
Permalink
Bryan McLellan [Opscode] added a comment -

0.10.2 was a security release, 0.10.4 is the next maintenance release.

Show
Bryan McLellan [Opscode] added a comment - 0.10.2 was a security release, 0.10.4 is the next maintenance release.
Hide
Permalink
Bryan McLellan [Opscode] added a comment -

Bulk edit: this ticket should have been previously merged for 0.10.2, but will be released in 0.10.4

Show
Bryan McLellan [Opscode] added a comment - Bulk edit: this ticket should have been previously merged for 0.10.2, but will be released in 0.10.4
Hide
Permalink
Gabe McArthur added a comment -

The original fix doesn't always seem to work (I don't understand how it ever could). The Gem#find_files, returns an array, which, when evaluated in the block in File#exists?, causes the a whole method to blow up. See here:

https://github.com/gabemc/chef/commit/509d44d6a3c732a2eaa40740c4041ae20de8e7f8

Show
Gabe McArthur added a comment - The original fix doesn't always seem to work (I don't understand how it ever could). The Gem#find_files, returns an array, which, when evaluated in the block in File#exists?, causes the a whole method to blow up. See here: https://github.com/gabemc/chef/commit/509d44d6a3c732a2eaa40740c4041ae20de8e7f8
Hide
Permalink
Seth Chisamore added a comment -

Actually the fix is much easier than that...just need to flatten the boostrap_files array:

bootstrap_files.flatten!

This fix already exists in knife-windows:
https://github.com/opscode/knife-windows/blob/master/lib/chef/knife/bootstrap_windows_base.rb#L98

Show
Seth Chisamore added a comment - Actually the fix is much easier than that...just need to flatten the boostrap_files array: bootstrap_files.flatten! This fix already exists in knife-windows: https://github.com/opscode/knife-windows/blob/master/lib/chef/knife/bootstrap_windows_base.rb#L98
Hide
Permalink
Seth Chisamore added a comment -

reopening per comments above.

Show
Seth Chisamore added a comment - reopening per comments above.
Hide
Permalink
Seth Chisamore added a comment -

Updated fix can be pulled from:
https://github.com/schisamo/chef/tree/CHEF-2193

I even wrote a spec this time to catch this in the future!

Show
Seth Chisamore added a comment - Updated fix can be pulled from: https://github.com/schisamo/chef/tree/CHEF-2193 I even wrote a spec this time to catch this in the future!
Hide
Permalink
Seth Chisamore added a comment -

this has been merged:
https://github.com/opscode/chef/commit/d9819c62a5c1d54bd186b8fef43f7bac00c1a416

Show
Seth Chisamore added a comment - this has been merged: https://github.com/opscode/chef/commit/d9819c62a5c1d54bd186b8fef43f7bac00c1a416
Hide
Permalink
Bryan McLellan [Opscode] added a comment -

Note that the final fix is in 0.10.6 and this was broken in 0.10.4

Show
Bryan McLellan [Opscode] added a comment - Note that the final fix is in 0.10.6 and this was broken in 0.10.4

People

  • Assignee:
    Seth Chisamore
    Reporter:
    Seth Chisamore
Vote (0)
Watch (0)

Dates

  • Created:
    Updated:
    Resolved: