remote_file with a url should include a type of hash option to verify the downloaded file is what we expected

Details

  • Type: Bug Bug
  • Status: Closed Closed
  • Priority: Major Major
  • Resolution: Fixed
  • Affects Version/s: 0.5.6
  • Fix Version/s: 0.6.0
  • Component/s: Chef Server
  • Labels:
    None

Description

A side effect would be that we wouldn't have to download it again either if the hash compared right.

I'm working on a patchset now.

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Caleb Tennis added a comment -

This is fixed in my CHEF-230 branch (ctennis/chef.git).

I added a checksum feature to remote_file. If you have something like this:

remote_file "/usr/foo.txt"
source "http://blah.com/foo.txt"
checksum "03d300e9"
end

If foo.txt is already on disk and you supplied a checksum (the sha256, or a partial in this case) it will do a comparison and not download the file again if it matches.

Show
Caleb Tennis added a comment - This is fixed in my CHEF-230 branch (ctennis/chef.git). I added a checksum feature to remote_file. If you have something like this: remote_file "/usr/foo.txt" source "http://blah.com/foo.txt" checksum "03d300e9" end If foo.txt is already on disk and you supplied a checksum (the sha256, or a partial in this case) it will do a comparison and not download the file again if it matches.
Hide
Permalink
Caleb Tennis added a comment -

I ran into an issue with this over the weekend, assigning back to me for more work.

Show
Caleb Tennis added a comment - I ran into an issue with this over the weekend, assigning back to me for more work.
Hide
Permalink
Caleb Tennis added a comment -

Well, now it's working well for me again. Assigning back for checking.

Show
Caleb Tennis added a comment - Well, now it's working well for me again. Assigning back for checking.
Hide
Permalink
Adam Jacob added a comment -

This has been pushed to opscode/master, with a change that uses the pre-existing checksum for the current file if it exists (which we build in Chef::Provider::File#initialize).

Can you test it out?

Show
Adam Jacob added a comment - This has been pushed to opscode/master, with a change that uses the pre-existing checksum for the current file if it exists (which we build in Chef::Provider::File#initialize). Can you test it out?
Hide
Permalink
Caleb Tennis added a comment -

Tested, and it works great for me. Thanks!

Show
Caleb Tennis added a comment - Tested, and it works great for me. Thanks!
Hide
Permalink
Adam Jacob added a comment -

Caleb, care to update the docs on the wiki?

Show
Adam Jacob added a comment - Caleb, care to update the docs on the wiki?

People

  • Assignee:
    Caleb Tennis
    Reporter:
    Caleb Tennis
Vote (0)
Watch (0)

Dates

  • Created:
    Updated:
    Resolved: