RubyGems 1.8 Gives deprecation messages

Details

  • Type: Bug Bug
  • Status: Closed Closed
  • Priority: Unknown Unknown
  • Resolution: Fixed
  • Affects Version/s: 0.10.8
  • Fix Version/s: 0.10.10
  • Component/s: Chef Client
  • Labels:
    None
  • Environment:

    RubyGems 1.8.1
    ruby 1.9.2p180 (2011-02-18 revision 30909) [x86_64-linux]
    Ubuntu 10.04.2 LTS

Description

When running the chef-client with RubyGems 1.8 the following messages appear every time gems are processed or installed:

NOTE: Gem.source_index is deprecated, use Specification. It will be removed on or after 2011-11-01.
Gem.source_index called from /usr/lib/ruby/gems/1.9.1/gems/chef-0.10.0/lib/chef/provider/package/rubygems.rb:202.
NOTE: Gem::SourceIndex#search is deprecated with no replacement. It will be removed on or after 2011-11-01.
Gem::SourceIndex#search called from /usr/lib/ruby/gems/1.9.1/gems/chef-0.10.0/lib/chef/provider/package/rubygems.rb:76.

This is after running `gem pristine --all`, which fixed many messages about other gems after this upgrade.

Issue Links

is duplicated by

Bug - A problem which impairs or prevents the functions of the product. CHEF-2587 The rubygems provider is using the deprecated Gem.source_index when chef runs with ruby gems 1.8.10

  • Unknown - Issue untriaged, priority unassigned or questioned
  • Closed - The issue is considered finished, the resolution is correct. Issues which are closed can be reopened.

Bug - A problem which impairs or prevents the functions of the product. CHEF-2696 Rubygems warning

  • Unknown - Issue untriaged, priority unassigned or questioned
  • Closed - The issue is considered finished, the resolution is correct. Issues which are closed can be reopened.

Improvement - An improvement or enhancement to an existing feature or task. CHEF-2790 Chef 0.10.6 support for rubygems 1.8

  • Minor - Minor loss of function, or other problem where easy workaround is present.
  • Closed - The issue is considered finished, the resolution is correct. Issues which are closed can be reopened.

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Brandon Philips added a comment -

I am seeing the same thing with chef 0.10.2 and ruby 1.8.7 from Lucid.

Show
Brandon Philips added a comment - I am seeing the same thing with chef 0.10.2 and ruby 1.8.7 from Lucid.
Hide
Permalink
Matthew Kent added a comment -

Same here on ruby 1.9.2 p290 and rubygems 1.8.6

Show
Matthew Kent added a comment - Same here on ruby 1.9.2 p290 and rubygems 1.8.6
Hide
Permalink
Mike Fiedler added a comment -

Still exists in chef 0.10.4

Show
Mike Fiedler added a comment - Still exists in chef 0.10.4
Hide
Permalink
Jay Feldblum added a comment -

Gem.source_index is deprecated. The rubygems provider for the package resource should try to use the newer API with Gem::Specification first, and fall back to Gem.source_index if the version of rubygems is too old.

Show
Jay Feldblum added a comment - Gem.source_index is deprecated. The rubygems provider for the package resource should try to use the newer API with Gem::Specification first, and fall back to Gem.source_index if the version of rubygems is too old.
Hide
Permalink
Matthew Kent added a comment -

Fixed in https://github.com/mdkent/chef/commits/CHEF-2328

Would appreciate any testing.

Show
Matthew Kent added a comment - Fixed in https://github.com/mdkent/chef/commits/CHEF-2328 Would appreciate any testing.
Hide
Permalink
Bryan McLellan [Opscode] added a comment -

You're the expert here now, so we're following along.

There's another fix for this on CHEF-2790. Can you explain the difference?

What is the Gem::Specification.dirs call in gem_specification?

Show
Bryan McLellan [Opscode] added a comment - You're the expert here now, so we're following along. There's another fix for this on CHEF-2790 . Can you explain the difference? What is the Gem::Specification.dirs call in gem_specification?
Hide
Permalink
Matthew Kent added a comment -

Oh neat - well Gem::Specification.dirs sets the path to load the specs from while resetting any already known specs. It definitely needs to be called because gem_paths may shell out to a different gem binary to determine it's location for installed gems.

CHEF-2790 will work for gems installed under the same rubygems chef is running under, but will fail for a different gem binary, which is why it fails 2 specs.

Show
Matthew Kent added a comment - Oh neat - well Gem::Specification.dirs sets the path to load the specs from while resetting any already known specs. It definitely needs to be called because gem_paths may shell out to a different gem binary to determine it's location for installed gems. CHEF-2790 will work for gems installed under the same rubygems chef is running under, but will fail for a different gem binary, which is why it fails 2 specs.
Hide
Permalink
Matthew Kent added a comment -

Marking as fixed for re-review.

Show
Matthew Kent added a comment - Marking as fixed for re-review.
Hide
Permalink
Ryan Davis added a comment -

I don't think this is resolved: https://github.com/opscode/chef/blob/master/chef/lib/chef/provider/package/rubygems.rb#L203

Show
Ryan Davis added a comment - I don't think this is resolved: https://github.com/opscode/chef/blob/master/chef/lib/chef/provider/package/rubygems.rb#L203
Hide
Permalink
Matthew Kent added a comment -

It's resolved as in it's fixed in my branch. opscode will close the ticket when it's merged.

Show
Matthew Kent added a comment - It's resolved as in it's fixed in my branch. opscode will close the ticket when it's merged.
Hide
Permalink
Bryan McLellan [Opscode] added a comment -

Merged to master, thanks Matthew!

Show
Bryan McLellan [Opscode] added a comment - Merged to master, thanks Matthew!

People

  • Assignee:
    Matthew Kent
    Reporter:
    Nathan L Smith
Vote (8)
Watch (13)

Dates

  • Created:
    Updated:
    Resolved: