11: Attributes set in role not available via node object when running shef in client mode.

Details

Description

An override attribute or the role is not being set when using shef 0.10.2. It is set correctly in the webui, or when using shef 0.9.18.

This is put into the attributes file:

default.order.number = 0

They then Assigned both of these roles to the same system:

order1.rb:

name "order1"
description "order1"
override_attributes "order" => {
"number" => 1 }

order2.rb:

name "order2"
description "order2"
override_attributes "order" => {
"number" => 2 }

When they run this command though, they would expect node.order.number to equal 2:

chef > node.run_list_collect{|rl| rl.name}
 => ["hax", "risk", "order1", "order2"]
chef > node.order.number
 => 0

Related ticket: http://help.opscode.com/discussions/problems/707-upgrade-to-chef-0102-causes-weird-attribute-behavior-in-shef

Issue Links

is cloned by

Bug - A problem which impairs or prevents the functions of the product. CHEF-3274 shef doesn't process attribute precedence properly

  • Minor - Minor loss of function, or other problem where easy workaround is present.
  • Closed - The issue is considered finished, the resolution is correct. Issues which are closed can be reopened.

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Steven Danna added a comment - - edited

The problem seems to be not just with override attributes but any attribute set from a role. For instance

    vagrant@ubuntu-11:~$ sudo shef -z -c /etc/chef/client.rb 
    loading configuration: /etc/chef/client.rb
    Session type: client
    Loading...[Fri, 12 Aug 2011 18:48:07 +0000] INFO: Run List is [recipe[variable-test], role[attr-tester]]
[Fri, 12 Aug 2011 18:48:07 +0000] INFO: Run List expands to [variable-test]
..[Fri, 12 Aug 2011 18:48:08 +0000] INFO: Loading cookbooks [variable-test]
done.

This is shef, the Chef shell.
 Chef Version: 0.10.4
 http://www.opscode.com/chef
 http://wiki.opscode.com/display/chef/Home

run `help' for help, `exit' or ^D to quit.

Ohai2u vagrant@ubuntu-11.04!
chef > node["test_attr2"]
 => "hobit" 
chef > nodes.show("ubuntu-11.04-sdanna")['test_attr1']
 => "frob" 
chef > node['test_attr1']
 => nil

See also, http://help.opscode.com/discussions/problems/759-inconsistent-attributes-between-chef-client-and-shef

Show
Steven Danna added a comment - - edited The problem seems to be not just with override attributes but any attribute set from a role. For instance vagrant@ubuntu-11:~$ sudo shef -z -c /etc/chef/client.rb loading configuration: /etc/chef/client.rb Session type: client Loading...[Fri, 12 Aug 2011 18:48:07 +0000] INFO: Run List is [recipe[variable-test], role[attr-tester]] [Fri, 12 Aug 2011 18:48:07 +0000] INFO: Run List expands to [variable-test] ..[Fri, 12 Aug 2011 18:48:08 +0000] INFO: Loading cookbooks [variable-test] done. This is shef, the Chef shell. Chef Version: 0.10.4 http://www.opscode.com/chef http://wiki.opscode.com/display/chef/Home run `help' for help, `exit' or ^D to quit. Ohai2u vagrant@ubuntu-11.04! chef > node["test_attr2"] => "hobit" chef > nodes.show("ubuntu-11.04-sdanna")['test_attr1'] => "frob" chef > node['test_attr1'] => nil See also, http://help.opscode.com/discussions/problems/759-inconsistent-attributes-between-chef-client-and-shef
Hide
Permalink
Tom Thomas (Inactive) added a comment -

Setting the priority was set at major due to it being an issue with the override attribute being set while attribute settings are a reasonably highly used function, that it appears to have been introduced with 10.2, and that it has arisen a couple of times with platform customers in a fairly short period. If this is an overstatement of the issue's impact, then the priority can certainly be reset to a more appropriate level.

Show
Tom Thomas (Inactive) added a comment - Setting the priority was set at major due to it being an issue with the override attribute being set while attribute settings are a reasonably highly used function, that it appears to have been introduced with 10.2, and that it has arisen a couple of times with platform customers in a fairly short period. If this is an overstatement of the issue's impact, then the priority can certainly be reset to a more appropriate level.
Hide
Permalink
Steven Danna added a comment - - edited

I think I've track this specific problem down. The problem is here:

https://github.com/opscode/chef/blob/master/chef/lib/chef/shef/shef_session.rb#L167

run_context.load calls node.apply_expansion_attributes which is ultimately responsible for loading the role and environment attributes. Unfortunately we seem to be calling this assuming the environment _default and an empty run list. Changing the above line to this:

@run_context.load(@node.run_list.expand(@node.chef_environment))

fixes the problem.

Overall, a reading of the code makes me pretty nervous that there are a number of other differences regarding initialization.

Show
Steven Danna added a comment - - edited I think I've track this specific problem down. The problem is here: https://github.com/opscode/chef/blob/master/chef/lib/chef/shef/shef_session.rb#L167 run_context.load calls node.apply_expansion_attributes which is ultimately responsible for loading the role and environment attributes. Unfortunately we seem to be calling this assuming the environment _default and an empty run list. Changing the above line to this: @run_context.load(@node.run_list.expand(@node.chef_environment)) fixes the problem. Overall, a reading of the code makes me pretty nervous that there are a number of other differences regarding initialization.
Hide
Permalink
Steven Danna added a comment -

Note that the line I linked to above is not where that line needs to go. I think the correct line is https://github.com/opscode/chef/blob/master/chef/lib/chef/shef/shef_session.rb#L206

Show
Steven Danna added a comment - Note that the line I linked to above is not where that line needs to go. I think the correct line is https://github.com/opscode/chef/blob/master/chef/lib/chef/shef/shef_session.rb#L206
Hide
Permalink
Joshua Yanovski added a comment -

Is this going to be fixed anytime soon? It makes testing changes in attribute application rather difficult. https://github.com/opscode/chef/blob/master/chef/lib/chef/shell/shell_session.rb#L208 is the new location.

Show
Joshua Yanovski added a comment - Is this going to be fixed anytime soon? It makes testing changes in attribute application rather difficult. https://github.com/opscode/chef/blob/master/chef/lib/chef/shell/shell_session.rb#L208 is the new location.
Hide
Permalink
Steven Danna added a comment -

https://github.com/stevendanna/chef/tree/CHEF-2467

Show
Steven Danna added a comment - https://github.com/stevendanna/chef/tree/CHEF-2467
Hide
Permalink
Bryan McLellan [Opscode] added a comment -

Add tests please Mr. Danna.

Show
Bryan McLellan [Opscode] added a comment - Add tests please Mr. Danna.
Hide
Permalink
Steven Danna added a comment -

https://github.com/stevendanna/chef/compare/CHEF-2467

I've added a commit with some code in a spec file. If someone has a better way to test this method I'll happily make edits.

Show
Steven Danna added a comment - https://github.com/stevendanna/chef/compare/CHEF-2467 I've added a commit with some code in a spec file. If someone has a better way to test this method I'll happily make edits.
Hide
Permalink
Tim Smith added a comment -

Any chance this is going to make it into the 10 branch. This bug drives me nuts

Show
Tim Smith added a comment - Any chance this is going to make it into the 10 branch. This bug drives me nuts
Hide
Permalink
Bryan McLellan [Opscode] added a comment -

Merged to master, cherry-picked to 10-stable.

Show
Bryan McLellan [Opscode] added a comment - Merged to master, cherry-picked to 10-stable.

People

  • Assignee:
    Steven Danna
    Reporter:
    Jessica Bourne
Vote (6)
Watch (10)

Dates

  • Created:
    Updated:
    Resolved: