chef-solr configs are packed within tar.gz

Details

  • Type: Bug Bug
  • Status: Closed Closed
  • Priority: Major Major
  • Resolution: Fixed
  • Affects Version/s: None
  • Fix Version/s: 0.10.6
  • Component/s: None
  • Labels:
    None

Description

Trying to fix CHEF-2346 but illustrating my change is difficult due to the configs being packed in chef-solr/solr/solr-home.tar.gz and chef-solr/solr/solr-jetty.tar.gz.

Issue Links

is duplicated by

Bug - A problem which impairs or prevents the functions of the product. CHEF-2973 undefined method `collect' in check_server_side_cookbooks

  • Major - Major loss of function.
  • Closed - The issue is considered finished, the resolution is correct. Issues which are closed can be reopened.

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Matthew Kent added a comment -

Proposed solution in https://github.com/mdkent/chef/commits/CHEF-2553

Took the approach of creating a tar_solr rake task that's a prerequisite to rake gem (and thus rake package). I dropped the files from the gemspec and add them dynamically.

One issue I see with this approach is that gem build chef-solr.gemspec won't produce a complete package as it's not using rake. Not sure about the idea of putting ruby in the gemspec but it could bail out if $0 == "gem" or otherwise produce a warning. Still seems an improvement over the current situation though.

Show
Matthew Kent added a comment - Proposed solution in https://github.com/mdkent/chef/commits/CHEF-2553 Took the approach of creating a tar_solr rake task that's a prerequisite to rake gem (and thus rake package). I dropped the files from the gemspec and add them dynamically. One issue I see with this approach is that gem build chef-solr.gemspec won't produce a complete package as it's not using rake. Not sure about the idea of putting ruby in the gemspec but it could bail out if $0 == "gem" or otherwise produce a warning. Still seems an improvement over the current situation though.
Matthew Kent made changes -
Field Original Value New Value
Status Open [ 1 ] Resolved [ 5 ]
Fix Version/s 0.10.6 [ 10403 ]
Resolution Fixed [ 1 ]
Bryan McLellan [Opscode] made changes -
Triage Status [Triaged]
Hide
Permalink
Bryan McLellan [Opscode] added a comment -

Merged to opscode/master. Thanks Matthew!

Note to future selves: this is a pretty big build change and we need to be wary of the result.

Show
Bryan McLellan [Opscode] added a comment - Merged to opscode/master. Thanks Matthew! Note to future selves: this is a pretty big build change and we need to be wary of the result.
Bryan McLellan [Opscode] made changes -
Status Resolved [ 5 ] Closed [ 6 ]
Hide
Permalink
Matthew Kent added a comment -

From IRC: chef-solr.gemspec is broken now, it specifies chef-solr-rebuild which was removed in CHEF-2530.

Please pull from https://github.com/mdkent/chef/commits/CHEF-2553-gemspec

Show
Matthew Kent added a comment - From IRC: chef-solr.gemspec is broken now, it specifies chef-solr-rebuild which was removed in CHEF-2530 . Please pull from https://github.com/mdkent/chef/commits/CHEF-2553-gemspec
Matthew Kent made changes -
Resolution Fixed [ 1 ]
Status Closed [ 6 ] Reopened [ 4 ]
Matthew Kent made changes -
Status Reopened [ 4 ] Resolved [ 5 ]
Resolution Fixed [ 1 ]
Hide
Permalink
Daniel DeLeo added a comment -

Merged the gemspec fix. Thanks again!

Show
Daniel DeLeo added a comment - Merged the gemspec fix. Thanks again!
Daniel DeLeo made changes -
Status Resolved [ 5 ] Closed [ 6 ]
Bryan McLellan [Opscode] made changes -
Link This issue is duplicated by CHEF-2973 [ CHEF-2973 ]
Bryan McLellan [Opscode] made changes -
Workflow jira [ 14210 ] New OSS [ 20180 ]
Bryan McLellan [Opscode] made changes -
Workflow New OSS [ 20180 ] OSS: Product Management [ 28094 ]
Transition Time In Source Status Execution Times Last Executer Last Execution Date
Open Open Resolved Resolved
1h 44m 1 Matthew Kent 17/Aug/11 7:19 PM
Closed Closed Reopened Reopened
3d 16h 36m 1 Matthew Kent 14/Oct/11 3:14 PM
Reopened Reopened Resolved Resolved
9s 1 Matthew Kent 14/Oct/11 3:14 PM
Resolved Resolved Closed Closed
66d 9h 2m 2 Daniel DeLeo 26/Oct/11 8:59 PM

People

  • Assignee:
    Matthew Kent
    Reporter:
    Matthew Kent
Vote (0)
Watch (1)

Dates

  • Created:
    Updated:
    Resolved: