remote_directory fails trying to purge a non-empty directory

Details

Description

remote_directory fails trying to purge a non-empty directory
remote_directory fails if "purge" is set to true and the destination directory is not empty. e.g.
trying to copy to 

A
|_B
  |_C

fails stating "B" is not empty. The failure is primarily because Directory.rm does not force delete.
FileUtils.rm_rf may be a better bet.

Issue Links

is duplicated by

Bug - A problem which impairs or prevents the functions of the product. CHEF-3028 remote_directory purge fails with managed folders only containing folders

  • Unknown - Issue untriaged, priority unassigned or questioned
  • Closed - The issue is considered finished, the resolution is correct. Issues which are closed can be reopened.

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Prashant Srivastava added a comment -

Damn you wiki markup!
The folder structure intended was

A -> B -> C

Show
Prashant Srivastava added a comment - Damn you wiki markup! The folder structure intended was A -> B -> C
Hide
Permalink
Laurent Désarmes added a comment -

confirmed here. it fails with the directory resource attribute recursive set to true as well.

Show
Laurent Désarmes added a comment - confirmed here. it fails with the directory resource attribute recursive set to true as well.
Hide
Permalink
Laurent Désarmes added a comment -

proposed fix in llaurent/CHEF-2599

Show
Laurent Désarmes added a comment - proposed fix in llaurent/ CHEF-2599
Hide
Permalink
Laurent Désarmes added a comment -

i haven't fixed it by forcing the rmdir.

A/B/C/file being in the remote directory
the provider was only removing A/B/C and A/B/C/file from the purge_list.
the fix i propose also removes A/B and A from the purge list.
If A/B/C/file is in the remote directory, there's no reason for the provider to remove A (or A/B)

Can you confirm it really fixes the issue you're having ?

Show
Laurent Désarmes added a comment - i haven't fixed it by forcing the rmdir. A/B/C/file being in the remote directory the provider was only removing A/B/C and A/B/C/file from the purge_list. the fix i propose also removes A/B and A from the purge list. If A/B/C/file is in the remote directory, there's no reason for the provider to remove A (or A/B) Can you confirm it really fixes the issue you're having ?
Hide
Permalink
Bryan McLellan [Opscode] added a comment -

This should of course be tested, but we also should really have a unit test to verify and protect against regression here.

Show
Bryan McLellan [Opscode] added a comment - This should of course be tested, but we also should really have a unit test to verify and protect against regression here.
Hide
Permalink
Laurent Désarmes added a comment -

Ok, i've updated llaurent/CHEF-2599 with a simple testcase, that's enough to fail 2 existing tests.
https://github.com/llaurent/chef/commits/CHEF-2599/

Show
Laurent Désarmes added a comment - Ok, i've updated llaurent/ CHEF-2599 with a simple testcase, that's enough to fail 2 existing tests. https://github.com/llaurent/chef/commits/CHEF-2599/
Hide
Permalink
Laurent Désarmes added a comment -

i'm resolving it, i don't want it to be missed

Show
Laurent Désarmes added a comment - i'm resolving it, i don't want it to be missed
Hide
Permalink
Bryan McLellan [Opscode] added a comment -

Marked to be merged.

Show
Bryan McLellan [Opscode] added a comment - Marked to be merged.
Hide
Permalink
Bryan McLellan [Opscode] added a comment -

Merged to master, thanks Laurent!

Show
Bryan McLellan [Opscode] added a comment - Merged to master, thanks Laurent!

People

  • Assignee:
    Laurent Désarmes
    Reporter:
    Prashant Srivastava
Vote (1)
Watch (2)

Dates

  • Created:
    Updated:
    Resolved: