subversion provider doesn't handle underlying return codes

Details

  • Type: Bug Bug
  • Status: Open Open
  • Priority: Unknown Unknown
  • Resolution: Unresolved
  • Affects Version/s: 0.10.4
  • Fix Version/s: None
  • Component/s: None
  • Labels:
  • Environment:

    Windows 7 executing under PowerShell

Description

subversion[CouchDB From SVN] (subversion::default line /Users/Opscode/.chef/cache/cookbooks/subversion/recipes/default.r
b) had an error:  returned 42, expected 0
C:/opscode/chef/embedded/lib/ruby/gems/1.9.1/gems/chef-0.10.6.beta.2/lib/chef/mixin/command.rb:185:in `handle_command_fa
ilures'
C:/opscode/chef/embedded/lib/ruby/gems/1.9.1/gems/chef-0.10.6.beta.2/lib/chef/provider/subversion.rb:115:in `revision_in
t'
C:/opscode/chef/embedded/lib/ruby/gems/1.9.1/gems/chef-0.10.6.beta.2/lib/chef/provider/subversion.rb:91:in `checkout_com
mand'
C:/opscode/chef/embedded/lib/ruby/gems/1.9.1/gems/chef-0.10.6.beta.2/lib/chef/provider/subversion.rb:44:in `action_check
out'
C:/opscode/chef/embedded/lib/ruby/gems/1.9.1/gems/chef-0.10.6.beta.2/lib/chef/provider/subversion.rb:78:in `action_sync'

C:/opscode/chef/embedded/lib/ruby/gems/1.9.1/gems/chef-0.10.6.beta.2/lib/chef/resource.rb:440:in `run_action'
C:/opscode/chef/embedded/lib/ruby/gems/1.9.1/gems/chef-0.10.6.beta.2/lib/chef/runner.rb:45:in `run_action'
C:/opscode/chef/embedded/lib/ruby/gems/1.9.1/gems/chef-0.10.6.beta.2/lib/chef/runner.rb:81:in `block (2 levels) in conve
rge'
C:/opscode/chef/embedded/lib/ruby/gems/1.9.1/gems/chef-0.10.6.beta.2/lib/chef/runner.rb:81:in `each'
C:/opscode/chef/embedded/lib/ruby/gems/1.9.1/gems/chef-0.10.6.beta.2/lib/chef/runner.rb:81:in `block in converge'
C:/opscode/chef/embedded/lib/ruby/gems/1.9.1/gems/chef-0.10.6.beta.2/lib/chef/resource_collection.rb:94:in `block in exe
cute_each_resource'
C:/opscode/chef/embedded/lib/ruby/gems/1.9.1/gems/chef-0.10.6.beta.2/lib/chef/resource_collection/stepable_iterator.rb:1
16:in `call'
C:/opscode/chef/embedded/lib/ruby/gems/1.9.1/gems/chef-0.10.6.beta.2/lib/chef/resource_collection/stepable_iterator.rb:1
16:in `call_iterator_block'
C:/opscode/chef/embedded/lib/ruby/gems/1.9.1/gems/chef-0.10.6.beta.2/lib/chef/resource_collection/stepable_iterator.rb:8
5:in `step'
C:/opscode/chef/embedded/lib/ruby/gems/1.9.1/gems/chef-0.10.6.beta.2/lib/chef/resource_collection/stepable_iterator.rb:1
04:in `iterate'
C:/opscode/chef/embedded/lib/ruby/gems/1.9.1/gems/chef-0.10.6.beta.2/lib/chef/resource_collection/stepable_iterator.rb:5
5:in `each_with_index'
C:/opscode/chef/embedded/lib/ruby/gems/1.9.1/gems/chef-0.10.6.beta.2/lib/chef/resource_collection.rb:92:in `execute_each
_resource'
C:/opscode/chef/embedded/lib/ruby/gems/1.9.1/gems/chef-0.10.6.beta.2/lib/chef/runner.rb:76:in `converge'
C:/opscode/chef/embedded/lib/ruby/gems/1.9.1/gems/chef-0.10.6.beta.2/lib/chef/client.rb:312:in `converge'
C:/opscode/chef/embedded/lib/ruby/gems/1.9.1/gems/chef-0.10.6.beta.2/lib/chef/client.rb:160:in `run'
C:/opscode/chef/embedded/lib/ruby/gems/1.9.1/gems/chef-0.10.6.beta.2/lib/chef/application/client.rb:239:in `block in run
_application'
C:/opscode/chef/embedded/lib/ruby/gems/1.9.1/gems/chef-0.10.6.beta.2/lib/chef/application/client.rb:229:in `loop'
C:/opscode/chef/embedded/lib/ruby/gems/1.9.1/gems/chef-0.10.6.beta.2/lib/chef/application/client.rb:229:in `run_applicat
ion'
C:/opscode/chef/embedded/lib/ruby/gems/1.9.1/gems/chef-0.10.6.beta.2/lib/chef/application.rb:67:in `run'
C:/opscode/chef/embedded/lib/ruby/gems/1.9.1/gems/chef-0.10.6.beta.2/bin/chef-client:26:in `<top (required)>'
C:/opscode/chef/bin/chef-client:19:in `load'
C:/opscode/chef/bin/chef-client:19:in `<main>'
ERROR: Running exception handlers
FATAL: Saving node information to C:/Users/Opscode/.chef/cache/failed-run-data.json
ERROR: Exception handlers complete
FATAL: Stacktrace dumped to C:/Users/Opscode/.chef/cache/chef-stacktrace.out
FATAL: Chef::Exceptions::Exec: subversion[CouchDB From SVN] (subversion::default line /Users/Opscode/.chef/cache/cookboo
ks/subversion/recipes/default.rb) had an error:  returned 42, expected 0
PS C:\Users\Opscode\chef-repo>
PS C:\Users\Opscode\chef-repo> svn info http://svn.apache.org/repos/asf/couchdb/trunk --no-auth-cache  -rHEAD
Path: trunk
URL: http://svn.apache.org/repos/asf/couchdb/trunk
Repository Root: http://svn.apache.org/repos/asf
Repository UUID: 13f79535-47bb-0310-9956-ffa450edef68
Revision: 1197250
Node Kind: directory
Last Changed Author: randall
Last Changed Rev: 1177890
Last Changed Date: 2011-09-30 20:19:05 -0700 (Fri, 30 Sep 2011)

PS C:\Users\Opscode\chef-repo> $LASTEXITCODE
0

Issue Links

relates to

Bug - A problem which impairs or prevents the functions of the product. CHEF-2528 Execute Provider is passing thorough bad exist code 42

  • Minor - Minor loss of function, or other problem where easy workaround is present.
  • Closed - The issue is considered finished, the resolution is correct. Issues which are closed can be reopened.

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Joshua Timberman [Opscode] added a comment -

Resource from the recipe:

subversion "CouchDB From SVN" do
  repository "http://svn.apache.org/repos/asf/couchdb/trunk"
  revision "HEAD"
  destination "/opt/mysources/couch"
  action :sync
end
Show
Joshua Timberman [Opscode] added a comment - Resource from the recipe: subversion "CouchDB From SVN" do repository "http: //svn.apache.org/repos/asf/couchdb/trunk" revision "HEAD" destination "/opt/mysources/couch" action :sync end
Hide
Permalink
Brent Smith added a comment -

I encountered the same situation (error code 42 returned from a successful svn export under windows shell). Is there a workaround or resolution to this issue?

Show
Brent Smith added a comment - I encountered the same situation (error code 42 returned from a successful svn export under windows shell). Is there a workaround or resolution to this issue?
Hide
Permalink
Bryan McLellan [Opscode] added a comment -

One workaround would be to use an execute provider with the straight svn command.

Show
Bryan McLellan [Opscode] added a comment - One workaround would be to use an execute provider with the straight svn command.
Hide
Permalink
Brent Smith added a comment -

Thanks Bryan - that's exactly what I wound up doing. I just wondered if anything had been done/is in progress to make the subversion provider handle it more elegantly.

Show
Brent Smith added a comment - Thanks Bryan - that's exactly what I wound up doing. I just wondered if anything had been done/is in progress to make the subversion provider handle it more elegantly.
Hide
Permalink
Bryan McLellan [Opscode] added a comment -

It's the underlying process code that is at fault. Have you tried this on 0.10.8? We suspect the improved Win32 API code in 0.10.8 or in the forked mixlib-shellout that will be used in 0.10.10 will likely resolve these.

Show
Bryan McLellan [Opscode] added a comment - It's the underlying process code that is at fault. Have you tried this on 0.10.8? We suspect the improved Win32 API code in 0.10.8 or in the forked mixlib-shellout that will be used in 0.10.10 will likely resolve these.
Hide
Permalink
David Leaver added a comment - - edited

Still broken on latest chef 10.12.0

It did work on our old 0.10.2 nodes, we have a whole lot of subversion blocks in our recipes now, so replacing them all would be a big hassle.

I've hacked around it for now by changing c:\opscode\chef\embedded\lib\ruby\gems\1.9.1\gems\chef-10.12.0\lib\chef\mixin\command.rb:120 to
unless Array[opts[:returns], 42].include?(status.exitstatus)

Running the svn command and doing "echo %errorlevel" returns 0 in a command prompt. So I'm not sure where the 42 is coming from
Possibly relevant:
https://groups.google.com/forum/?fromgroups#!topic/harbour-users/O807iruSxgo
http://support.microsoft.com/kb/238245

"The return value is the instance handle of the application that was opened or printed, if the function is successful. (This handle could also be the handle of a DDE server application.) A return value less than or equal to 32 specifies an error."

Show
David Leaver added a comment - - edited Still broken on latest chef 10.12.0 It did work on our old 0.10.2 nodes, we have a whole lot of subversion blocks in our recipes now, so replacing them all would be a big hassle. I've hacked around it for now by changing c:\opscode\chef\embedded\lib\ruby\gems\1.9.1\gems\chef-10.12.0\lib\chef\mixin\command.rb:120 to unless Array[opts [:returns] , 42].include?(status.exitstatus) Running the svn command and doing "echo %errorlevel" returns 0 in a command prompt. So I'm not sure where the 42 is coming from Possibly relevant: https://groups.google.com/forum/?fromgroups#!topic/harbour-users/O807iruSxgo http://support.microsoft.com/kb/238245 "The return value is the instance handle of the application that was opened or printed, if the function is successful. (This handle could also be the handle of a DDE server application.) A return value less than or equal to 32 specifies an error."

People

  • Assignee:
    Unassigned
    Reporter:
    Joshua Timberman [Opscode]
Vote (4)
Watch (4)

Dates

  • Created:
    Updated: