New shell out does not support paths with spaces in the exe name

Details

  • Type: Bug Bug
  • Status: Closed Closed
  • Priority: Major Major
  • Resolution: Won't Fix
  • Affects Version/s: 0.10.6
  • Fix Version/s: None
  • Component/s: Chef Client
  • Labels:
    None
  • Environment:

    chef 10.6 beta 3

Description

If you try to execute say something in "C:\Program Files\something\something.exe" with quotes, the current implementation detects the executable program as "C:\Program" when it should be the entire bit enclosed in quoted.

See my comment below for the line below for more information.
https://github.com/opscode/chef/commit/2efbafeae9ec09a7f7f8c77009bd6994d7706b03#chef/lib/chef/shell_out/windows.rb-P23

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
John Keiser added a comment - - edited

Thanks for bringing this up. After much deliberation, we're leaving the new behavior in 0.10.6. Our old behavior (searching through the command line looking for a valid command) was consistent with Ruby 1.8, but not with the command line (cmd.exe) or with Ruby 1.9. We strive to go with the principle of least surprise, so we're picking the new behavior that is consistent with the command line (and which also happens to be more secure).

The new behavior requires quotes around the program name, so you can modify the recipe like so to make it work (and the quotes are backwards compatible, so you should be able do it even before you upgrade Chef):

execute '"C:\\Program Files\\My Program\\The Program.exe"'

I hope it doesn't cause too much churn for you.

Show
John Keiser added a comment - - edited Thanks for bringing this up. After much deliberation, we're leaving the new behavior in 0.10.6. Our old behavior (searching through the command line looking for a valid command) was consistent with Ruby 1.8, but not with the command line (cmd.exe) or with Ruby 1.9. We strive to go with the principle of least surprise, so we're picking the new behavior that is consistent with the command line (and which also happens to be more secure). The new behavior requires quotes around the program name, so you can modify the recipe like so to make it work (and the quotes are backwards compatible, so you should be able do it even before you upgrade Chef): execute '"C:\\Program Files\\My Program\\The Program.exe"' I hope it doesn't cause too much churn for you.
John Keiser made changes -
Field Original Value New Value
Status Open [ 1 ] Resolved [ 5 ]
Resolution Won't Fix [ 2 ]
Bryan McLellan [Opscode] made changes -
Status Resolved [ 5 ] Closed [ 6 ]
Bryan McLellan [Opscode] made changes -
Workflow jira [ 14635 ] New OSS [ 20270 ]
Bryan McLellan [Opscode] made changes -
Comment [ Note: the carriage returns in the execute line above are supposed to be double backslashes. /me is still learning Jira's quirks. ]
Bryan McLellan [Opscode] made changes -
Workflow New OSS [ 20270 ] OSS: Product Management [ 28184 ]
Transition Time In Source Status Execution Times Last Executer Last Execution Date
Open Open Resolved Resolved
5d 5h 43m 1 John Keiser 17/Nov/11 10:24 PM
Resolved Resolved Closed Closed
51m 55s 1 Bryan McLellan [Opscode] 17/Nov/11 11:16 PM

People

  • Assignee:
    Unassigned
    Reporter:
    Paul Morton
Vote (0)
Watch (1)

Dates

  • Created:
    Updated:
    Resolved: