single quotes in git commit cause 'knife cookbook site install' to fail on windows

Details

  • Type: Bug Bug
  • Status: Closed Closed
  • Priority: Major Major
  • Resolution: Fixed
  • Affects Version/s: 0.10.6
  • Fix Version/s: 0.10.10
  • Component/s: Knife
  • Labels:

Description

On Windows systems, using knife cookbook site install fails due to the single quote usage in the git commit command.

C:/opscode/chef/embedded/lib/ruby/gems/1.9.1/gems/chef-0.10.6.rc.4/lib/chef/shell_out.rb:206:in `invalid!': Expected pro
cess to exit with [0], but received '1' (Chef::Exceptions::ShellCommandFailed)
---- Begin output of git commit -m 'Import apt version 1.2.0' -- apt ----
STDOUT: C:\Users\Opscode\chef-repo-git-test\cookbooks>@git.exe %*

Changing the single quotes to double quotes resolves the issue.

Issue Links

is duplicated by

Bug - A problem which impairs or prevents the functions of the product. CHEF-2623 Using knife on windows to manipulate cookbooks doesn't work

  • Unknown - Issue untriaged, priority unassigned or questioned
  • Closed - The issue is considered finished, the resolution is correct. Issues which are closed can be reopened.

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
jtimberman added a comment -

Fixed in jtimberman/CHEF-2773

Show
jtimberman added a comment - Fixed in jtimberman/ CHEF-2773
Hide
Permalink
jtimberman added a comment -

This can be worked around by running the git commit command w/ double quotes after it fails (similar to the output in the description).

git commit -m "Import apt version 1.2.0"
Show
jtimberman added a comment - This can be worked around by running the git commit command w/ double quotes after it fails (similar to the output in the description). git commit -m "Import apt version 1.2.0"
Hide
Permalink
Bryan McLellan [Opscode] added a comment -

bulk change fix_version to 0.10.10

Show
Bryan McLellan [Opscode] added a comment - bulk change fix_version to 0.10.10
Hide
Permalink
Bryan McLellan [Opscode] added a comment -

This was fixed by John Keiser in 8e57a383 and is in master.

Show
Bryan McLellan [Opscode] added a comment - This was fixed by John Keiser in 8e57a383 and is in master.

People

  • Assignee:
    jtimberman
    Reporter:
    jtimberman
Vote (0)
Watch (0)

Dates

  • Created:
    Updated:
    Resolved: