Shef fails when "node.fqdn" is not set

Details

  • Type: Bug Bug
  • Status: Closed Closed
  • Priority: Unknown Unknown
  • Resolution: Fixed
  • Affects Version/s: None
  • Fix Version/s: 0.10.10
  • Component/s: Chef Shell
  • Labels:
    None

Description

When you run a `shef --client` command on a node which has no `node.fqdn`, the session fails with: "ArgumentError: Attribute fqdn is not defined", because the relevant code in the "greting" method rescues NameError only.

This pull request on Github contains the necessary fix:

https://github.com/opscode/chef/pull/201

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Bryan McLellan [Opscode] added a comment -

Should shef require ohai data when not running in client mode? Maybe not. Daniel DeLeo would have a good idea. CHEF-1645 is relevant.

Show
Bryan McLellan [Opscode] added a comment - Should shef require ohai data when not running in client mode? Maybe not. Daniel DeLeo would have a good idea. CHEF-1645 is relevant.
Hide
Permalink
Karel Minarik added a comment -

The relevant patch is at https://github.com/opscode/chef/pull/201

Show
Karel Minarik added a comment - The relevant patch is at https://github.com/opscode/chef/pull/201
Hide
Permalink
Bryan McLellan [Opscode] added a comment -

Thanks Karel, merged to master!

Show
Bryan McLellan [Opscode] added a comment - Thanks Karel, merged to master!

People

  • Assignee:
    Unassigned
    Reporter:
    Karel Minarik
Vote (0)
Watch (0)

Dates

  • Created:
    Updated:
    Resolved: