Can't read the cookbook path in windows with double quotes

Details

  • Type: Bug Bug
  • Status: Confirmed Confirmed
  • Priority: Minor Minor
  • Resolution: Unresolved
  • Affects Version/s: 0.10.6
  • Fix Version/s: 11.14.0-client
  • Component/s: Chef Client
  • Labels:
    None
  • Environment:

    Windows 2003, could effect Windows 2008 and 7 if they move their cookbook path from defaults

Description

This was not a bug in 10.4. In Windows 2003, due to the spaces in the cookbook path in the knife.rb it is read incorrectly if using double quotes. The cookbook path we tell people to use is ["#{ENV['HOME']}/chef-repo/cookbooks"] which does not work and gives this error:

C:\Documents and Settings\Administrator\chef-repo>knife cookbook upload getting-started
Uploading getting-started             [0.3.0]
FATAL: Cookbook file attributes/default.rb has a ruby syntax error:
FATAL: ruby: No such file or directory -- C:/Documents (LoadError)

Using these paths also did not work:

cookbook_path "\"#{ENV['HOME']}/chef-repo/cookbooks\""
cookbook_path File.join(ENV['HOME'], 'chef-repo/cookbooks')

This also didn't work:

current_dir = File.dirname(__FILE__)
cookbook_path ["#{current_dir}/../cookbooks"]

The only paths that worked were:

cookbook_path ['C:\Documents and Settings\Administrator\chef-repo\cookbooks']
cookbook_path "#{ENV['HOME']}/chef-repo/cookbooks".gsub(::File::SEPARATOR, ::File::ALT_SEPARATOR)

This issue does not seem to effect the client.rb, Windows 2003 is able to read the client_key "#{ENV['HOME']}/chef-repo/client.pem" line in it without issues.

Issue Links

is duplicated by

Bug - A problem which impairs or prevents the functions of the product. CHEF-4412 knife cookbook upload can't handle cookbook_path with spaces in the name

  • Major - Major loss of function.
  • Closed - The issue is considered finished, the resolution is correct. Issues which are closed can be reopened.

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Jessica Bourne added a comment - - edited

This could be related to this bug, which was closed as wont fix: CHEF-2725

Show
Jessica Bourne added a comment - - edited This could be related to this bug, which was closed as wont fix: CHEF-2725
Hide
Permalink
Joseph Anthony Pasquale Holsten added a comment -

While the behavior in CHEF-2725 makes sense for execution, it's crazy for file paths.

Anyone working on this?

Show
Joseph Anthony Pasquale Holsten added a comment - While the behavior in CHEF-2725 makes sense for execution, it's crazy for file paths. Anyone working on this?
Hide
Permalink
Scott Loveland added a comment -

Same error on Windows XP, except neither of the suggested cookbook_path approaches works. The only one that works is
cookbook_path '~/chef-repo/cookbooks'

Show
Scott Loveland added a comment - Same error on Windows XP, except neither of the suggested cookbook_path approaches works. The only one that works is cookbook_path '~/chef-repo/cookbooks'
Hide
Permalink
Steve McQuaid added a comment - - edited

I am new to chef, but I was able to find this bug and would like a submit a diff to contribute. Would someone be able to email me/chat and we can step thru how to get the patch out there? steve@stevemcquaid.com

The fix is just due to ruby's interpretation of double quotes in the chef-repo/.chef/knife.rb file. We want cookbook_path to be literally interpreted not processed by ruby. To get this to work for the issue, just change cookbook_path in knife.rb to use single quotes. This was only tested on a mac which was throwing the same error. This fix worked for me.

The long-term patch should involve modifying the templated generator when installing chef/initing the directory.

Hope it helps! Cheers!

Show
Steve McQuaid added a comment - - edited I am new to chef, but I was able to find this bug and would like a submit a diff to contribute. Would someone be able to email me/chat and we can step thru how to get the patch out there? steve@stevemcquaid.com The fix is just due to ruby's interpretation of double quotes in the chef-repo/.chef/knife.rb file. We want cookbook_path to be literally interpreted not processed by ruby. To get this to work for the issue, just change cookbook_path in knife.rb to use single quotes. This was only tested on a mac which was throwing the same error. This fix worked for me. The long-term patch should involve modifying the templated generator when installing chef/initing the directory. Hope it helps! Cheers!
Hide
Permalink
Jason Mennard added a comment - - edited

I know this thread is old, but I searched all over for a solution to this problem with no success. However, with a little experimentation I was able to figure out the syntax for "cookbook_path" in a Windows knife.rb. (I am using Windows 7)

I tried it with the relative and absolute paths and it wouldn't work. While I was experimenting with a relative path I generated a cookbook using knife and it created it in C:\cookbook\. Then I checked my path from the cmd window and it said:

/c/Users/<User>/chef-repo

So I figured I could use an absolute path of '/c/Users/<User>/chef-repo/cookbooks' but that created a dir called C:\c\ where the cookbook was generated. So that led me to the following solution:

cookbook_path ['/Users/<User>/chef-repo/cookbooks']

For whatever reason it won't accept the drive letter for this and it assumes you are using the C:\ drive. If you installed to a different drive letter I suspect you are SOL.

Show
Jason Mennard added a comment - - edited I know this thread is old, but I searched all over for a solution to this problem with no success. However, with a little experimentation I was able to figure out the syntax for "cookbook_path" in a Windows knife.rb. (I am using Windows 7) I tried it with the relative and absolute paths and it wouldn't work. While I was experimenting with a relative path I generated a cookbook using knife and it created it in C:\cookbook\. Then I checked my path from the cmd window and it said: /c/Users/<User>/chef-repo So I figured I could use an absolute path of '/c/Users/<User>/chef-repo/cookbooks' but that created a dir called C:\c\ where the cookbook was generated. So that led me to the following solution: cookbook_path ['/Users/<User>/chef-repo/cookbooks'] For whatever reason it won't accept the drive letter for this and it assumes you are using the C:\ drive. If you installed to a different drive letter I suspect you are SOL.

People

  • Assignee:
    Opscode Client Issues
    Reporter:
    Jessica Bourne
Vote (2)
Watch (5)

Dates

  • Created:
    Updated: