cleanup DeepMerge usage and features

Details

  • Type: Improvement Improvement
  • Status: Closed Closed
  • Priority: Minor Minor
  • Resolution: Fixed
  • Affects Version/s: 0.10.8
  • Fix Version/s: 0.10.10
  • Component/s: None
  • Labels:
    None

Description

Take the portions of the work done in CHEF-2737 that can be used to cleanup and improve the usage and features of the current DeepMerge mixin.

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Matthew Kent added a comment -

Cleanup DeepMerge by

  • Support duplicating of nested Mashes and Arrays.
  • Disabling knockout_prefix usage for non role merges as they don't work properly (CHEF-2737).
  • Enable knockout_prefix for inherited role merges only. Preserving the existing working behaviour for now. This will likely go away in the future.
  • Duplicate source and dest prior to the merge rather than modifying in place which is difficult to debug with nested arrays and mashes. Less chance of future bugs.
  • In addition to "!merge:" to knockout an entire array, support the less awkward "!merge" variant.
  • Big spec rewrite to test with !merge and account for these changes.

Improvements in https://github.com/mdkent/chef/commits/CHEF-2818

Show
Matthew Kent added a comment - Cleanup DeepMerge by Support duplicating of nested Mashes and Arrays. Disabling knockout_prefix usage for non role merges as they don't work properly ( CHEF-2737 ). Enable knockout_prefix for inherited role merges only. Preserving the existing working behaviour for now. This will likely go away in the future. Duplicate source and dest prior to the merge rather than modifying in place which is difficult to debug with nested arrays and mashes. Less chance of future bugs. In addition to "!merge:" to knockout an entire array, support the less awkward "!merge" variant. Big spec rewrite to test with !merge and account for these changes. Improvements in https://github.com/mdkent/chef/commits/CHEF-2818
Hide
Permalink
Bryan McLellan [Opscode] added a comment -

bulk change fix_version to 0.10.10

Show
Bryan McLellan [Opscode] added a comment - bulk change fix_version to 0.10.10
Hide
Permalink
Bryan McLellan [Opscode] added a comment -

Matthew Kent hat trick, merged to master.

Show
Bryan McLellan [Opscode] added a comment - Matthew Kent hat trick, merged to master.

People

  • Assignee:
    Matthew Kent
    Reporter:
    Matthew Kent
Vote (0)
Watch (0)

Dates

  • Created:
    Updated:
    Resolved: