Warn if invoke-rc.d is not going to start a service when we ask it to

Details

  • Type: New Feature New Feature
  • Status: Closed Closed
  • Priority: Unknown Unknown
  • Resolution: Fixed
  • Affects Version/s: None
  • Fix Version/s: 0.10.10
  • Component/s: None
  • Labels:

Description

CHEF-597 made the Debian service provider (before insserv on Debian 6.0) use invoke-rc.d to start services, which respects system policy.

It is possible for a user to inadvertently disable a service in system policy. When Chef tries to start the service, it will succeed and continue but the service will not have started. This is because invoke-rc.d lies to us and reports a return code of 0 even when the service is disabled by policy. This can be frustrating and confusing.

We should check system policy before trying to start the service and issue a warning if it is unlikely to succeed. However, we should not raise an exception and we should not try to modify any settings, as this behavior may be intentional on the administrators part.

Issue Links

relates to

Bug - A problem which impairs or prevents the functions of the product. CHEF-3147 Chef-client does not respect policy-rc.d (debian)

  • Unknown - Issue untriaged, priority unassigned or questioned
  • Closed - The issue is considered finished, the resolution is correct. Issues which are closed can be reopened.

Improvement - An improvement or enhancement to an existing feature or task. CHEF-597 Debian service provider should use invoke-rc.d <script> rather than /etc/init.d/<script>

  • Minor - Minor loss of function, or other problem where easy workaround is present.
  • Closed - The issue is considered finished, the resolution is correct. Issues which are closed can be reopened.

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Geoff Papilion added a comment -

pull request https://github.com/opscode/chef/pull/223 should fix this. adds warning for rc-policy.d violation.

Let me know if there are additional style changes needed.

Show
Geoff Papilion added a comment - pull request https://github.com/opscode/chef/pull/223 should fix this. adds warning for rc-policy.d violation. Let me know if there are additional style changes needed.
Hide
Permalink
Bryan McLellan [Opscode] added a comment -

Thanks Geoff. I haven't looked at it yet, but I see you aren't in the 'jira-developers' group which means you aren't attached to the CCLA you mentioned yet.

http://wiki.opscode.com/display/chef/How+to+Contribute#HowtoContribute-HowdoIaddadditionalemployeestomyexistingCCLA%3F

If you could please get your company to add you, we can move this along. Once you get the confirmation you can resolve the issue which signals to our triage meeting that it is all set for review.

Show
Bryan McLellan [Opscode] added a comment - Thanks Geoff. I haven't looked at it yet, but I see you aren't in the 'jira-developers' group which means you aren't attached to the CCLA you mentioned yet. http://wiki.opscode.com/display/chef/How+to+Contribute#HowtoContribute-HowdoIaddadditionalemployeestomyexistingCCLA%3F If you could please get your company to add you, we can move this along. Once you get the confirmation you can resolve the issue which signals to our triage meeting that it is all set for review.
Hide
Permalink
Justin Alan Ryan added a comment -

Geoff and myself work for Wikia, who already has a CCLA. I'm finding out who is the POC so that our names can be listed.

Show
Justin Alan Ryan added a comment - Geoff and myself work for Wikia, who already has a CCLA. I'm finding out who is the POC so that our names can be listed.
Hide
Permalink
Geoff Papilion added a comment -

Bryan I should be in the developers group now.

Show
Geoff Papilion added a comment - Bryan I should be in the developers group now.
Hide
Permalink
Bryan McLellan [Opscode] added a comment -

Yup, looks good. In the future, you can 'resolve' tickets yourself now, which indicates to our triage team that they are ready for review. We usually review tickets every Wednesday as a group unless someone has comments earlier.

Thanks!

Show
Bryan McLellan [Opscode] added a comment - Yup, looks good. In the future, you can 'resolve' tickets yourself now, which indicates to our triage team that they are ready for review. We usually review tickets every Wednesday as a group unless someone has comments earlier. Thanks!
Hide
Permalink
Bryan McLellan [Opscode] added a comment -

Per discussion on the mailing list [1], we've decided that it would be best to go back to not using debian policy via invoke-rc.d.

AFAICT this tool is only used by package maintainer scripts to avoid service interaction triggered by these scripts in a situation that is inappropriate, such as inside an chroot jail.

Thus, I've reverted the original commit from CHEF-597.

Geoff, special thanks for helping the discussion with your use cases.

[1] http://lists.opscode.com/sympa/arc/chef-dev/2012-02/msg00017.html

Show
Bryan McLellan [Opscode] added a comment - Per discussion on the mailing list [1] , we've decided that it would be best to go back to not using debian policy via invoke-rc.d. AFAICT this tool is only used by package maintainer scripts to avoid service interaction triggered by these scripts in a situation that is inappropriate, such as inside an chroot jail. Thus, I've reverted the original commit from CHEF-597 . Geoff, special thanks for helping the discussion with your use cases. [1] http://lists.opscode.com/sympa/arc/chef-dev/2012-02/msg00017.html
Hide
Permalink
Laurent Désarmes added a comment -

and what about only reverting the default provider ?

DESCRIPTION
       invoke-rc.d is a generic interface  to  execute  System  V  style  init
       script  /etc/init.d/name  actions, obeying runlevel constraints as well
       as any local policies set by the system administrator.

       All access to the init scripts by Debian packages'  maintainer  scripts
       should be done through invoke-rc.d.

does that mean it is only meant to be used by package maintainer scripts ?

can we keep the invokercd provider in 0.10.10 please ?

Show
Laurent Désarmes added a comment - and what about only reverting the default provider ? DESCRIPTION invoke-rc.d is a generic interface to execute System V style init script /etc/init.d/name actions, obeying runlevel constraints as well as any local policies set by the system administrator. All access to the init scripts by Debian packages' maintainer scripts should be done through invoke-rc.d. does that mean it is only meant to be used by package maintainer scripts ? can we keep the invokercd provider in 0.10.10 please ?
Hide
Permalink
Bryan McLellan [Opscode] added a comment -

Laurent, I've added the provider back in but prevented it from being a default provider for Debian.

Show
Bryan McLellan [Opscode] added a comment - Laurent, I've added the provider back in but prevented it from being a default provider for Debian.

People

  • Assignee:
    Unassigned
    Reporter:
    Bryan McLellan [Opscode]
Vote (0)
Watch (1)

Dates

  • Created:
    Updated:
    Resolved: