Allow downgrade of packages via the Chef::Provider::Package::Apt provider.

Details

  • Type: New Feature New Feature
  • Status: Open Open
  • Priority: Unknown Unknown
  • Resolution: Unresolved
  • Affects Version/s: 0.10.8
  • Fix Version/s: None
  • Component/s: None

Description

When downgrading a package to a lower version the apt_package provider will error out with:

E: There are problems and -y was used without --force-yes

Running the command with "--force-yes" fixes the issue.

It would be great if the Yum provider's allow_downgrade attribute could be ported over to apt provider. However it looks like "--force-yes" has many other implications aside from allowing downgrade.

Another way to do it would be to add a "force_yes" attribute to the apt_package provider, which would then add the flag to the command line.

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Elson Rodriguez added a comment -

Example implementation of force_yes attribute here:

https://github.com/elsonrodriguez/chef/commit/184ee96fd24dfbf3d0e0820e576bb89ceb59f62a

Show
Elson Rodriguez added a comment - Example implementation of force_yes attribute here: https://github.com/elsonrodriguez/chef/commit/184ee96fd24dfbf3d0e0820e576bb89ceb59f62a
Hide
Permalink
Bryan McLellan [Opscode] added a comment -

https://github.com/opscode/chef/pull/241

Thank you for taking the time to help make Chef better! We require a Contributor License Agreement (CLA) from contributors to help protect all Chef users. It is easy to complete one online. Instructions to do so are on our wiki, which is linked below. Once your account is updated, you will have access to 'resolve' tickets that indicates to the triage team that your contribution is ready for review.

http://wiki.opscode.com/display/chef/How+to+Contribute

Show
Bryan McLellan [Opscode] added a comment - https://github.com/opscode/chef/pull/241 Thank you for taking the time to help make Chef better! We require a Contributor License Agreement (CLA) from contributors to help protect all Chef users. It is easy to complete one online. Instructions to do so are on our wiki, which is linked below. Once your account is updated, you will have access to 'resolve' tickets that indicates to the triage team that your contribution is ready for review. http://wiki.opscode.com/display/chef/How+to+Contribute
Hide
Permalink
Elson Rodriguez added a comment -

Thanks for the link, I've filled out the form and verified it.

Show
Elson Rodriguez added a comment - Thanks for the link, I've filled out the form and verified it.
Hide
Permalink
Daniel DeLeo added a comment -

marking resolved so we see it at triage meeting.

Show
Daniel DeLeo added a comment - marking resolved so we see it at triage meeting.
Hide
Permalink
Bryan McLellan [Opscode] added a comment -

Thanks Elson,

From the pull request:

Without this patch the apt --force-yes must be specified via
a resource option. This makes your package declration platform
dependent.

In this case, you've added the force_yes attribute to the apt_package resource, which still makes this platform dependent because you have to use 'apt_package' in your cookbook rather than 'package'

Couldn't you specify --force-yes in the package resource options attribute but case that attribute on platform as a workaround?

If we're going to try to solve this for multiple platforms it needs to be done in the package resource not in the apt_package resource.

Also, the way your code is right now you would be adding a trailing space to the command if you weren't providing a force_yes option which seems likely to break existing tests. Did you test the unit tests? In either case, we would need a test case included for this use case.

Show
Bryan McLellan [Opscode] added a comment - Thanks Elson, From the pull request: Without this patch the apt --force-yes must be specified via a resource option. This makes your package declration platform dependent. In this case, you've added the force_yes attribute to the apt_package resource, which still makes this platform dependent because you have to use 'apt_package' in your cookbook rather than 'package' Couldn't you specify --force-yes in the package resource options attribute but case that attribute on platform as a workaround? If we're going to try to solve this for multiple platforms it needs to be done in the package resource not in the apt_package resource. Also, the way your code is right now you would be adding a trailing space to the command if you weren't providing a force_yes option which seems likely to break existing tests. Did you test the unit tests? In either case, we would need a test case included for this use case.
Hide
Permalink
Elson Rodriguez added a comment -

Sorry about that.

I was under the impression that provider specific flags performed no action if they were specified in the resource declaration and were not implemented in the provider.

Even if it did work that way, it might be overkill just to avoid an if statement.

I'll get a proper dev environment setup to play with the unit tests, but this will be for my own education.

You can consider this ticket closed.

Thanks for the pointers!

Show
Elson Rodriguez added a comment - Sorry about that. I was under the impression that provider specific flags performed no action if they were specified in the resource declaration and were not implemented in the provider. Even if it did work that way, it might be overkill just to avoid an if statement. I'll get a proper dev environment setup to play with the unit tests, but this will be for my own education. You can consider this ticket closed. Thanks for the pointers!
Hide
Permalink
Daniel DeLeo added a comment -

Looks like we have an allow_downgrade attribute for yum_package. (http://wiki.opscode.com/display/chef/Resources#Resources-Package). Does --force-yes have other implications beyond allowing downgrades? Seems like it would be reasonable to have allow_downgrade as a general option for package resources.

Show
Daniel DeLeo added a comment - Looks like we have an allow_downgrade attribute for yum_package . ( http://wiki.opscode.com/display/chef/Resources#Resources-Package ). Does --force-yes have other implications beyond allowing downgrades? Seems like it would be reasonable to have allow_downgrade as a general option for package resources.
Hide
Permalink
Thomas Dudziak added a comment -

Any updates on this ? It would be very helpful to support downgrades/force-yes for apt.

Show
Thomas Dudziak added a comment - Any updates on this ? It would be very helpful to support downgrades/force-yes for apt.

People

  • Assignee:
    Unassigned
    Reporter:
    Elson Rodriguez
Vote (0)
Watch (2)

Dates

  • Created:
    Updated: