FreeBSD service provider is too sensitive to the current state

Details

  • Type: Bug Bug
  • Status: Closed Closed
  • Priority: Unknown Unknown
  • Resolution: Fixed
  • Affects Version/s: None
  • Fix Version/s: 0.10.10
  • Component/s: None
  • Labels:
    None

Description

On FreeBSD, calling an init script can fail in a number of annoying ways:

  • calling service start on a service that is already started;
  • calling service restart on a service that is not started.

The fix is to specify the fast flag, per documentation (/etc/rc.subr):

fast Skip the pid check, and set rc_fast=yes, rc_quiet=yes

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Andrea Campi added a comment -

For reference, the source of /etc/rc.subr is at http://goo.gl/HjpYQ

Show
Andrea Campi added a comment - For reference, the source of /etc/rc.subr is at http://goo.gl/HjpYQ
Hide
Permalink
Andrea Campi added a comment -

Pull request: https://github.com/opscode/chef/pull/243

Show
Andrea Campi added a comment - Pull request: https://github.com/opscode/chef/pull/243
Hide
Permalink
Bryan McLellan [Opscode] added a comment -

Since we're adding a block of code here, could you provide unit tests along with it?

Also we're standardizing on ShellOut over run_command and popen4. Could you use that instead? Bonus points if you update the entire provider to use shellout.

Show
Bryan McLellan [Opscode] added a comment - Since we're adding a block of code here, could you provide unit tests along with it? Also we're standardizing on ShellOut over run_command and popen4. Could you use that instead? Bonus points if you update the entire provider to use shellout.
Hide
Permalink
Andrea Campi added a comment -

Done and done, at least for the common parts.
Some of the providers still use popen4, I can fix that in a separate run.

Show
Andrea Campi added a comment - Done and done, at least for the common parts. Some of the providers still use popen4, I can fix that in a separate run.
Hide
Permalink
Andrea Campi added a comment -

Pull request updated with tests and more refactoring.

Show
Andrea Campi added a comment - Pull request updated with tests and more refactoring.
Hide
Permalink
Bryan McLellan [Opscode] added a comment -

Awesome! Marked to be merged.

Show
Bryan McLellan [Opscode] added a comment - Awesome! Marked to be merged.
Hide
Permalink
Bryan McLellan [Opscode] added a comment -

A number of the tests related to other providers are failing here. Ho-Sheng is doing some shellout port work, I'll mention this to him.

Show
Bryan McLellan [Opscode] added a comment - A number of the tests related to other providers are failing here. Ho-Sheng is doing some shellout port work, I'll mention this to him.
Hide
Permalink
Andrea Campi added a comment -

All tests were green when I sent the pull request.
I see some other work in this areas has been merged since then, so I may need to rebase and update some.
I will look at it if I find the time, or Ho-Sheng is welcome to do it.

Show
Andrea Campi added a comment - All tests were green when I sent the pull request. I see some other work in this areas has been merged since then, so I may need to rebase and update some. I will look at it if I find the time, or Ho-Sheng is welcome to do it.
Hide
Permalink
Ho-Sheng Hsiao added a comment -

@Andrea: I can take a look at it from my end too.

Show
Ho-Sheng Hsiao added a comment - @Andrea: I can take a look at it from my end too.
Hide
Permalink
Andrea Campi added a comment -

I've updated the specs and the pull request: https://github.com/opscode/chef/pull/243

Show
Andrea Campi added a comment - I've updated the specs and the pull request: https://github.com/opscode/chef/pull/243
Hide
Permalink
Bryan McLellan [Opscode] added a comment -

Reresolving.

Show
Bryan McLellan [Opscode] added a comment - Reresolving.
Hide
Permalink
Bryan McLellan [Opscode] added a comment -

That did it, thanks Andrea. Merged to master.

Show
Bryan McLellan [Opscode] added a comment - That did it, thanks Andrea. Merged to master.

People

  • Assignee:
    Bryan McLellan [Opscode]
    Reporter:
    Andrea Campi
Vote (0)
Watch (0)

Dates

  • Created:
    Updated:
    Resolved: