Git clone should escape destination

Details

  • Type: Bug Bug
  • Status: Closed Closed
  • Priority: Minor Minor
  • Resolution: Fixed
  • Affects Version/s: None
  • Fix Version/s: 0.10.10
  • Component/s: None
  • Labels:
    None

Description

The git provider does not escape clone destinations. This causes a "Too many arguments." error when trying to clone to a destination with a space.

(you can reproduce this bug with this piece of code)

git "#{ENV['HOME']}/Library/Application Support/TextMate/Bundles/RSpec.tmbundle" do
  repository "git://github.com/rspec/rspec-tmbundle.git"
  reference "master"
  action :sync
end

Issue Links

relates to

Bug - A problem which impairs or prevents the functions of the product. CHEF-4239 git provider breaks if repository path has spaces

  • Unknown - Issue untriaged, priority unassigned or questioned
  • Closed - The issue is considered finished, the resolution is correct. Issues which are closed can be reopened.

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Andrew Fecheyr Lippens added a comment -

I've created a pull request on Github which fixes this issue by escaping the destination and have included a spec to test the behavior.

Link: https://github.com/opscode/chef/pull/242

Show
Andrew Fecheyr Lippens added a comment - I've created a pull request on Github which fixes this issue by escaping the destination and have included a spec to test the behavior. Link: https://github.com/opscode/chef/pull/242
Hide
Permalink
Akzhan Abdulin added a comment -

Assigned to the project lead to be triaged.

Show
Akzhan Abdulin added a comment - Assigned to the project lead to be triaged.
Hide
Permalink
Bryan McLellan [Opscode] added a comment -

Thanks! Marked to be merged.

Show
Bryan McLellan [Opscode] added a comment - Thanks! Marked to be merged.
Hide
Permalink
Bryan McLellan [Opscode] added a comment -

Thanks Andrew! Merged to master.

Show
Bryan McLellan [Opscode] added a comment - Thanks Andrew! Merged to master.

People

  • Assignee:
    Bryan McLellan [Opscode]
    Reporter:
    Andrew Fecheyr Lippens
Vote (0)
Watch (0)

Dates

  • Created:
    Updated:
    Resolved: