Webui doesn't delete nodes in Firefox

Details

  • Type: Bug Bug
  • Status: Closed Closed
  • Priority: Unknown Unknown
  • Resolution: Fixed
  • Affects Version/s: 0.10.4
  • Fix Version/s: 10.14.0
  • Component/s: WebUI
  • Labels:
  • Environment:

    Ubuntu oneiric firefox

Description

When you try delete any kind of item (nodes, roles, clients...) using Firefox (I have tried in FF8 and FF10) it doesn't work.
The problem is that jQuery fails in this line https://github.com/opscode/chef/blob/master/chef-server-webui/public/javascripts/chef.js#L133 because 'event.preventDefault()' function does not exist.
This occur because Firefox needs the "event handler", Chromium/Chrome doesn't

The bug is not reproducible in Chromium/Chrome.

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Bryan McLellan [Opscode] added a comment -

https://github.com/opscode/chef/pull/254

Thank you for taking the time to help make Chef better! We require a Contributor License Agreement (CLA) from contributors to help protect all Chef users. It is easy to complete one online. Instructions to do so are on our wiki, which is linked below. Once your account is updated, you will have access to 'resolve' tickets that indicates to the triage team that your contribution is ready for review.

http://wiki.opscode.com/display/chef/How+to+Contribute

Show
Bryan McLellan [Opscode] added a comment - https://github.com/opscode/chef/pull/254 Thank you for taking the time to help make Chef better! We require a Contributor License Agreement (CLA) from contributors to help protect all Chef users. It is easy to complete one online. Instructions to do so are on our wiki, which is linked below. Once your account is updated, you will have access to 'resolve' tickets that indicates to the triage team that your contribution is ready for review. http://wiki.opscode.com/display/chef/How+to+Contribute
Hide
Permalink
David Amian added a comment -

Done!

Show
David Amian added a comment - Done!
Hide
Permalink
Daniel DeLeo added a comment -

Marking as resolved so we see it at code review.

Show
Daniel DeLeo added a comment - Marking as resolved so we see it at code review.
Hide
Permalink
Daniel DeLeo added a comment -

Accepted and queued for merge.

Show
Daniel DeLeo added a comment - Accepted and queued for merge.
Hide
Permalink
Bryan McLellan [Opscode] added a comment -

Merged to master.

Show
Bryan McLellan [Opscode] added a comment - Merged to master.

People

  • Assignee:
    Unassigned
    Reporter:
    David Amian
Vote (0)
Watch (1)

Dates

  • Created:
    Updated:
    Resolved: