Route provider does not create route files on redhat and fedora

Details

  • Type: Bug Bug
  • Status: Closed Closed
  • Priority: Trivial Trivial
  • Resolution: Fixed
  • Affects Version/s: 0.10.8
  • Fix Version/s: 0.10.10
  • Component/s: None
  • Environment:

    RHEL, CentOS, Fedora

Description

When used on redhat and fedora systems, route provider (Chef::Provider::Route) does not create configuration files. CentOS systems work as expected (route files created).

The issue is caused by an error in platform detection code which uses Ruby case operator incorrectly: https://github.com/kovyrin/chef/compare/route-provider-fix#L0L133

Patch fixing the issue and adding specs for it is available on github: https://github.com/kovyrin/chef/commit/759951e4189351cce4ff8df987c0320f7706aff2 (branch https://github.com/kovyrin/chef/tree/route-provider-fix).

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Oleksiy Kovyrin added a comment -

The issue is fixed in https://github.com/kovyrin/chef/commit/759951e4189351cce4ff8df987c0320f7706aff2

Show
Oleksiy Kovyrin added a comment - The issue is fixed in https://github.com/kovyrin/chef/commit/759951e4189351cce4ff8df987c0320f7706aff2
Hide
Permalink
Bryan McLellan [Opscode] added a comment -

I'm removing the triaged flag as we use that to mark which tickets have been reviewed in the weekly Wednesday triage meeting at Opscode. Setting this bug as fixed/resolved is all that's needed for us to take a look at it. I'm adding a link to the topic branch, when I first looked at this I thought it might be a duplicate that was already fixed because you linked to a commit.

https://github.com/kovyrin/chef/tree/route-provider-fix

Show
Bryan McLellan [Opscode] added a comment - I'm removing the triaged flag as we use that to mark which tickets have been reviewed in the weekly Wednesday triage meeting at Opscode. Setting this bug as fixed/resolved is all that's needed for us to take a look at it. I'm adding a link to the topic branch, when I first looked at this I thought it might be a duplicate that was already fixed because you linked to a commit. https://github.com/kovyrin/chef/tree/route-provider-fix
Hide
Permalink
Bryan McLellan [Opscode] added a comment -

Marked to be merged.

Show
Bryan McLellan [Opscode] added a comment - Marked to be merged.
Hide
Permalink
Bryan McLellan [Opscode] added a comment -

We should add a test to verify we're writing to the correct location.

Show
Bryan McLellan [Opscode] added a comment - We should add a test to verify we're writing to the correct location.
Hide
Permalink
Bryan McLellan [Opscode] added a comment -

Merged to master, thanks Oleksiy!

Show
Bryan McLellan [Opscode] added a comment - Merged to master, thanks Oleksiy!

People

  • Assignee:
    Oleksiy Kovyrin
    Reporter:
    Oleksiy Kovyrin
Vote (0)
Watch (0)

Dates

  • Created:
    Updated:
    Resolved: