log provider - separate name from message for notifies

Details

  • Type: Improvement Improvement
  • Status: Fix Committed Fix Committed
  • Priority: Minor Minor
  • Resolution: Fixed
  • Affects Version/s: 10.16.0
  • Fix Version/s: 10.18.0
  • Component/s: None
  • Labels:
    None

Description

Would like to be able to:

log "network-change-warning" do
  msg "Make sure to reboot!"
  level :warn
  action :nothing
end

cookbook_file "/etc/network/interfaces" do
  notifies :write, "log[network-change-warning]", :delayed
end

I currently do this with a ruby_block but would like to use the proper resource.

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Matthew Kent added a comment - - edited

optional prefix for log messages like 

"recipe[#{self.cookbook_name}::#{self.recipe_name}]"

would also be useful

Show
Matthew Kent added a comment - - edited optional prefix for log messages like "recipe[#{self.cookbook_name}::#{self.recipe_name}]" would also be useful
Hide
Permalink
Matthew Kent added a comment -

Scratch that previous comment, forgot about the 'Processing' output I had suppressed 

[2012-10-25T00:12:19-04:00] INFO: Processing log[network-change-warning] action write (demo::default line 1)
Show
Matthew Kent added a comment - Scratch that previous comment, forgot about the 'Processing' output I had suppressed [2012-10-25T00:12:19-04:00] INFO: Processing log[network-change-warning] action write (demo:: default line 1)
Hide
Permalink
Matthew Kent added a comment -

Fixes example:

[2012-10-25T01:16:04-04:00] INFO: Processing log[network-change-warning] action nothing (demo::default line 1)
[2012-10-25T01:16:04-04:00] INFO: Processing cookbook_file[/tmp/demo] action create (demo::default line 7)
[2012-10-25T01:16:04-04:00] INFO: cookbook_file[/tmp/demo] owner changed to 0
[2012-10-25T01:16:04-04:00] INFO: cookbook_file[/tmp/demo] group changed to 0
[2012-10-25T01:16:04-04:00] INFO: cookbook_file[/tmp/demo] mode changed to 600
[2012-10-25T01:16:04-04:00] INFO: cookbook_file[/tmp/demo] created file /tmp/demo
[2012-10-25T01:16:04-04:00] INFO: cookbook_file[/tmp/demo] sending write action to log[network-change-warning] (delayed)
[2012-10-25T01:16:04-04:00] INFO: Processing log[network-change-warning] action write (demo::default line 1)
[2012-10-25T01:16:04-04:00] WARN: Make sure to reboot!
[2012-10-25T01:16:04-04:00] INFO: Chef Run complete in 0.134731389 seconds

Please pull from
https://github.com/mdkent/chef/tree/CHEF-3006

Show
Matthew Kent added a comment - Fixes example: [2012-10-25T01:16:04-04:00] INFO: Processing log[network-change-warning] action nothing (demo:: default line 1) [2012-10-25T01:16:04-04:00] INFO: Processing cookbook_file[/tmp/demo] action create (demo:: default line 7) [2012-10-25T01:16:04-04:00] INFO: cookbook_file[/tmp/demo] owner changed to 0 [2012-10-25T01:16:04-04:00] INFO: cookbook_file[/tmp/demo] group changed to 0 [2012-10-25T01:16:04-04:00] INFO: cookbook_file[/tmp/demo] mode changed to 600 [2012-10-25T01:16:04-04:00] INFO: cookbook_file[/tmp/demo] created file /tmp/demo [2012-10-25T01:16:04-04:00] INFO: cookbook_file[/tmp/demo] sending write action to log[network-change-warning] (delayed) [2012-10-25T01:16:04-04:00] INFO: Processing log[network-change-warning] action write (demo:: default line 1) [2012-10-25T01:16:04-04:00] WARN: Make sure to reboot! [2012-10-25T01:16:04-04:00] INFO: Chef Run complete in 0.134731389 seconds Please pull from https://github.com/mdkent/chef/tree/CHEF-3006
Hide
Permalink
Bryan McLellan [Opscode] added a comment -

cherry-picked to 10-stable

Show
Bryan McLellan [Opscode] added a comment - cherry-picked to 10-stable

People

  • Assignee:
    Matthew Kent
    Reporter:
    Matthew Kent
Vote (0)
Watch (0)

Dates

  • Created:
    Updated:
    Resolved: