Convert chef-server-webui from merb to Rails 3.2

Details

  • Type: Improvement Improvement
  • Status: Closed Closed
  • Priority: Unknown Unknown
  • Resolution: Fixed
  • Affects Version/s: 0.10.10
  • Fix Version/s: 11.0.0
  • Component/s: WebUI
  • Labels:

Description

The FrontSide Software was contracted to convert the chef-server-webui from Merb to Rails 3.

A github pull request will be created and added to this ticket.

Issue Links

is duplicated by

Improvement - An improvement or enhancement to an existing feature or task. CHEF-2969 Switch webui from merb to rails

  • Unknown - Issue untriaged, priority unassigned or questioned
  • Closed - The issue is considered finished, the resolution is correct. Issues which are closed can be reopened.
relates to

Bug - A problem which impairs or prevents the functions of the product. CHEF-2792 XSS vulnerability in messages field on login page

  • Major - Major loss of function.
  • Closed - The issue is considered finished, the resolution is correct. Issues which are closed can be reopened.

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Logan Lowell added a comment -

GitHub pull request: https://github.com/opscode/chef/pull/261

Show
Logan Lowell added a comment - GitHub pull request: https://github.com/opscode/chef/pull/261
Hide
Permalink
Logan Lowell added a comment -

This was a direct conversion from Merb to Rails 3. The logic has remained the same, with updates done for Rails redirection, flash messaging, and view template rendering.

Web server boot logic was modified to fit into the Rails 3 framework, which removed some of the features that Merb offered, trading it for Rails 3 features.

There are several things we can continue to do to improve the current state of the chef-server-webui.

Now that the Rails 3 framework is in place, a conversion of many of the original models to work with ActiveModel would allow a tighter and cleaner Rails 3 implementation. Additionally, this would allow for easy I18n work.

Show
Logan Lowell added a comment - This was a direct conversion from Merb to Rails 3. The logic has remained the same, with updates done for Rails redirection, flash messaging, and view template rendering. Web server boot logic was modified to fit into the Rails 3 framework, which removed some of the features that Merb offered, trading it for Rails 3 features. There are several things we can continue to do to improve the current state of the chef-server-webui. Now that the Rails 3 framework is in place, a conversion of many of the original models to work with ActiveModel would allow a tighter and cleaner Rails 3 implementation. Additionally, this would allow for easy I18n work.
Hide
Permalink
Bryan McLellan [Opscode] added a comment -

Thanks Logan. I'm marking this ticket resolved for code review. In the future, you can do this yourself as well.

This is the work originally tracked in CHEF-2969.

Show
Bryan McLellan [Opscode] added a comment - Thanks Logan. I'm marking this ticket resolved for code review. In the future, you can do this yourself as well. This is the work originally tracked in CHEF-2969 .
Hide
Permalink
Bryan McLellan [Opscode] added a comment -

This looks good. We'll have to fork master into 0.10-stable before we can merge this into master though.

Show
Bryan McLellan [Opscode] added a comment - This looks good. We'll have to fork master into 0.10-stable before we can merge this into master though.
Hide
Permalink
Akzhan Abdulin added a comment -

Thanks, Logan. Will work on.

Show
Akzhan Abdulin added a comment - Thanks, Logan. Will work on.
Hide
Permalink
Bryan McLellan [Opscode] added a comment -

Merged to master for Chef 11

Show
Bryan McLellan [Opscode] added a comment - Merged to master for Chef 11

People

  • Assignee:
    Unassigned
    Reporter:
    Logan Lowell
Vote (0)
Watch (0)

Dates

  • Created:
    Updated:
    Resolved: