knife output formatting of columns needs to be narrower

Details

  • Type: Bug Bug
  • Status: Closed Closed
  • Priority: Trivial Trivial
  • Resolution: Fixed
  • Affects Version/s: None
  • Fix Version/s: 0.10.10
  • Component/s: Knife
  • Labels:
    None

Description

https://gist.github.com/c4a4041c4826c369449d
chef/knife/core/text_formatter.rb is the likely suspect.
justify_width = data.keys.map {|k| k.to_s.size }.max.to_i + 2
appears to make every column the same width.

Issue Links

relates to

Bug - A problem which impairs or prevents the functions of the product. KNIFE-36 Output of `knife rackspace server list` is too wide.

  • Unknown - Issue untriaged, priority unassigned or questioned
  • Closed - The issue is considered finished, the resolution is correct. Issues which are closed can be reopened.

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Matt Ray added a comment -

Fix in the individual knife plugins
KNIFE_RACKSPACE-7
KNIFE_EC2-53
KNIFE_OPENSTACK-5

Show
Matt Ray added a comment - Fix in the individual knife plugins KNIFE_RACKSPACE-7 KNIFE_EC2-53 KNIFE_OPENSTACK-5
Hide
Permalink
Matt Ray added a comment -

need to ensure highline is a recent version to support those changes

Show
Matt Ray added a comment - need to ensure highline is a recent version to support those changes
Hide
Permalink
Matt Ray added a comment -

https://github.com/mattray/chef/tree/CHEF-3027

please merge

Show
Matt Ray added a comment - https://github.com/mattray/chef/tree/CHEF-3027 please merge
Hide
Permalink
Bryan McLellan [Opscode] added a comment -

What is the bugfix here? 1.6.9 was released on 12/18/2011 and isn't in any debian or ubuntu packaging yet, which means we will have to maintain an updated debian package for core chef if we include this.

Show
Bryan McLellan [Opscode] added a comment - What is the bugfix here? 1.6.9 was released on 12/18/2011 and isn't in any debian or ubuntu packaging yet, which means we will have to maintain an updated debian package for core chef if we include this.
Hide
Permalink
Matt Ray added a comment -

The bug is a cosmetic issue related to the width of output. https://gist.github.com/c4a4041c4826c369449d shows the original appearance (be sure to slide horizontally) and the fixed appearance.

For the record, distro support for ruby dependencies make me very sad.

Show
Matt Ray added a comment - The bug is a cosmetic issue related to the width of output. https://gist.github.com/c4a4041c4826c369449d shows the original appearance (be sure to slide horizontally) and the fixed appearance. For the record, distro support for ruby dependencies make me very sad.
Hide
Permalink
Bryan McLellan [Opscode] added a comment -

We don't believe we use any feature of highline 1.6.9 in the core chef, so while the chef gem will depend on it, distribution packagers shouldn't need to backport this version of highline. It is required for the knife cloud plugins, which we currently only distribute as gems.

Show
Bryan McLellan [Opscode] added a comment - We don't believe we use any feature of highline 1.6.9 in the core chef, so while the chef gem will depend on it, distribution packagers shouldn't need to backport this version of highline. It is required for the knife cloud plugins, which we currently only distribute as gems.
Hide
Permalink
Bryan McLellan [Opscode] added a comment -

Merged to master.

Show
Bryan McLellan [Opscode] added a comment - Merged to master.

People

  • Assignee:
    Matt Ray
    Reporter:
    Matt Ray
Vote (0)
Watch (0)

Dates

  • Created:
    Updated:
    Resolved: