ifconfig provider for debian/ubuntu platforms

Details

  • Type: New Feature New Feature
  • Status: Fix Reviewed Fix Reviewed
  • Priority: Minor Minor
  • Resolution: Unresolved
  • Affects Version/s: None
  • Fix Version/s: None
  • Component/s: Chef Client, Chef Solo
  • Labels:

Description

On Debian Wheezy (testing) and Ubuntu 11.10 and later releases for both, the "ifupdown" program can now take a "source" directive that reads interface stanzas from a specified file.

From the interfaces(5) man page (Ubuntu 11.10):

Lines beginning with "source" are used to include stanzas from other files, so configuration can be split into many files. The  word "source" is followed by the path of file to be sourced. Shell wildcards can be used.  (See wordexp(3) for details.)

This will require that users have their /etc/network/interfaces configuration set up to include a source line with the files they wish to include. This could be done with a wildcard, per the man page entry, e.g. "source interfaces.d/*". Such a thing could be handled with Chef::Util::FileEdit, but that seems heavy-handed.

The current ifconfig provider is RHEL specific. It would need to be moved to a new provider and the Chef::Platform default provider for RHEL-family set to use the new name (I propose redhat). Then this new provider would be appropriately named debian, and the default provider on Debian/Ubuntu.

The main issue I see with that implementation is that the Chef::Platform version specification does not allow setting "versions greater than..."

Debian bug resolving the request to add this feature (source directive):

Issue Links

depends on

New Feature - A new feature of the product, which has yet to be developed. CHEF-3919 Modify Chef::Platform to allow "greater than" conditionals

  • Minor - Minor loss of function, or other problem where easy workaround is present.
  • Fix Committed - The fix has been committed to the repository
is duplicated by

Bug - A problem which impairs or prevents the functions of the product. CHEF-4100 Chef::Util::FileEdit raise()s if file exists but is just empty -- this is bogus

  • Minor - Minor loss of function, or other problem where easy workaround is present.
  • Closed - The issue is considered finished, the resolution is correct. Issues which are closed can be reopened.

Activity

Ascending order - Click to sort in descending order
Bryan McLellan [Opscode] made changes -
Field Original Value New Value
Component/s Providers [ 10005 ]
Bryan McLellan [Opscode] made changes -
Workflow jira [ 15583 ] New OSS [ 17795 ]
Xabier de Zuazo [Onddo Labs] made changes -
Assignee Xabier de Zuazo [ zuazo ]
Hide
Permalink
Xabier de Zuazo [Onddo Labs] added a comment - - edited

I know this patch may cause controversy, don't worry Here's my first attempt.

https://github.com/opscode/chef/pull/635

Any ideas to improve the patch, problems or questions?

Some notes:

  • I tried to follow Joshua guidelines as much as possible.
  • Does not clean the /etc/network/interfaces config file, which could have more configurations.
  • Does not configure the gateway, this would require changes in commands executed in the provider and could add complexity.
  • I reused Chef::Version and integrated it with Chef::Platform to support ">=" in platform versions.
    • Maybe not quite fit: the exception Chef::Version throws is called InvalidCookbookVersion, perhaps this should be changed.
      • By the way: this exception is ignored inside Chef::Platform.
  • I also changed Chef::Version to support single digit in version names (for example cookbook version "1"), it is possible that you do not agree with this, but my idea is to try to reuse that class. IMHO not being able to make comparisons with single digit versions inside Chef::Platform would be weird, but it is not a requirement right now, so this change can be reverted.
  • Added some attributes to Provider::Ifconfig to avoid code duplications in Ifconfig::Debian and Ifconfig::Redhat as much as possible.
  • Blank file exception removed from Util::FileEdit, it has given me problems with #insert_line_if_no_match and empty files.
  • Platforms array perhaps can be improved, for example adding more supported versions in other distributions.
  • Tested to work in Ubuntu 12.04 and Debian unstable (7.0) using Bento & chef-solo.

Deleted lines move to CHEF-3919.

Show
Xabier de Zuazo [Onddo Labs] added a comment - - edited I know this patch may cause controversy, don't worry Here's my first attempt. https://github.com/opscode/chef/pull/635 Any ideas to improve the patch, problems or questions? Some notes: I tried to follow Joshua guidelines as much as possible. Does not clean the /etc/network/interfaces config file, which could have more configurations. Does not configure the gateway , this would require changes in commands executed in the provider and could add complexity. I reused Chef::Version and integrated it with Chef::Platform to support ">=" in platform versions. Maybe not quite fit: the exception Chef::Version throws is called InvalidCookbookVersion , perhaps this should be changed. By the way: this exception is ignored inside Chef::Platform . I also changed Chef::Version to support single digit in version names (for example cookbook version "1"), it is possible that you do not agree with this, but my idea is to try to reuse that class. IMHO not being able to make comparisons with single digit versions inside Chef::Platform would be weird, but it is not a requirement right now, so this change can be reverted. Added some attributes to Provider::Ifconfig to avoid code duplications in Ifconfig::Debian and Ifconfig::Redhat as much as possible. Blank file exception removed from Util::FileEdit , it has given me problems with #insert_line_if_no_match and empty files. Platforms array perhaps can be improved, for example adding more supported versions in other distributions. Tested to work in Ubuntu 12.04 and Debian unstable (7.0) using Bento & chef-solo. Deleted lines move to CHEF-3919 .
Xabier de Zuazo [Onddo Labs] made changes -
Status Open [ 1 ] Fix Provided [ 10002 ]
Xabier de Zuazo [Onddo Labs] made changes -
Component/s Chef Client [ 10000 ]
Component/s Chef Solo [ 10001 ]
Hide
Permalink
Bryan McLellan [Opscode] added a comment -

We ran out of time looking at this, but could you separate the Chef::Platform version constraint feature into another ticket and patch? We can probably get through these individual faster than them combined.

Show
Bryan McLellan [Opscode] added a comment - We ran out of time looking at this, but could you separate the Chef::Platform version constraint feature into another ticket and patch? We can probably get through these individual faster than them combined.
Bryan McLellan [Opscode] made changes -
Status Fix Provided [ 10002 ] Reopened [ 4 ]
Xabier de Zuazo [Onddo Labs] made changes -
Link This issue depends on CHEF-3919 [ CHEF-3919 ]
Hide
Permalink
Xabier de Zuazo [Onddo Labs] added a comment -

We ran out of time looking at this, but could you separate the Chef::Platform version constraint feature into another ticket and patch? We can probably get through these individual faster than them combined.

Done: CHEF-3919.

This ticket will wait until the other pull request is accepted.

Show
Xabier de Zuazo [Onddo Labs] added a comment - We ran out of time looking at this, but could you separate the Chef::Platform version constraint feature into another ticket and patch? We can probably get through these individual faster than them combined. Done: CHEF-3919 . This ticket will wait until the other pull request is accepted.
Bryan McLellan [Opscode] made changes -
Workflow New OSS [ 17795 ] OSS: Product Management [ 26070 ]
Status Reopened [ 4 ] Open [ 1 ]
Hide
Permalink
Xabier de Zuazo [Onddo Labs] added a comment -

CHEF-3919 has been reviewed. Time to return to this ticket

I made a new branch from the CHEF-3919.

Diff: https://github.com/onddo/chef/compare/onddo:CHEF-3919...onddo:CHEF-3029-2
New pull request: https://github.com/opscode/chef/pull/697

Show
Xabier de Zuazo [Onddo Labs] added a comment - CHEF-3919 has been reviewed. Time to return to this ticket I made a new branch from the CHEF-3919 . Diff: https://github.com/onddo/chef/compare/onddo:CHEF-3919...onddo:CHEF-3029-2 New pull request: https://github.com/opscode/chef/pull/697
Xabier de Zuazo [Onddo Labs] made changes -
Status Open [ 1 ] Fix Provided [ 10002 ]
Bryan McLellan [Opscode] made changes -
Assignee Xabier de Zuazo [Onddo Labs] [ zuazo ] Bryan McLellan [Opscode] [ btm ]
Hide
Permalink
Bryan McLellan [Opscode] added a comment -

I'm going to get CHEF-3919 merged so we can look at this with a more concise diff.

Show
Bryan McLellan [Opscode] added a comment - I'm going to get CHEF-3919 merged so we can look at this with a more concise diff.
Hide
Permalink
Xabier de Zuazo [Onddo Labs] added a comment -

OK. Let me know if you want me to do a new PR or anything.

Show
Xabier de Zuazo [Onddo Labs] added a comment - OK. Let me know if you want me to do a new PR or anything.
Hide
Permalink
Bryan McLellan [Opscode] added a comment -

Yeah, could you rebase and force push that? It doesn't look like the diff is adapting on its own now that CHEF-3919 is in master.

Show
Bryan McLellan [Opscode] added a comment - Yeah, could you rebase and force push that? It doesn't look like the diff is adapting on its own now that CHEF-3919 is in master.
Hide
Permalink
Xabier de Zuazo [Onddo Labs] added a comment -

Done. Rebased in a new PR: https://github.com/opscode/chef/pull/712

Show
Xabier de Zuazo [Onddo Labs] added a comment - Done. Rebased in a new PR: https://github.com/opscode/chef/pull/712
Steven Danna made changes -
Status Fix Provided [ 10002 ] Fix Reviewed [ 10000 ]
Hide
Permalink
Steven Danna added a comment -

We'd like one of our ops people to do a review of this just as a sanity check, but otherwise this is good to merge.

Show
Steven Danna added a comment - We'd like one of our ops people to do a review of this just as a sanity check, but otherwise this is good to merge.
Daniel DeLeo made changes -
Link This issue is duplicated by CHEF-4100 [ CHEF-4100 ]
Transition Time In Source Status Execution Times Last Executer Last Execution Date
Fix Provided Fix Provided Reopened Reopened
9d 3h 7m 1 Bryan McLellan [Opscode] 20/Feb/13 9:00 PM
Reopened Reopened Open Open
19d 1h 41m 1 Bryan McLellan [Opscode] 11/Mar/13 10:41 PM
Open Open Fix Provided Fix Provided
325d 13h 7m 2 Xabier de Zuazo [Onddo Labs] 01/Apr/13 12:21 AM
Fix Provided Fix Provided Fix Reviewed Fix Reviewed
30d 18h 23m 1 Steven Danna 01/May/13 6:45 PM

People

  • Assignee:
    Bryan McLellan [Opscode]
    Reporter:
    jtimberman
Vote (0)
Watch (3)

Dates

  • Created:
    Updated: