user resource : home attribute with trailing slash

Details

  • Type: Improvement Improvement
  • Status: Closed Closed
  • Priority: Unknown Unknown
  • Resolution: Fixed
  • Affects Version/s: 0.10.8
  • Fix Version/s: 0.10.10
  • Component/s: Chef Client
  • Labels:
    None

Description

Came accross this some weeks ago,
a debian package creates a system user, for some reason its homedir is set to '/var/lib/daemon-user1/' (trailing slash)
i use the user resource with home "/var/lib/daemon-user1" (without the trailing slash)
chef tries to change the home field to "/var/lib/daemon-user1".
no luck here, user is logged in ! usermod fails, chef fails on every run !

would you agree updating_home? should ignore the trailing slash ?
we obviously don't want any updating if the directories are the same, do we ?

i guess we might also go a bit further and remove trailing slashes as well

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Laurent Désarmes added a comment -

https://github.com/llaurent/chef/compare/CHEF-3033
I'll add a test a bit later

Show
Laurent Désarmes added a comment - https://github.com/llaurent/chef/compare/CHEF-3033 I'll add a test a bit later
Hide
Permalink
Laurent Désarmes added a comment - - edited

just written a new test for needs_updating?
The patch just uses Pathname#cleanpath on @current_resource.home and on @new_resource.home before comparing them.

as a result paths like "/home/laurent/" or "/home/./laurent/../laurent" are considered as equivalent to "/home/laurent"

if the home is already set to "/home/laurent" it won't change it if you pass "/home/../home/laurent"
if the home is set to "/home/../home/laurent" it won't change it if you pass "/home/laurent"
if the user doesn't exist it won't set to "/home/laurent" if you pass "/home/../home/laurent"

Show
Laurent Désarmes added a comment - - edited just written a new test for needs_updating? The patch just uses Pathname#cleanpath on @current_resource.home and on @new_resource.home before comparing them. as a result paths like "/home/laurent/" or "/home/./laurent/../laurent" are considered as equivalent to "/home/laurent" if the home is already set to "/home/laurent" it won't change it if you pass "/home/../home/laurent" if the home is set to "/home/../home/laurent" it won't change it if you pass "/home/laurent" if the user doesn't exist it won't set to "/home/laurent" if you pass "/home/../home/laurent"
Hide
Permalink
Bryan McLellan [Opscode] added a comment -

We'll give it a shot, it seems to be asking chef to do what you say correctly.

Show
Bryan McLellan [Opscode] added a comment - We'll give it a shot, it seems to be asking chef to do what you say correctly.
Hide
Permalink
Bryan McLellan [Opscode] added a comment -

Merged to master. Thanks Laurent.

Show
Bryan McLellan [Opscode] added a comment - Merged to master. Thanks Laurent.

People

  • Assignee:
    Laurent Désarmes
    Reporter:
    Laurent Désarmes
Vote (0)
Watch (1)

Dates

  • Created:
    Updated:
    Resolved: