"Unexpected form for PKGNAME variable" installing packages on FreeBSD 9

Details

  • Type: Bug Bug
  • Status: Open Open
  • Priority: Critical Critical
  • Resolution: Unresolved
  • Affects Version/s: 0.10.8
  • Fix Version/s: None
  • Component/s: Chef Client
  • Labels:
  • Environment:

    FreeBSD localhost 9.0-RELEASE FreeBSD 9.0-RELEASE #0: Thu Jan 5 22:56:03 UTC 2012 root@ip-10-17-24-248:/usr/obj/usr/src/sys/XENHVM amd64

Description

Reproducable with the following shef session:

# shef
loading configuration: none (standalone shef session)
Session type: standalone
Loading.r.ec[Tue, 24 Apr 2012 20:36:55 +0000] INFO: Run List is []
[Tue, 24 Apr 2012 20:36:55 +0000] INFO: Run List expands to []
ipdone.

This is shef, the Chef shell.
 Chef Version: 0.10.8
 http://www.opscode.com/chef
 http://wiki.opscode.com/display/chef/Home

run `help' for help, `exit' or ^D to quit.

Ohai2u root@localhost!
chef > recipe
chef:recipe > package "ntp"
 => <package[ntp] @candidate_version: nil @retry_delay: 2 @updated_by_last_action: false @enclosing_provider: nil @source: nil @resource_name: :package @params: {} @response_file: nil @retries: 0 @updated: false @allowed_actions: [:nothing, :install, :upgrade, :remove, :purge, :reconfig] @recipe_name: nil @version: nil @delayed_notifications: [] @before: nil @package_name: "ntp" @ignore_failure: false @action: :install @cookbook_name: nil @immediate_notifications: [] @noop: nil @name: "ntp" @supports: {} @options: nil @source_line: "(irb#1):1:in `irb_binding'" @provider: nil> 
chef:recipe > run_chef
[Tue, 24 Apr 2012 20:37:04 +0000] DEBUG: Processing package[ntp] on localhost
[Tue, 24 Apr 2012 20:37:04 +0000] INFO: Processing package[ntp] action install ((irb#1) line 1)
[Tue, 24 Apr 2012 20:37:04 +0000] DEBUG: sh(whereis -s ntp)
ntp: /usr/src/usr.sbin/ntp
[Tue, 24 Apr 2012 20:37:04 +0000] DEBUG: sh(make -V PKGNAME)

[Tue, 24 Apr 2012 20:37:04 +0000] DEBUG: sh(whereis -s ntp)
ntp: /usr/src/usr.sbin/ntp
[Tue, 24 Apr 2012 20:37:04 +0000] ERROR: package[ntp] ((irb#1) line 1) has had an error
[Tue, 24 Apr 2012 20:37:04 +0000] ERROR: package[ntp] ((irb#1):1:in `irb_binding') had an error:
package[ntp] ((irb#1) line 1) had an error: Chef::Exceptions::Package: Unexpected form for PKGNAME variable in /usr/src/usr.sbin/ntp/Makefile
/usr/local/lib/ruby/gems/1.8/gems/chef-0.10.8/lib/chef/provider/package/freebsd.rb:92:in `package_name'
/usr/local/lib/ruby/gems/1.8/gems/chef-0.10.8/lib/chef/provider/package/freebsd.rb:39:in `current_installed_version'
/usr/local/lib/ruby/gems/1.8/gems/chef-0.10.8/lib/chef/provider/package/freebsd.rb:74:in `load_current_resource'
/usr/local/lib/ruby/gems/1.8/gems/chef-0.10.8/lib/chef/resource.rb:439:in `run_action'
/usr/local/lib/ruby/gems/1.8/gems/chef-0.10.8/lib/chef/runner.rb:45:in `run_action'
/usr/local/lib/ruby/gems/1.8/gems/chef-0.10.8/lib/chef/runner.rb:81:in `converge'
/usr/local/lib/ruby/gems/1.8/gems/chef-0.10.8/lib/chef/runner.rb:81:in `each'
/usr/local/lib/ruby/gems/1.8/gems/chef-0.10.8/lib/chef/runner.rb:81:in `converge'
/usr/local/lib/ruby/gems/1.8/gems/chef-0.10.8/lib/chef/resource_collection.rb:94:in `execute_each_resource'
/usr/local/lib/ruby/gems/1.8/gems/chef-0.10.8/lib/chef/resource_collection/stepable_iterator.rb:116:in `call'
/usr/local/lib/ruby/gems/1.8/gems/chef-0.10.8/lib/chef/resource_collection/stepable_iterator.rb:116:in `call_iterator_block'
/usr/local/lib/ruby/gems/1.8/gems/chef-0.10.8/lib/chef/resource_collection/stepable_iterator.rb:85:in `step'
/usr/local/lib/ruby/gems/1.8/gems/chef-0.10.8/lib/chef/resource_collection/stepable_iterator.rb:104:in `iterate'
/usr/local/lib/ruby/gems/1.8/gems/chef-0.10.8/lib/chef/resource_collection/stepable_iterator.rb:55:in `each_with_index'
/usr/local/lib/ruby/gems/1.8/gems/chef-0.10.8/lib/chef/resource_collection.rb:92:in `execute_each_resource'
/usr/local/lib/ruby/gems/1.8/gems/chef-0.10.8/lib/chef/runner.rb:76:in `converge'
/usr/local/lib/ruby/gems/1.8/gems/chef-0.10.8/lib/chef/shef/ext.rb:234:in `run_chef'
(irb#1):2:in `irb_binding'
/usr/local/lib/ruby/1.8/irb/workspace.rb:68:in `irb_binding'
/usr/local/lib/ruby/1.8/irb/workspace.rb:52:in `irb_binding'
/usr/local/lib/ruby/1.8/irb/workspace.rb:52
Chef::Exceptions::Package: package[ntp] ((irb#1) line 1) had an error: Chef::Exceptions::Package: Unexpected form for PKGNAME variable in /usr/src/usr.sbin/ntp/Makefile
	from /usr/local/lib/ruby/gems/1.8/gems/chef-0.10.8/lib/chef/provider/package/freebsd.rb:92:in `package_name'
	from /usr/local/lib/ruby/gems/1.8/gems/chef-0.10.8/lib/chef/provider/package/freebsd.rb:39:in `current_installed_version'
	from /usr/local/lib/ruby/gems/1.8/gems/chef-0.10.8/lib/chef/provider/package/freebsd.rb:74:in `load_current_resource'
	from /usr/local/lib/ruby/gems/1.8/gems/chef-0.10.8/lib/chef/resource.rb:439:in `run_action'
	from /usr/local/lib/ruby/gems/1.8/gems/chef-0.10.8/lib/chef/runner.rb:45:in `run_action'
	from /usr/local/lib/ruby/gems/1.8/gems/chef-0.10.8/lib/chef/runner.rb:81:in `converge'
	from /usr/local/lib/ruby/gems/1.8/gems/chef-0.10.8/lib/chef/runner.rb:81:in `each'
	from /usr/local/lib/ruby/gems/1.8/gems/chef-0.10.8/lib/chef/runner.rb:81:in `converge'
	from /usr/local/lib/ruby/gems/1.8/gems/chef-0.10.8/lib/chef/resource_collection.rb:94:in `execute_each_resource'
	from /usr/local/lib/ruby/gems/1.8/gems/chef-0.10.8/lib/chef/resource_collection/stepable_iterator.rb:116:in `call'
	from /usr/local/lib/ruby/gems/1.8/gems/chef-0.10.8/lib/chef/resource_collection/stepable_iterator.rb:116:in `call_iterator_block'
	from /usr/local/lib/ruby/gems/1.8/gems/chef-0.10.8/lib/chef/resource_collection/stepable_iterator.rb:85:in `step'
	from /usr/local/lib/ruby/gems/1.8/gems/chef-0.10.8/lib/chef/resource_collection/stepable_iterator.rb:104:in `iterate'
	from /usr/local/lib/ruby/gems/1.8/gems/chef-0.10.8/lib/chef/resource_collection/stepable_iterator.rb:55:in `each_with_index'
	from /usr/local/lib/ruby/gems/1.8/gems/chef-0.10.8/lib/chef/resource_collection.rb:92:in `execute_each_resource'
	from /usr/local/lib/ruby/gems/1.8/gems/chef-0.10.8/lib/chef/runner.rb:76:in `converge'
	from /usr/local/lib/ruby/gems/1.8/gems/chef-0.10.8/lib/chef/shef/ext.rb:234:in `run_chef'
	from (irb#1):2

This is the same issue as was reported in CHEF-1413 and discussed in CHEF-2634. It is reproducable on (at least) AWS using ami-1d4c9874.

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Dan Crosta added a comment -

I get the same result when using Chef 0.10.8 installed with gem (rather than using the port), and when using Chef 0.10.10.beta.1 installed with gem.

Show
Dan Crosta added a comment - I get the same result when using Chef 0.10.8 installed with gem (rather than using the port), and when using Chef 0.10.10.beta.1 installed with gem.
Hide
Permalink
Mike Fiedler added a comment -

I understand you're the best person to assign this to.

Show
Mike Fiedler added a comment - I understand you're the best person to assign this to.
Hide
Permalink
Andrea Campi added a comment -

The package provider uses a silly algorithm to determine the package name: it looks for a port directory named after the package (which in itself is kind of reasonable), but it does so using whereis.
From the attached log:

[Tue, 24 Apr 2012 20:37:04 +0000] DEBUG: sh(whereis -s ntp)
ntp: /usr/src/usr.sbin/ntp

That is quite clearly not what we want.

In most cases, for packages that do exist in ports, that ends up working; but it's quite brittle.

BTW, for ntp you don't need to install any package, it's part of the basic distribution.
In fact the ntp cookbook does not install it. Dan, were you just trying things out or do you have an outdated cookbook?

Show
Andrea Campi added a comment - The package provider uses a silly algorithm to determine the package name: it looks for a port directory named after the package (which in itself is kind of reasonable), but it does so using whereis. From the attached log: [Tue, 24 Apr 2012 20:37:04 +0000] DEBUG: sh(whereis -s ntp) ntp: /usr/src/usr.sbin/ntp That is quite clearly not what we want. In most cases, for packages that do exist in ports, that ends up working; but it's quite brittle. BTW, for ntp you don't need to install any package, it's part of the basic distribution. In fact the ntp cookbook does not install it. Dan, were you just trying things out or do you have an outdated cookbook?
Hide
Permalink
Andrea Campi added a comment -

I don't have time to tackle this right now.

Show
Andrea Campi added a comment - I don't have time to tackle this right now.
Hide
Permalink
Dan Crosta added a comment -

I may have time in the next week or two to work on this. If I do, Andrea would you be willing/able to help code review it and shepherd it towards inclusion in a release?

Show
Dan Crosta added a comment - I may have time in the next week or two to work on this. If I do, Andrea would you be willing/able to help code review it and shepherd it towards inclusion in a release?
Hide
Permalink
Michael Hart added a comment -

Reproduced on a FreeBSD instance (FreeBSD 9.0-RELEASE-p3) with chef 10.12.0 and the community ntp cookbook, which has this section in the recipe:

node['ntp']['packages'].each do |ntppkg|
Chef::Log.info('Checking package #{ntppkg}')
package ntppkg
end

and the relevant attributes section:
default['ntp']['packages'] = %w{ ntp }

I'm not sure why it should be going to /usr/src to check the package name when it's available through 'pkg_add -r ntp'.

Note that even when the ntp package is installed, the "make -V PKGNAME" command still returns nothing.

Show
Michael Hart added a comment - Reproduced on a FreeBSD instance (FreeBSD 9.0-RELEASE-p3) with chef 10.12.0 and the community ntp cookbook, which has this section in the recipe: node ['ntp'] ['packages'] .each do |ntppkg| Chef::Log.info('Checking package #{ntppkg}') package ntppkg end and the relevant attributes section: default ['ntp'] ['packages'] = %w{ ntp } I'm not sure why it should be going to /usr/src to check the package name when it's available through 'pkg_add -r ntp'. Note that even when the ntp package is installed, the "make -V PKGNAME" command still returns nothing.

People

  • Assignee:
    Unassigned
    Reporter:
    Dan Crosta
Vote (2)
Watch (1)

Dates

  • Created:
    Updated: